From 9b5f85fb0a3e27040bc72451893d2dc35bb5d8bd Mon Sep 17 00:00:00 2001 From: Noah Misch Date: Sun, 7 Jun 2020 16:27:13 -0700 Subject: [PATCH] MSVC: Avoid warning when testing a TAP suite without PROVE_FLAGS. Commit 7be5d8df1f74b78620167d3abf32ee607e728919 surfaced the logic error, which had no functional implications, by adding "use warnings". The buildfarm always customizes PROVE_FLAGS, so the warning did not appear there. Back-patch to 9.5 (all supported versions). --- src/tools/msvc/vcregress.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/tools/msvc/vcregress.pl b/src/tools/msvc/vcregress.pl index 0a98f6e37d..4a53a004b7 100644 --- a/src/tools/msvc/vcregress.pl +++ b/src/tools/msvc/vcregress.pl @@ -198,7 +198,7 @@ sub tap_check unless $config->{tap_tests}; my @flags; - foreach my $arg (0 .. scalar(@_)) + foreach my $arg (0 .. scalar(@_) - 1) { next unless $_[$arg] =~ /^PROVE_FLAGS=(.*)/; @flags = split(/\s+/, $1);