From a27be40c1bc328f4bab324ccecd601909ec94ac9 Mon Sep 17 00:00:00 2001 From: Noah Misch Date: Mon, 6 Nov 2023 06:14:13 -0800 Subject: [PATCH] Set GUC "is_superuser" in all processes that set AuthenticatedUserId. It was always false in single-user mode, in autovacuum workers, and in background workers. This had no specifically-identified security consequences, but non-core code or future work might make it security-relevant. Back-patch to v11 (all supported versions). Jelte Fennema-Nio. Reported by Jelte Fennema-Nio. --- src/backend/utils/init/miscinit.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/backend/utils/init/miscinit.c b/src/backend/utils/init/miscinit.c index c172295ffd..c7f3ee733d 100644 --- a/src/backend/utils/init/miscinit.c +++ b/src/backend/utils/init/miscinit.c @@ -700,6 +700,14 @@ InitializeSessionUserIdStandalone(void) AuthenticatedUserIsSuperuser = true; SetSessionUserId(BOOTSTRAP_SUPERUSERID, true); + + /* + * XXX This should set SetConfigOption("session_authorization"), too. + * Since we don't, C code will get NULL, and current_setting() will get an + * empty string. + */ + SetConfigOption("is_superuser", "on", + PGC_INTERNAL, PGC_S_DYNAMIC_DEFAULT); }