Disallow the cost balancing code from resulting in a zero cost limit, which

causes a division-by-zero error in the vacuum code.  This can happen when there
are more workers than cost limit units.

Per report from Galy Lee in
<200705310914.l4V9E6JA094603@wwwmaster.postgresql.org>.
This commit is contained in:
Alvaro Herrera 2007-06-08 21:21:28 +00:00
parent 2b438c12cc
commit a4d5872719
1 changed files with 6 additions and 2 deletions

View File

@ -10,7 +10,7 @@
*
*
* IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/postmaster/autovacuum.c,v 1.48 2007/06/08 21:09:49 alvherre Exp $
* $PostgreSQL: pgsql/src/backend/postmaster/autovacuum.c,v 1.49 2007/06/08 21:21:28 alvherre Exp $
*
*-------------------------------------------------------------------------
*/
@ -1599,7 +1599,11 @@ autovac_balance_cost(void)
int limit = (int)
(cost_avail * worker->wi_cost_limit_base / cost_total);
worker->wi_cost_limit = Min(limit, worker->wi_cost_limit_base);
/*
* We put a lower bound of 1 to the cost_limit, to avoid division-
* by-zero in the vacuum code.
*/
worker->wi_cost_limit = Max(Min(limit, worker->wi_cost_limit_base), 1);
elog(DEBUG2, "autovac_balance_cost(pid=%u db=%u, rel=%u, cost_limit=%d, cost_delay=%d)",
worker->wi_workerpid, worker->wi_dboid,