From a628e0c5b484eed450093258440cf858bcdb0555 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Mon, 10 Dec 2018 10:38:49 -0500 Subject: [PATCH] Make TupleDescInitBuiltinEntry throw error for unsupported types. Previously, it would just pass back a partially-uninitialized tupdesc, which doesn't seem like a safe or useful behavior. Backpatch to v10 where this code came in. Discussion: https://postgr.es/m/30830.1544384975@sss.pgh.pa.us --- src/backend/access/common/tupdesc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/backend/access/common/tupdesc.c b/src/backend/access/common/tupdesc.c index b0434b4672..852b96ebbb 100644 --- a/src/backend/access/common/tupdesc.c +++ b/src/backend/access/common/tupdesc.c @@ -748,6 +748,9 @@ TupleDescInitBuiltinEntry(TupleDesc desc, att->attstorage = 'p'; att->attcollation = InvalidOid; break; + + default: + elog(ERROR, "unsupported type %u", oidtypeid); } }