From a6463d287b4a313994760a315461d6af86da1873 Mon Sep 17 00:00:00 2001 From: Daniel Gustafsson Date: Wed, 17 Jan 2024 11:24:11 +0100 Subject: [PATCH] Close socket in case of errors in setting non-blocking If configuring the newly created socket non-blocking fails we error out and return INVALID_SOCKET, but the socket that had been created wasn't closed. Fix by issuing closesocket in the errorpath. Backpatch to all supported branches. Author: Ranier Vilela Discussion: https://postgr.es/m/CAEudQApmU5CrKefH85VbNYE2y8H=-qqEJbg6RAPU65+vCe+89A@mail.gmail.com Backpatch-through: v12 --- src/backend/port/win32/socket.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/backend/port/win32/socket.c b/src/backend/port/win32/socket.c index 6fbd1ed6fb..10b8548306 100644 --- a/src/backend/port/win32/socket.c +++ b/src/backend/port/win32/socket.c @@ -290,6 +290,7 @@ pgwin32_socket(int af, int type, int protocol) if (ioctlsocket(s, FIONBIO, &on)) { TranslateSocketError(); + closesocket(s); return INVALID_SOCKET; } errno = 0;