From a775406ec439bc585a17f8edffd47641390d6e5a Mon Sep 17 00:00:00 2001 From: Magnus Hagander Date: Sun, 30 Oct 2016 14:10:39 +0100 Subject: [PATCH] Fix memory leak in tar file padding Spotted by Coverity, patch by Michael Paquier --- src/bin/pg_basebackup/walmethods.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/bin/pg_basebackup/walmethods.c b/src/bin/pg_basebackup/walmethods.c index 1ecc23c256..40c8a5c697 100644 --- a/src/bin/pg_basebackup/walmethods.c +++ b/src/bin/pg_basebackup/walmethods.c @@ -442,9 +442,14 @@ tar_write_padding_data(TarMethodFile * f, size_t bytes) ssize_t r = tar_write(f, zerobuf, bytestowrite); if (r < 0) + { + pg_free(zerobuf); return false; + } bytesleft -= r; } + + pg_free(zerobuf); return true; }