From ac7df108cf32e11e4bd120898ed09bd58fa5b62c Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Sun, 23 Jan 2022 13:54:24 -0500 Subject: [PATCH] pg_dump: avoid useless query in binary_upgrade_set_type_oids_by_type_oid Commit 6df7a9698 wrote appendPQExpBuffer where it should have written printfPQExpBuffer. This resulted in re-issuing the previous query along with the desired one, which very accidentally had no negative consequences except for some wasted cycles. Back-patch to v14 where that came in. Discussion: https://postgr.es/m/1714711.1642962663@sss.pgh.pa.us --- src/bin/pg_dump/pg_dump.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c index 7c0e396ce1..f1e8b0b5c2 100644 --- a/src/bin/pg_dump/pg_dump.c +++ b/src/bin/pg_dump/pg_dump.c @@ -4574,7 +4574,7 @@ binary_upgrade_set_type_oids_by_type_oid(Archive *fout, { if (fout->remoteVersion >= 140000) { - appendPQExpBuffer(upgrade_query, + printfPQExpBuffer(upgrade_query, "SELECT t.oid, t.typarray " "FROM pg_catalog.pg_type t " "JOIN pg_catalog.pg_range r "