On Mon, 3 Sep 2001 22:01:17 -0500, you wrote:

>public boolean isWritable(int column) throws SQLException
>{
>        if (isReadOnly(column))
>                return true;
>        else
>                return false;
>}

The author probably intended:

    public boolean isWritable(int column) throws SQLException
    {
        return !isReadOnly(column);
    }

And if he would have coded it this way he wouldn't have made
this mistake :-)

>hence, isWritable() will always return false. this is something
>of a problem :)

Why exactly? In a way, true is just as incorrect as false, and
perhaps it should throw "not implemented". But I guess that
would be too non-backwardly-compatible.

>let me know if i can provide further information.

Will you submit a patch?

Regards,
Ren? Pijlman <rene@lab.applinet.nl>
This commit is contained in:
Bruce Momjian 2001-09-06 18:26:37 +00:00
parent e4cfff6520
commit afa178e7e2
2 changed files with 2 additions and 8 deletions

View File

@ -419,10 +419,7 @@ public class ResultSetMetaData implements java.sql.ResultSetMetaData
*/
public boolean isWritable(int column) throws SQLException
{
if (isReadOnly(column))
return true;
else
return false;
return !isReadOnly(column);
}
/**

View File

@ -414,10 +414,7 @@ public class ResultSetMetaData implements java.sql.ResultSetMetaData
*/
public boolean isWritable(int column) throws SQLException
{
if (isReadOnly(column))
return true;
else
return false;
return !isReadOnly(column);
}
/**