From afd0fcbc5d421454e7d55d949cca0721c9c135c3 Mon Sep 17 00:00:00 2001 From: Heikki Linnakangas Date: Fri, 16 May 2014 11:23:17 +0300 Subject: [PATCH] Fix test_decoding test case's check that slot has been dropped. pg_stat_replication shows connected replication clients. The ddl test case never has any replication clients connected, so querying pg_stat_replication is pointless. To check that a slot has been dropped correctly, query pg_replication_slots instead. Andres Freund --- contrib/test_decoding/expected/ddl.out | 8 ++++---- contrib/test_decoding/sql/ddl.sql | 5 +++-- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/contrib/test_decoding/expected/ddl.out b/contrib/test_decoding/expected/ddl.out index 05a4bd3f7e..e13a6c7370 100644 --- a/contrib/test_decoding/expected/ddl.out +++ b/contrib/test_decoding/expected/ddl.out @@ -639,9 +639,9 @@ SELECT pg_drop_replication_slot('regression_slot'); (1 row) -/* check that we aren't visible anymore now */ -SELECT * FROM pg_stat_replication; - pid | usesysid | usename | application_name | client_addr | client_hostname | client_port | backend_start | backend_xmin | state | sent_location | write_location | flush_location | replay_location | sync_priority | sync_state ------+----------+---------+------------------+-------------+-----------------+-------------+---------------+--------------+-------+---------------+----------------+----------------+-----------------+---------------+------------ +/* check that the slot is gone */ +SELECT * FROM pg_replication_slots; + slot_name | plugin | slot_type | datoid | database | active | xmin | catalog_xmin | restart_lsn +-----------+--------+-----------+--------+----------+--------+------+--------------+------------- (0 rows) diff --git a/contrib/test_decoding/sql/ddl.sql b/contrib/test_decoding/sql/ddl.sql index 555a59c5ad..87e74c64f3 100644 --- a/contrib/test_decoding/sql/ddl.sql +++ b/contrib/test_decoding/sql/ddl.sql @@ -331,7 +331,8 @@ SELECT data FROM pg_logical_slot_get_changes('regression_slot', NULL, NULL, 'inc -- done, free logical replication slot SELECT data FROM pg_logical_slot_get_changes('regression_slot', NULL, NULL, 'include-xids', '0'); + SELECT pg_drop_replication_slot('regression_slot'); -/* check that we aren't visible anymore now */ -SELECT * FROM pg_stat_replication; +/* check that the slot is gone */ +SELECT * FROM pg_replication_slots;