Quote filenames in error messages
The majority of all filenames are quoted in user facing error and log messages, but a few were still printed without quotes. While these filenames do not risk causing any ambiguity as their format is strict, quote them anyways to be consistent across all logs. Also concatenate a message to keep it one line to make it easier to grep for in the code. Reviewed-by: Peter Eisentraut <peter@eisentraut.org> Reviewed-by: Michael Paquier <michael@paquier.xyz> Discussion: https://postgr.es/m/080EEABE-6645-4A46-AB20-6285ADAC44FE@yesql.se
This commit is contained in:
parent
be6f7cd9bb
commit
b0ec61c9c2
|
@ -2248,8 +2248,7 @@ XLogWrite(XLogwrtRqst WriteRqst, TimeLineID tli, bool flexible)
|
|||
errno = save_errno;
|
||||
ereport(PANIC,
|
||||
(errcode_for_file_access(),
|
||||
errmsg("could not write to log file %s "
|
||||
"at offset %u, length %zu: %m",
|
||||
errmsg("could not write to log file \"%s\" at offset %u, length %zu: %m",
|
||||
xlogfname, startoffset, nleft)));
|
||||
}
|
||||
nleft -= written;
|
||||
|
|
|
@ -418,11 +418,11 @@ WALDumpReadPage(XLogReaderState *state, XLogRecPtr targetPagePtr, int reqLen,
|
|||
if (errinfo.wre_errno != 0)
|
||||
{
|
||||
errno = errinfo.wre_errno;
|
||||
pg_fatal("could not read from file %s, offset %d: %m",
|
||||
pg_fatal("could not read from file \"%s\", offset %d: %m",
|
||||
fname, errinfo.wre_off);
|
||||
}
|
||||
else
|
||||
pg_fatal("could not read from file %s, offset %d: read %d of %d",
|
||||
pg_fatal("could not read from file \"%s\", offset %d: read %d of %d",
|
||||
fname, errinfo.wre_off, errinfo.wre_read,
|
||||
errinfo.wre_req);
|
||||
}
|
||||
|
|
Loading…
Reference in New Issue