From b3d7d6e462fce56ec68ca8dd5424f36f630c60f6 Mon Sep 17 00:00:00 2001 From: Alvaro Herrera Date: Sun, 30 Jan 2022 12:25:24 -0300 Subject: [PATCH] Remove xloginsert.h from xlog.h xlog.h is directly and indirectly #included in a lot of places. With this change, xloginsert.h is no longer unnecessarily included in the large number of them that don't need it. Author: Bharath Rupireddy Discussion: https://postgr.es/m/CALj2ACVe-W+WM5P44N7eG9C2_FmaeM8Dq5aCnD3fHt0Ba=WR6w@mail.gmail.com --- contrib/pg_surgery/heap_surgery.c | 1 + contrib/pg_visibility/pg_visibility.c | 1 + src/backend/access/gist/gist.c | 1 + src/backend/access/hash/hash.c | 1 + src/backend/access/hash/hashinsert.c | 1 + src/backend/access/hash/hashovfl.c | 1 + src/backend/access/hash/hashpage.c | 1 + src/backend/access/heap/pruneheap.c | 1 + src/backend/access/heap/vacuumlazy.c | 1 + src/backend/access/heap/visibilitymap.c | 1 + src/backend/access/nbtree/nbtdedup.c | 1 + src/backend/access/nbtree/nbtree.c | 1 + src/backend/access/transam/commit_ts.c | 1 + src/backend/commands/tablecmds.c | 1 + src/backend/replication/logical/message.c | 1 + src/backend/replication/logical/origin.c | 1 + src/backend/storage/buffer/bufmgr.c | 1 + src/backend/storage/freespace/freespace.c | 1 + src/backend/utils/cache/inval.c | 1 + src/backend/utils/init/postinit.c | 1 + src/include/access/xlog.h | 1 - 21 files changed, 20 insertions(+), 1 deletion(-) diff --git a/contrib/pg_surgery/heap_surgery.c b/contrib/pg_surgery/heap_surgery.c index 3d8eb0abc2..3e641aa644 100644 --- a/contrib/pg_surgery/heap_surgery.c +++ b/contrib/pg_surgery/heap_surgery.c @@ -14,6 +14,7 @@ #include "access/heapam.h" #include "access/visibilitymap.h" +#include "access/xloginsert.h" #include "catalog/pg_am_d.h" #include "catalog/pg_proc_d.h" #include "miscadmin.h" diff --git a/contrib/pg_visibility/pg_visibility.c b/contrib/pg_visibility/pg_visibility.c index 44331c6f49..1853c354e3 100644 --- a/contrib/pg_visibility/pg_visibility.c +++ b/contrib/pg_visibility/pg_visibility.c @@ -13,6 +13,7 @@ #include "access/heapam.h" #include "access/htup_details.h" #include "access/visibilitymap.h" +#include "access/xloginsert.h" #include "catalog/pg_type.h" #include "catalog/storage_xlog.h" #include "funcapi.h" diff --git a/src/backend/access/gist/gist.c b/src/backend/access/gist/gist.c index c3cdfca9a2..8c6c744ab7 100644 --- a/src/backend/access/gist/gist.c +++ b/src/backend/access/gist/gist.c @@ -16,6 +16,7 @@ #include "access/gist_private.h" #include "access/gistscan.h" +#include "access/xloginsert.h" #include "catalog/pg_collation.h" #include "commands/vacuum.h" #include "miscadmin.h" diff --git a/src/backend/access/hash/hash.c b/src/backend/access/hash/hash.c index d48c8a4549..a259a301fa 100644 --- a/src/backend/access/hash/hash.c +++ b/src/backend/access/hash/hash.c @@ -22,6 +22,7 @@ #include "access/hash_xlog.h" #include "access/relscan.h" #include "access/tableam.h" +#include "access/xloginsert.h" #include "catalog/index.h" #include "commands/progress.h" #include "commands/vacuum.h" diff --git a/src/backend/access/hash/hashinsert.c b/src/backend/access/hash/hashinsert.c index 2dfa0ec35e..faf609c157 100644 --- a/src/backend/access/hash/hashinsert.c +++ b/src/backend/access/hash/hashinsert.c @@ -17,6 +17,7 @@ #include "access/hash.h" #include "access/hash_xlog.h" +#include "access/xloginsert.h" #include "miscadmin.h" #include "storage/buf_internals.h" #include "storage/lwlock.h" diff --git a/src/backend/access/hash/hashovfl.c b/src/backend/access/hash/hashovfl.c index c9449b74d8..4836875196 100644 --- a/src/backend/access/hash/hashovfl.c +++ b/src/backend/access/hash/hashovfl.c @@ -19,6 +19,7 @@ #include "access/hash.h" #include "access/hash_xlog.h" +#include "access/xloginsert.h" #include "miscadmin.h" #include "utils/rel.h" diff --git a/src/backend/access/hash/hashpage.c b/src/backend/access/hash/hashpage.c index ee351aea09..28c5297a1d 100644 --- a/src/backend/access/hash/hashpage.c +++ b/src/backend/access/hash/hashpage.c @@ -30,6 +30,7 @@ #include "access/hash.h" #include "access/hash_xlog.h" +#include "access/xloginsert.h" #include "miscadmin.h" #include "port/pg_bitutils.h" #include "storage/lmgr.h" diff --git a/src/backend/access/heap/pruneheap.c b/src/backend/access/heap/pruneheap.c index b3e2eec52f..b6500763a5 100644 --- a/src/backend/access/heap/pruneheap.c +++ b/src/backend/access/heap/pruneheap.c @@ -19,6 +19,7 @@ #include "access/htup_details.h" #include "access/transam.h" #include "access/xlog.h" +#include "access/xloginsert.h" #include "catalog/catalog.h" #include "miscadmin.h" #include "pgstat.h" diff --git a/src/backend/access/heap/vacuumlazy.c b/src/backend/access/heap/vacuumlazy.c index 1c2f30b686..f09ad8f271 100644 --- a/src/backend/access/heap/vacuumlazy.c +++ b/src/backend/access/heap/vacuumlazy.c @@ -44,6 +44,7 @@ #include "access/visibilitymap.h" #include "access/xact.h" #include "access/xlog.h" +#include "access/xloginsert.h" #include "catalog/index.h" #include "catalog/storage.h" #include "commands/dbcommands.h" diff --git a/src/backend/access/heap/visibilitymap.c b/src/backend/access/heap/visibilitymap.c index 9032d4758f..e09f25a684 100644 --- a/src/backend/access/heap/visibilitymap.c +++ b/src/backend/access/heap/visibilitymap.c @@ -88,6 +88,7 @@ #include "access/heapam_xlog.h" #include "access/visibilitymap.h" +#include "access/xloginsert.h" #include "access/xlogutils.h" #include "miscadmin.h" #include "port/pg_bitutils.h" diff --git a/src/backend/access/nbtree/nbtdedup.c b/src/backend/access/nbtree/nbtdedup.c index 1547e73049..4c48554aec 100644 --- a/src/backend/access/nbtree/nbtdedup.c +++ b/src/backend/access/nbtree/nbtdedup.c @@ -16,6 +16,7 @@ #include "access/nbtree.h" #include "access/nbtxlog.h" +#include "access/xloginsert.h" #include "miscadmin.h" #include "utils/rel.h" diff --git a/src/backend/access/nbtree/nbtree.c b/src/backend/access/nbtree/nbtree.c index 13024af2fa..c9b4964c1e 100644 --- a/src/backend/access/nbtree/nbtree.c +++ b/src/backend/access/nbtree/nbtree.c @@ -22,6 +22,7 @@ #include "access/nbtxlog.h" #include "access/relscan.h" #include "access/xlog.h" +#include "access/xloginsert.h" #include "commands/progress.h" #include "commands/vacuum.h" #include "miscadmin.h" diff --git a/src/backend/access/transam/commit_ts.c b/src/backend/access/transam/commit_ts.c index 9419a5ca41..20950eb1e4 100644 --- a/src/backend/access/transam/commit_ts.c +++ b/src/backend/access/transam/commit_ts.c @@ -28,6 +28,7 @@ #include "access/htup_details.h" #include "access/slru.h" #include "access/transam.h" +#include "access/xloginsert.h" #include "access/xlogutils.h" #include "catalog/pg_type.h" #include "funcapi.h" diff --git a/src/backend/commands/tablecmds.c b/src/backend/commands/tablecmds.c index 1f0654c2f5..3e83f375b5 100644 --- a/src/backend/commands/tablecmds.c +++ b/src/backend/commands/tablecmds.c @@ -26,6 +26,7 @@ #include "access/toast_compression.h" #include "access/xact.h" #include "access/xlog.h" +#include "access/xloginsert.h" #include "catalog/catalog.h" #include "catalog/heap.h" #include "catalog/index.h" diff --git a/src/backend/replication/logical/message.c b/src/backend/replication/logical/message.c index b02363f0bd..1c34912610 100644 --- a/src/backend/replication/logical/message.c +++ b/src/backend/replication/logical/message.c @@ -32,6 +32,7 @@ #include "postgres.h" #include "access/xact.h" +#include "access/xloginsert.h" #include "miscadmin.h" #include "nodes/execnodes.h" #include "replication/logical.h" diff --git a/src/backend/replication/logical/origin.c b/src/backend/replication/logical/origin.c index eb040152f9..e91fa93d03 100644 --- a/src/backend/replication/logical/origin.c +++ b/src/backend/replication/logical/origin.c @@ -74,6 +74,7 @@ #include "access/htup_details.h" #include "access/table.h" #include "access/xact.h" +#include "access/xloginsert.h" #include "catalog/catalog.h" #include "catalog/indexing.h" #include "funcapi.h" diff --git a/src/backend/storage/buffer/bufmgr.c b/src/backend/storage/buffer/bufmgr.c index a2512e750c..f5459c68f8 100644 --- a/src/backend/storage/buffer/bufmgr.c +++ b/src/backend/storage/buffer/bufmgr.c @@ -34,6 +34,7 @@ #include #include "access/tableam.h" +#include "access/xloginsert.h" #include "access/xlogutils.h" #include "catalog/catalog.h" #include "catalog/storage.h" diff --git a/src/backend/storage/freespace/freespace.c b/src/backend/storage/freespace/freespace.c index c88cb91f06..78c073b7c9 100644 --- a/src/backend/storage/freespace/freespace.c +++ b/src/backend/storage/freespace/freespace.c @@ -24,6 +24,7 @@ #include "postgres.h" #include "access/htup_details.h" +#include "access/xloginsert.h" #include "access/xlogutils.h" #include "miscadmin.h" #include "storage/freespace.h" diff --git a/src/backend/utils/cache/inval.c b/src/backend/utils/cache/inval.c index 7424008276..af000d4f48 100644 --- a/src/backend/utils/cache/inval.c +++ b/src/backend/utils/cache/inval.c @@ -112,6 +112,7 @@ #include "access/htup_details.h" #include "access/xact.h" +#include "access/xloginsert.h" #include "catalog/catalog.h" #include "catalog/pg_constraint.h" #include "miscadmin.h" diff --git a/src/backend/utils/init/postinit.c b/src/backend/utils/init/postinit.c index cd7c829ff5..5b9ed2f6f5 100644 --- a/src/backend/utils/init/postinit.c +++ b/src/backend/utils/init/postinit.c @@ -27,6 +27,7 @@ #include "access/tableam.h" #include "access/xact.h" #include "access/xlog.h" +#include "access/xloginsert.h" #include "catalog/catalog.h" #include "catalog/namespace.h" #include "catalog/pg_authid.h" diff --git a/src/include/access/xlog.h b/src/include/access/xlog.h index bb0c52686a..5f934dd65a 100644 --- a/src/include/access/xlog.h +++ b/src/include/access/xlog.h @@ -13,7 +13,6 @@ #include "access/rmgr.h" #include "access/xlogdefs.h" -#include "access/xloginsert.h" #include "access/xlogreader.h" #include "datatype/timestamp.h" #include "lib/stringinfo.h"