rdelaage/postgresql
1
0
Fork 0
mirror of https://git.postgresql.org/git/postgresql.git synced 2024-08-23 20:27:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix logical replication's ideas about which type OIDs are built-in.

Browse Source 
Only hand-assigned type OIDs should be presumed to match across different
PG servers; those assigned during genbki.pl or during initdb are likely
to change due to addition or removal of unrelated objects.

This means that the cutoff should be FirstGenbkiObjectId (in HEAD)
or FirstBootstrapObjectId (before that), not FirstNormalObjectId.
Compare postgres_fdw's is_builtin() test.

It's likely that this error has no observable consequence in a
normally-functioning system, since ATM the only affected type OIDs are
system catalog rowtypes and information_schema types, which would not
typically be interesting for logical replication.  But you could
probably break it if you tried hard, so back-patch.

Discussion: https://postgr.es/m/15150.1557257111@sss.pgh.pa.us
This commit is contained in:
Tom Lane 2019-05-13 17:23:00 -04:00
parent bf78f50bae
commit b6abc2241a
2 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/backend/replication/logical/relation.c
View File

@ -425,7 +425,7 @@ logicalrep_typmap_gettypname(Oid remoteid)
bool found;
/* Internal types are mapped directly. */
if (remoteid < FirstNormalObjectId)
if (remoteid < FirstBootstrapObjectId)
{
if (!get_typisdefined(remoteid))
{

10
src/backend/replication/pgoutput/pgoutput.c
View File

@ -269,8 +269,12 @@ maybe_send_schema(LogicalDecodingContext *ctx,
desc = RelationGetDescr(relation);
/*
* Write out type info if needed. We do that only for user created
* types.
* Write out type info if needed. We do that only for user-created
* types. We use FirstBootstrapObjectId as the cutoff, so that we only
* consider objects with hand-assigned OIDs to be "built in", not for
* instance any function or type defined in the information_schema.
* This is important because only hand-assigned OIDs can be expected
* to remain stable across major versions.
*/
for (i = 0; i < desc->natts; i++)
{
@ -279,7 +283,7 @@ maybe_send_schema(LogicalDecodingContext *ctx,
if (att->attisdropped)
continue;
if (att->atttypid < FirstNormalObjectId)
if (att->atttypid < FirstBootstrapObjectId)
continue;
OutputPluginPrepareWrite(ctx, false);