mirror of
https://git.postgresql.org/git/postgresql.git
synced 2024-10-02 22:46:59 +02:00
pg_upgrade: issue helpful error message for use on standbys
Commit 777e6ddf17
checked for a shut down
message from a standby and allowed it to continue. This patch reports a
helpful error message in these cases, suggesting to use rsync as
documented.
Diagnosed-by: Martín Marqués
Discussion: https://postgr.es/m/CAPdiE1xYCow-reLjrhJ9DqrMu-ppNq0ChUUEvVdxhdjGRD5_eA@mail.gmail.com
Backpatch-through: 9.3
This commit is contained in:
parent
ee80124811
commit
b94f7b5350
@ -150,8 +150,14 @@ get_control_data(ClusterInfo *cluster, bool live_check)
|
|||||||
/* remove leading spaces */
|
/* remove leading spaces */
|
||||||
while (*p == ' ')
|
while (*p == ' ')
|
||||||
p++;
|
p++;
|
||||||
if (strcmp(p, "shut down\n") != 0 &&
|
if (strcmp(p, "shut down in recovery\n") == 0)
|
||||||
strcmp(p, "shut down in recovery\n") != 0)
|
{
|
||||||
|
if (cluster == &old_cluster)
|
||||||
|
pg_fatal("The source cluster was shut down while in recovery mode. To upgrade, use \"rsync\" as documented or shut it down as a primary.\n");
|
||||||
|
else
|
||||||
|
pg_fatal("The target cluster was shut down while in recovery mode. To upgrade, use \"rsync\" as documented or shut it down as a primary.\n");
|
||||||
|
}
|
||||||
|
else if (strcmp(p, "shut down\n") != 0)
|
||||||
{
|
{
|
||||||
if (cluster == &old_cluster)
|
if (cluster == &old_cluster)
|
||||||
pg_fatal("The source cluster was not shut down cleanly.\n");
|
pg_fatal("The source cluster was not shut down cleanly.\n");
|
||||||
|
Loading…
Reference in New Issue
Block a user