From ba185d318dd34ed3e860b3a19869fbc15007db8f Mon Sep 17 00:00:00 2001 From: Daniel Gustafsson Date: Thu, 13 Oct 2022 23:18:00 +0200 Subject: [PATCH] Remove redundant memset call following palloc0 This is a follow-up commit to ca7f8e2 which removed the allocation abstraction from pgcrypto and replaced px_alloc + memset calls with palloc0 calls. The particular memset in this commit was missed in that work though. Author: Zhihong Yu Reviewed-by: Bruce Momjian Reviewed-by: Nathan Bossart Discussion: https://postgr.es/m/CALNJ-vT5qRucrFMPSzQyAWods1b4MnNPG-M=_ZUzh1SoTh0vNw@mail.gmail.com --- contrib/pgcrypto/px.c | 1 - 1 file changed, 1 deletion(-) diff --git a/contrib/pgcrypto/px.c b/contrib/pgcrypto/px.c index 3b098c6151..d35ccca777 100644 --- a/contrib/pgcrypto/px.c +++ b/contrib/pgcrypto/px.c @@ -203,7 +203,6 @@ combo_init(PX_Combo *cx, const uint8 *key, unsigned klen, if (klen > ks) klen = ks; keybuf = palloc0(ks); - memset(keybuf, 0, ks); memcpy(keybuf, key, klen); err = px_cipher_init(c, keybuf, klen, ivbuf);