From be39d88934331c47c43d8c51500305e928f06240 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Sat, 30 Jul 2022 15:33:44 -0400 Subject: [PATCH] Add regression test coverage for contrib/pg_buffercache. We can't check the output of this view very closely without creating portability headaches, but we can make sure that the number of rows is as-expected. In any case, this is sufficient to exercise all the C code within, which is a lot better than the 0% coverage we had before. DongWook Lee Discussion: https://postgr.es/m/CAAcByaLCHGJB7qAENEcx9D09UL=w4ma+yijwF_-1MSqQZ9wK6Q@mail.gmail.com --- contrib/pg_buffercache/.gitignore | 4 ++++ contrib/pg_buffercache/Makefile | 2 ++ contrib/pg_buffercache/expected/pg_buffercache.out | 10 ++++++++++ contrib/pg_buffercache/sql/pg_buffercache.sql | 6 ++++++ 4 files changed, 22 insertions(+) create mode 100644 contrib/pg_buffercache/.gitignore create mode 100644 contrib/pg_buffercache/expected/pg_buffercache.out create mode 100644 contrib/pg_buffercache/sql/pg_buffercache.sql diff --git a/contrib/pg_buffercache/.gitignore b/contrib/pg_buffercache/.gitignore new file mode 100644 index 0000000000..5dcb3ff972 --- /dev/null +++ b/contrib/pg_buffercache/.gitignore @@ -0,0 +1,4 @@ +# Generated subdirectories +/log/ +/results/ +/tmp_check/ diff --git a/contrib/pg_buffercache/Makefile b/contrib/pg_buffercache/Makefile index 2ab8c65b65..d74b3e853c 100644 --- a/contrib/pg_buffercache/Makefile +++ b/contrib/pg_buffercache/Makefile @@ -10,6 +10,8 @@ DATA = pg_buffercache--1.2.sql pg_buffercache--1.2--1.3.sql \ pg_buffercache--1.1--1.2.sql pg_buffercache--1.0--1.1.sql PGFILEDESC = "pg_buffercache - monitoring of shared buffer cache in real-time" +REGRESS = pg_buffercache + ifdef USE_PGXS PG_CONFIG = pg_config PGXS := $(shell $(PG_CONFIG) --pgxs) diff --git a/contrib/pg_buffercache/expected/pg_buffercache.out b/contrib/pg_buffercache/expected/pg_buffercache.out new file mode 100644 index 0000000000..138556efc9 --- /dev/null +++ b/contrib/pg_buffercache/expected/pg_buffercache.out @@ -0,0 +1,10 @@ +CREATE EXTENSION pg_buffercache; +select count(*) = (select setting::bigint + from pg_settings + where name = 'shared_buffers') +from pg_buffercache; + ?column? +---------- + t +(1 row) + diff --git a/contrib/pg_buffercache/sql/pg_buffercache.sql b/contrib/pg_buffercache/sql/pg_buffercache.sql new file mode 100644 index 0000000000..e1ba6f7e8d --- /dev/null +++ b/contrib/pg_buffercache/sql/pg_buffercache.sql @@ -0,0 +1,6 @@ +CREATE EXTENSION pg_buffercache; + +select count(*) = (select setting::bigint + from pg_settings + where name = 'shared_buffers') +from pg_buffercache;