rdelaage
/
postgresql
mirror of https://git.postgresql.org/git/postgresql.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Properly set relpersistence for fake relcache entries. 

This can result in buffers failing to be properly flushed at
checkpoint time, leading to data loss.

Report, diagnosis, and patch by Jeff Davis.
This commit is contained in:
Robert Haas 2012-09-14 09:35:07 -04:00
parent 9afc648111
commit beb850e1d8
2 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/backend/access/transam/xlogutils.c
View File

@ -394,6 +394,8 @@ CreateFakeRelcacheEntry(RelFileNode rnode)
FakeRelCacheEntry fakeentry; FakeRelCacheEntry fakeentry;
Relation rel; Relation rel;
Assert(InRecovery);
/* Allocate the Relation struct and all related space in one block. */ /* Allocate the Relation struct and all related space in one block. */
fakeentry = palloc0(sizeof(FakeRelCacheEntryData)); fakeentry = palloc0(sizeof(FakeRelCacheEntryData));
rel = (Relation) fakeentry; rel = (Relation) fakeentry;
@ -403,6 +405,9 @@ CreateFakeRelcacheEntry(RelFileNode rnode)
/* We will never be working with temp rels during recovery */ /* We will never be working with temp rels during recovery */
rel->rd_backend = InvalidBackendId; rel->rd_backend = InvalidBackendId;
/* It must be a permanent table if we're in recovery. */
rel->rd_rel->relpersistence = RELPERSISTENCE_PERMANENT;
/* We don't know the name of the relation; use relfilenode instead */ /* We don't know the name of the relation; use relfilenode instead */
sprintf(RelationGetRelationName(rel), "%u", rnode.relNode); sprintf(RelationGetRelationName(rel), "%u", rnode.relNode);

2
src/backend/storage/buffer/bufmgr.c
View File

@ -271,6 +271,8 @@ ReadBufferWithoutRelcache(RelFileNode rnode, ForkNumber forkNum,
SMgrRelation smgr = smgropen(rnode, InvalidBackendId); SMgrRelation smgr = smgropen(rnode, InvalidBackendId);
Assert(InRecovery);
return ReadBuffer_common(smgr, RELPERSISTENCE_PERMANENT, forkNum, blockNum, return ReadBuffer_common(smgr, RELPERSISTENCE_PERMANENT, forkNum, blockNum,
mode, strategy, &hit); mode, strategy, &hit);
} }