From c079090bbc8ab43525d07cbd9572a3b0a76051aa Mon Sep 17 00:00:00 2001 From: Heikki Linnakangas Date: Thu, 22 Jan 2009 19:16:31 +0000 Subject: [PATCH] Update comments to reflect that tgenabled is not a boolean anymore. Jonah Harris, with minor tinkering by me. --- src/backend/commands/trigger.c | 8 +++++--- src/include/commands/trigger.h | 6 +++++- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/src/backend/commands/trigger.c b/src/backend/commands/trigger.c index 09cc7860e0..699493c335 100644 --- a/src/backend/commands/trigger.c +++ b/src/backend/commands/trigger.c @@ -7,7 +7,7 @@ * Portions Copyright (c) 1994, Regents of the University of California * * IDENTIFICATION - * $PostgreSQL: pgsql/src/backend/commands/trigger.c,v 1.244 2009/01/21 09:28:26 mha Exp $ + * $PostgreSQL: pgsql/src/backend/commands/trigger.c,v 1.245 2009/01/22 19:16:31 heikki Exp $ * *------------------------------------------------------------------------- */ @@ -992,12 +992,14 @@ renametrig(Oid relid, /* * EnableDisableTrigger() * - * Called by ALTER TABLE ENABLE/DISABLE TRIGGER + * Called by ALTER TABLE ENABLE/DISABLE [ REPLICA | ALWAYS ] TRIGGER * to change 'tgenabled' field for the specified trigger(s) * * rel: relation to process (caller must hold suitable lock on it) * tgname: trigger to process, or NULL to scan all triggers - * enable: new value for tgenabled field + * fires_when: new value for tgenabled field. In addition to generic + * enablement/disablement, this also defines when the trigger + * should be fired in session replication roles. * skip_system: if true, skip "system" triggers (constraint triggers) * * Caller should have checked permissions for the table; here we also diff --git a/src/include/commands/trigger.h b/src/include/commands/trigger.h index 50f11078a5..0b0c6c2232 100644 --- a/src/include/commands/trigger.h +++ b/src/include/commands/trigger.h @@ -6,7 +6,7 @@ * Portions Copyright (c) 1996-2009, PostgreSQL Global Development Group * Portions Copyright (c) 1994, Regents of the University of California * - * $PostgreSQL: pgsql/src/include/commands/trigger.h,v 1.70 2009/01/01 17:23:58 momjian Exp $ + * $PostgreSQL: pgsql/src/include/commands/trigger.h,v 1.71 2009/01/22 19:16:31 heikki Exp $ * *------------------------------------------------------------------------- */ @@ -95,6 +95,10 @@ typedef struct TriggerData #define SESSION_REPLICATION_ROLE_LOCAL 2 extern PGDLLIMPORT int SessionReplicationRole; +/* + * States at which a trigger can be fired. These are the + * possible values for pg_trigger.tgenabled. + */ #define TRIGGER_FIRES_ON_ORIGIN 'O' #define TRIGGER_FIRES_ALWAYS 'A' #define TRIGGER_FIRES_ON_REPLICA 'R'