mirror of
https://git.postgresql.org/git/postgresql.git
synced 2024-09-04 15:57:19 +02:00
Correct StartupSUBTRANS for page wraparound
StartupSUBTRANS() incorrectly handled cases near the max pageid in the subtrans data structure, which in some cases could lead to errors in startup for Hot Standby. This patch wraps the pageids correctly, avoiding any such errors. Identified by exhaustive crash testing by Jeff Janes. Jeff Janes
This commit is contained in:
parent
6f43c4d348
commit
c479024d32
@ -44,7 +44,8 @@
|
||||
* 0xFFFFFFFF/SUBTRANS_XACTS_PER_PAGE, and segment numbering at
|
||||
* 0xFFFFFFFF/SUBTRANS_XACTS_PER_PAGE/SLRU_PAGES_PER_SEGMENT. We need take no
|
||||
* explicit notice of that fact in this module, except when comparing segment
|
||||
* and page numbers in TruncateSUBTRANS (see SubTransPagePrecedes).
|
||||
* and page numbers in TruncateSUBTRANS (see SubTransPagePrecedes) and zeroing
|
||||
* them in StartupSUBTRANS.
|
||||
*/
|
||||
|
||||
/* We need four bytes per xact */
|
||||
@ -253,6 +254,9 @@ StartupSUBTRANS(TransactionId oldestActiveXID)
|
||||
{
|
||||
(void) ZeroSUBTRANSPage(startPage);
|
||||
startPage++;
|
||||
/* must account for wraparound */
|
||||
if (startPage > TransactionIdToPage(MaxTransactionId))
|
||||
startPage=0;
|
||||
}
|
||||
(void) ZeroSUBTRANSPage(startPage);
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user