From c5e4ec293ea527394fc1d0006ab88047b3ce580f Mon Sep 17 00:00:00 2001 From: Daniel Gustafsson Date: Mon, 24 Apr 2023 11:40:23 +0200 Subject: [PATCH] ci: Remove OpenSSL 3.1 workaround for missing system CA Commit 0b5d1fb36 fixed the SSL test to properly handle the error message from OpenSSL when the system CA pool is missing of invalid, so with that we can remove the workaround in Cirrus for when Homebrew clears the cert from OPENSSLDIR. Author: Jacob Champion Discussion: https://postgr.es/m/CAAWbhmj3JtKuRcHcMuf1eCJmoZxMXdzLaYpEGmzu9+kgRGpu3A@mail.gmail.com --- .cirrus.yml | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/.cirrus.yml b/.cirrus.yml index b47a8ae100..113f454524 100644 --- a/.cirrus.yml +++ b/.cirrus.yml @@ -477,24 +477,12 @@ task: make \ meson \ openldap \ - openssl@3 \ + openssl \ python \ tcl-tk \ zstd brew cleanup -s # to reduce cache size - - # brew cleanup removes the empty certs directory in OPENSSLDIR, causing - # OpenSSL to report unexpected errors ("unregistered scheme") during - # verification failures. Put it back for now as a workaround. - # - # https://github.com/orgs/Homebrew/discussions/4030 - # - # Note that $(brew --prefix openssl) will give us the opt/ prefix but not - # the etc/ prefix, so we hardcode the full path here. openssl@3 is pinned - # above to try to minimize the chances of this changing beneath us, but it's - # brittle... - mkdir -p "/opt/homebrew/etc/openssl@3/certs" upload_caches: homebrew ccache_cache: