rdelaage/postgresql
1
0
Fork 0
mirror of https://git.postgresql.org/git/postgresql.git synced 2024-10-03 08:26:50 +02:00
Code Issues Packages Projects Releases Wiki Activity

Provide statistics for hypothetical BRIN indexes

Browse Source 
Trying to use hypothetical indexes with BRIN currently fails when trying
to access a relation that does not exist when looking for the
statistics.  With the current API, it is not possible to easily pass
a value for pages_per_range down to the hypothetical index, so this
makes use of the default value of BRIN_DEFAULT_PAGES_PER_RANGE, which
should be fine enough in most cases.

Being able to refine or enforce the hypothetical costs in more
optimistic ways would require more refactoring by filling in the
statistics when building IndexOptInfo in plancat.c.  This would involve
ABI breakages around the costing routines, something not fit for stable
branches.

This is broken since 7e534ad, so backpatch down to v10.

Author: Julien Rouhaud, Heikki Linnakangas
Reviewed-by: Álvaro Herrera, Tom Lane, Michael Paquier
Discussion: https://postgr.es/m/CAOBaU_ZH0LKEA8VFCocr6Lpte1ab0b6FpvgS0y4way+RPSXfYg@mail.gmail.com
Backpatch-through: 10
This commit is contained in:
Michael Paquier 2019-11-21 10:23:38 +09:00
parent 2c9772f5f5
commit c644407f75
1 changed files with 28 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
src/backend/utils/adt/selfuncs.c
View File

@ -102,6 +102,7 @@
#include <math.h> #include <math.h>
#include "access/brin.h" #include "access/brin.h"
#include "access/brin_page.h"
#include "access/gin.h" #include "access/gin.h"
#include "access/table.h" #include "access/table.h"
#include "access/tableam.h" #include "access/tableam.h"
@ -6884,13 +6885,35 @@ brincostestimate(PlannerInfo *root, IndexPath *path, double loop_count,
&spc_seq_page_cost); &spc_seq_page_cost);
/* /*
* Obtain some data from the index itself. A lock should have already * Obtain some data from the index itself, if possible. Otherwise invent
* been obtained on the index in plancat.c. * some plausible internal statistics based on the relation page count.
*/
if (!index->hypothetical)
{
/*
* A lock should have already been obtained on the index in plancat.c.
*/ */
indexRel = index_open(index->indexoid, NoLock); indexRel = index_open(index->indexoid, NoLock);
brinGetStats(indexRel, &statsData); brinGetStats(indexRel, &statsData);
index_close(indexRel, NoLock); index_close(indexRel, NoLock);
/* work out the actual number of ranges in the index */
indexRanges = Max(ceil((double) baserel->pages /
statsData.pagesPerRange), 1.0);
}
else
{
/*
* Assume default number of pages per range, and estimate the number
* of ranges based on that.
*/
indexRanges = Max(ceil((double) baserel->pages /
BRIN_DEFAULT_PAGES_PER_RANGE), 1.0);
statsData.pagesPerRange = BRIN_DEFAULT_PAGES_PER_RANGE;
statsData.revmapNumPages = (indexRanges / REVMAP_PAGE_MAXITEMS) + 1;
}
/* /*
* Compute index correlation * Compute index correlation
* *
@ -6989,10 +7012,6 @@ brincostestimate(PlannerInfo *root, IndexPath *path, double loop_count,
baserel->relid, baserel->relid,
JOIN_INNER, NULL); JOIN_INNER, NULL);
/* work out the actual number of ranges in the index */
indexRanges = Max(ceil((double) baserel->pages / statsData.pagesPerRange),
1.0);
/* /*
* Now calculate the minimum possible ranges we could match with if all of * Now calculate the minimum possible ranges we could match with if all of
* the rows were in the perfect order in the table's heap. * the rows were in the perfect order in the table's heap.