From c6cb62f6137efb67283798b6f8ebc211ff803427 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Thu, 24 Jun 2021 11:30:32 -0400 Subject: [PATCH] Stabilize results of insert-conflict-toast.spec. This back-branch test script was later absorbed into insert-conflict-specconflict.spec, which required some stabilization in commit 741d7f104, so perhaps it's not surprising that it needs a bit of love too. It's odd though that we hadn't seen it fail before now, because I thought that 741d7f104 did not change isolationtester's timing behavior for scripts without any annotation markers. In any case, this script is racy on its face, so add an annotation to force stable reporting order. Report: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=piculet&dt=2021-06-24%2009%3A54%3A56 Report: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=petalura&dt=2021-06-24%2010%3A10%3A00 --- src/test/isolation/specs/insert-conflict-toast.spec | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/test/isolation/specs/insert-conflict-toast.spec b/src/test/isolation/specs/insert-conflict-toast.spec index efd4474f37..595cb70fc5 100644 --- a/src/test/isolation/specs/insert-conflict-toast.spec +++ b/src/test/isolation/specs/insert-conflict-toast.spec @@ -48,4 +48,8 @@ step s3insert { INSERT INTO ctoast (key, val) VALUES (1, ctoast_large_val()) ON CONFLICT DO NOTHING; } -permutation s2insert s3insert s1commit +# s1's commit will release s2 and s3 at the same time, so there's a +# race condition as to which finishes first. Annotate the permutation +# to always report s2 first. + +permutation s2insert s3insert(s2insert) s1commit