rdelaage/postgresql
1
0
Fork 0
mirror of https://git.postgresql.org/git/postgresql.git synced 2024-10-01 14:41:24 +02:00
Code Issues Packages Projects Releases Wiki Activity

The sanity check added to array_recv() wa a bit too tight; we must

Browse Source 
continue to accept an empty array with dimension information. array_send()
can output such arrays.

Per report from Vladimir Shakhov.
This commit is contained in:
Heikki Linnakangas 2010-08-11 19:12:27 +00:00
parent 741396936e
commit c9ae257e23
1 changed files with 13 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
src/backend/utils/adt/arrayfuncs.c
View File

@ -8,7 +8,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/utils/adt/arrayfuncs.c,v 1.164 2010/02/26 02:01:07 momjian Exp $ * $PostgreSQL: pgsql/src/backend/utils/adt/arrayfuncs.c,v 1.165 2010/08/11 19:12:27 heikki Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
@ -1213,17 +1213,21 @@ array_recv(PG_FUNCTION_ARGS)
for (i = 0; i < ndim; i++) for (i = 0; i < ndim; i++)
{ {
int ub;
dim[i] = pq_getmsgint(buf, 4); dim[i] = pq_getmsgint(buf, 4);
lBound[i] = pq_getmsgint(buf, 4); lBound[i] = pq_getmsgint(buf, 4);
ub = lBound[i] + dim[i] - 1; /*
/* overflow? */ * Check overflow of upper bound. (ArrayNItems() below checks that
if (lBound[i] > ub) * dim[i] >= 0)
ereport(ERROR, */
(errcode(ERRCODE_NUMERIC_VALUE_OUT_OF_RANGE), if (dim[i] != 0)
errmsg("integer out of range"))); {
int ub = lBound[i] + dim[i] - 1;
if (lBound[i] > ub)
ereport(ERROR,
(errcode(ERRCODE_NUMERIC_VALUE_OUT_OF_RANGE),
errmsg("integer out of range")));
}
} }
/* This checks for overflow of array dimensions */ /* This checks for overflow of array dimensions */