rdelaage
/
postgresql
mirror of https://git.postgresql.org/git/postgresql.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Replace some appendStringInfo* calls with more appropriate variants 

Author: David Rowley <dgrowleyml@gmail.com>
This commit is contained in:
Peter Eisentraut 2015-05-11 20:38:55 -04:00
parent b488c580ae
commit d02f16470f
6 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
contrib/postgres_fdw/postgres_fdw.c
View File

@ -2734,7 +2734,7 @@ postgresImportForeignSchema(ImportForeignSchemaStmt *stmt, Oid serverOid)
appendStringInfoString(&buf, ", "); appendStringInfoString(&buf, ", ");
deparseStringLiteral(&buf, rv->relname); deparseStringLiteral(&buf, rv->relname);
} }
appendStringInfoString(&buf, ")"); appendStringInfoChar(&buf, ')');
} }
/* Append ORDER BY at the end of query to ensure output ordering */ /* Append ORDER BY at the end of query to ensure output ordering */
@ -2798,7 +2798,7 @@ postgresImportForeignSchema(ImportForeignSchemaStmt *stmt, Oid serverOid)
*/ */
appendStringInfoString(&buf, " OPTIONS (column_name "); appendStringInfoString(&buf, " OPTIONS (column_name ");
deparseStringLiteral(&buf, attname); deparseStringLiteral(&buf, attname);
appendStringInfoString(&buf, ")"); appendStringInfoChar(&buf, ')');
/* Add COLLATE if needed */ /* Add COLLATE if needed */
if (import_collate && collname != NULL && collnamespace != NULL) if (import_collate && collname != NULL && collnamespace != NULL)

2
contrib/test_decoding/test_decoding.c
View File

@ -419,7 +419,7 @@ pg_decode_change(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
get_namespace_name( get_namespace_name(
get_rel_namespace(RelationGetRelid(relation))), get_rel_namespace(RelationGetRelid(relation))),
NameStr(class_form->relname))); NameStr(class_form->relname)));
appendStringInfoString(ctx->out, ":"); appendStringInfoChar(ctx->out, ':');
switch (change->action) switch (change->action)
{ {

2
src/backend/access/rmgrdesc/smgrdesc.c
View File

@ -29,7 +29,7 @@ smgr_desc(StringInfo buf, XLogReaderState *record)
xl_smgr_create *xlrec = (xl_smgr_create *) rec; xl_smgr_create *xlrec = (xl_smgr_create *) rec;
char *path = relpathperm(xlrec->rnode, xlrec->forkNum); char *path = relpathperm(xlrec->rnode, xlrec->forkNum);
appendStringInfo(buf, "%s", path); appendStringInfoString(buf, path);
pfree(path); pfree(path);
} }
else if (info == XLOG_SMGR_TRUNCATE) else if (info == XLOG_SMGR_TRUNCATE)

4
src/backend/access/rmgrdesc/xlogdesc.c
View File

@ -75,7 +75,7 @@ xlog_desc(StringInfo buf, XLogReaderState *record)
{ {
xl_restore_point *xlrec = (xl_restore_point *) rec; xl_restore_point *xlrec = (xl_restore_point *) rec;
appendStringInfo(buf, "%s", xlrec->rp_name); appendStringInfoString(buf, xlrec->rp_name);
} }
else if (info == XLOG_FPI || info == XLOG_FPI_FOR_HINT) else if (info == XLOG_FPI || info == XLOG_FPI_FOR_HINT)
{ {
@ -125,7 +125,7 @@ xlog_desc(StringInfo buf, XLogReaderState *record)
bool fpw; bool fpw;
memcpy(&fpw, rec, sizeof(bool)); memcpy(&fpw, rec, sizeof(bool));
appendStringInfo(buf, "%s", fpw ? "true" : "false"); appendStringInfoString(buf, fpw ? "true" : "false");
} }
else if (info == XLOG_END_OF_RECOVERY) else if (info == XLOG_END_OF_RECOVERY)
{ {

2
src/backend/catalog/namespace.c
View File

@ -2937,7 +2937,7 @@ NameListToString(List *names)
if (IsA(name, String)) if (IsA(name, String))
appendStringInfoString(&string, strVal(name)); appendStringInfoString(&string, strVal(name));
else if (IsA(name, A_Star)) else if (IsA(name, A_Star))
appendStringInfoString(&string, "*"); appendStringInfoChar(&string, '*');
else else
elog(ERROR, "unexpected node type in name list: %d", elog(ERROR, "unexpected node type in name list: %d",
(int) nodeTag(name)); (int) nodeTag(name));

2
src/backend/utils/adt/ruleutils.c
View File

@ -2174,7 +2174,7 @@ print_function_rettype(StringInfo buf, HeapTuple proctup)
appendStringInfoString(&rbuf, "TABLE("); appendStringInfoString(&rbuf, "TABLE(");
ntabargs = print_function_arguments(&rbuf, proctup, true, false); ntabargs = print_function_arguments(&rbuf, proctup, true, false);
if (ntabargs > 0) if (ntabargs > 0)
appendStringInfoString(&rbuf, ")"); appendStringInfoChar(&rbuf, ')');
else else
resetStringInfo(&rbuf); resetStringInfo(&rbuf);
} }