Fix wrong/misleading comments, be more consistent about where to call

ExecAssignResultTypeFromTL().
This commit is contained in:
Tom Lane 2003-01-12 22:01:38 +00:00
parent b05204ac8a
commit d51260aa9d
6 changed files with 14 additions and 17 deletions

View File

@ -8,7 +8,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $Header: /cvsroot/pgsql/src/backend/executor/nodeFunctionscan.c,v 1.16 2002/12/15 16:17:46 tgl Exp $ * $Header: /cvsroot/pgsql/src/backend/executor/nodeFunctionscan.c,v 1.17 2003/01/12 22:01:38 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
@ -247,7 +247,7 @@ ExecInitFunctionScan(FunctionScan *node, EState *estate)
scanstate->ss.ps.ps_TupFromTlist = false; scanstate->ss.ps.ps_TupFromTlist = false;
/* /*
* initialize tuple type * Initialize result tuple type and projection info.
*/ */
ExecAssignResultTypeFromTL(&scanstate->ss.ps); ExecAssignResultTypeFromTL(&scanstate->ss.ps);
ExecAssignProjectionInfo(&scanstate->ss.ps); ExecAssignProjectionInfo(&scanstate->ss.ps);

View File

@ -15,7 +15,7 @@
* locate group boundaries. * locate group boundaries.
* *
* IDENTIFICATION * IDENTIFICATION
* $Header: /cvsroot/pgsql/src/backend/executor/nodeGroup.c,v 1.54 2003/01/10 23:54:24 tgl Exp $ * $Header: /cvsroot/pgsql/src/backend/executor/nodeGroup.c,v 1.55 2003/01/12 22:01:38 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
@ -180,8 +180,7 @@ ExecInitGroup(Group *node, EState *estate)
ExecAssignScanTypeFromOuterPlan(&grpstate->ss); ExecAssignScanTypeFromOuterPlan(&grpstate->ss);
/* /*
* Initialize tuple type for both result and scan. This node does no * Initialize result tuple type and projection info.
* projection
*/ */
ExecAssignResultTypeFromTL(&grpstate->ss.ps); ExecAssignResultTypeFromTL(&grpstate->ss.ps);
ExecAssignProjectionInfo(&grpstate->ss.ps); ExecAssignProjectionInfo(&grpstate->ss.ps);

View File

@ -8,7 +8,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $Header: /cvsroot/pgsql/src/backend/executor/nodeIndexscan.c,v 1.76 2002/12/18 00:14:24 tgl Exp $ * $Header: /cvsroot/pgsql/src/backend/executor/nodeIndexscan.c,v 1.77 2003/01/12 22:01:38 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
@ -583,9 +583,9 @@ ExecInitIndexScan(IndexScan *node, EState *estate)
ExecInitScanTupleSlot(estate, &indexstate->ss); ExecInitScanTupleSlot(estate, &indexstate->ss);
/* /*
* initialize projection info. result type comes from scan desc * Initialize result tuple type and projection info.
* below..
*/ */
ExecAssignResultTypeFromTL(&indexstate->ss.ps);
ExecAssignProjectionInfo(&indexstate->ss.ps); ExecAssignProjectionInfo(&indexstate->ss.ps);
/* /*
@ -893,7 +893,6 @@ ExecInitIndexScan(IndexScan *node, EState *estate)
* get the scan type from the relation descriptor. * get the scan type from the relation descriptor.
*/ */
ExecAssignScanType(&indexstate->ss, RelationGetDescr(currentRelation), false); ExecAssignScanType(&indexstate->ss, RelationGetDescr(currentRelation), false);
ExecAssignResultTypeFromTL(&indexstate->ss.ps);
/* /*
* open the index relations and initialize relation and scan * open the index relations and initialize relation and scan

View File

@ -8,7 +8,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $Header: /cvsroot/pgsql/src/backend/executor/nodeSeqscan.c,v 1.41 2002/12/15 16:17:46 tgl Exp $ * $Header: /cvsroot/pgsql/src/backend/executor/nodeSeqscan.c,v 1.42 2003/01/12 22:01:38 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
@ -229,7 +229,7 @@ ExecInitSeqScan(SeqScan *node, EState *estate)
scanstate->ps.ps_TupFromTlist = false; scanstate->ps.ps_TupFromTlist = false;
/* /*
* initialize tuple type * Initialize result tuple type and projection info.
*/ */
ExecAssignResultTypeFromTL(&scanstate->ps); ExecAssignResultTypeFromTL(&scanstate->ps);
ExecAssignProjectionInfo(&scanstate->ps); ExecAssignProjectionInfo(&scanstate->ps);

View File

@ -12,7 +12,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $Header: /cvsroot/pgsql/src/backend/executor/nodeSubqueryscan.c,v 1.16 2002/12/15 16:17:46 tgl Exp $ * $Header: /cvsroot/pgsql/src/backend/executor/nodeSubqueryscan.c,v 1.17 2003/01/12 22:01:38 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
@ -189,7 +189,7 @@ ExecInitSubqueryScan(SubqueryScan *node, EState *estate)
subquerystate->ss.ps.ps_TupFromTlist = false; subquerystate->ss.ps.ps_TupFromTlist = false;
/* /*
* initialize tuple type * Initialize result tuple type and projection info.
*/ */
ExecAssignResultTypeFromTL(&subquerystate->ss.ps); ExecAssignResultTypeFromTL(&subquerystate->ss.ps);
ExecAssignProjectionInfo(&subquerystate->ss.ps); ExecAssignProjectionInfo(&subquerystate->ss.ps);

View File

@ -8,7 +8,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $Header: /cvsroot/pgsql/src/backend/executor/nodeTidscan.c,v 1.30 2002/12/15 16:17:46 tgl Exp $ * $Header: /cvsroot/pgsql/src/backend/executor/nodeTidscan.c,v 1.31 2003/01/12 22:01:38 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
@ -384,9 +384,9 @@ ExecInitTidScan(TidScan *node, EState *estate)
ExecInitScanTupleSlot(estate, &tidstate->ss); ExecInitScanTupleSlot(estate, &tidstate->ss);
/* /*
* initialize projection info. result type comes from scan desc * Initialize result tuple type and projection info.
* below..
*/ */
ExecAssignResultTypeFromTL(&tidstate->ss.ps);
ExecAssignProjectionInfo(&tidstate->ss.ps); ExecAssignProjectionInfo(&tidstate->ss.ps);
/* /*
@ -431,7 +431,6 @@ ExecInitTidScan(TidScan *node, EState *estate)
* get the scan type from the relation descriptor. * get the scan type from the relation descriptor.
*/ */
ExecAssignScanType(&tidstate->ss, RelationGetDescr(currentRelation), false); ExecAssignScanType(&tidstate->ss, RelationGetDescr(currentRelation), false);
ExecAssignResultTypeFromTL(&tidstate->ss.ps);
/* /*
* if there are some PARAM_EXEC in skankeys then force tid rescan on * if there are some PARAM_EXEC in skankeys then force tid rescan on