From d518d6a168797c2e3b9cf03a3b5cfa335be735bb Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Sat, 2 Apr 2011 18:05:42 -0400 Subject: [PATCH] Fix typo in PQconnectStartParams(). This would lead to leaking the PGconn structure after an error detected by conninfo_array_parse(), as well as failing to return a useful error message in such cases. Backpatch to 9.0 where the error was introduced. Joseph Adams --- src/interfaces/libpq/fe-connect.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/interfaces/libpq/fe-connect.c b/src/interfaces/libpq/fe-connect.c index a4959ee22e..aa24c37f9c 100644 --- a/src/interfaces/libpq/fe-connect.c +++ b/src/interfaces/libpq/fe-connect.c @@ -491,7 +491,7 @@ PQconnectStartParams(const char **keywords, { conn->status = CONNECTION_BAD; /* errorMessage is already set */ - return false; + return conn; } /*