From d7ae549e31ccf19a28375b1f72ec898eeace3c58 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Fri, 4 Sep 2020 21:01:59 -0400 Subject: [PATCH] Make new authentication test case more robust. I happened to notice that the new test case I added in b55b4dad9 falls over if one runs "make check" repeatedly; though not in branches after v10. That's because it was assuming that tmp_check/pgpass wouldn't exist already. However, it's only been since v11 that the Makefiles forcibly remove all of tmp_check/ before starting a TAP run. This fix to unlink the file is therefore strictly necessary only in v10 ... but it seems wisest to do it across the board, rather than let the test rely on external logic to get the conditions right. --- src/test/authentication/t/001_password.pl | 1 + 1 file changed, 1 insertion(+) diff --git a/src/test/authentication/t/001_password.pl b/src/test/authentication/t/001_password.pl index 5976d87793..f0588e3224 100644 --- a/src/test/authentication/t/001_password.pl +++ b/src/test/authentication/t/001_password.pl @@ -95,6 +95,7 @@ my $pgpassfile = "${TestLib::tmp_check}/pgpass"; delete $ENV{"PGPASSWORD"}; $ENV{"PGPASSFILE"} = $pgpassfile; +unlink($pgpassfile); append_to_file($pgpassfile, qq! # This very long comment is just here to exercise handling of long lines in the file. This very long comment is just here to exercise handling of long lines in the file. This very long comment is just here to exercise handling of long lines in the file. This very long comment is just here to exercise handling of long lines in the file. This very long comment is just here to exercise handling of long lines in the file. *:*:postgres:scram_role:pass:this is not part of the password.