From dad08994b25b8cd2caa83b2e856fcc940d5e515c Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Wed, 6 Jan 2016 12:25:32 -0500 Subject: [PATCH] In initdb's post-bootstrap phase, drop temp tables explicitly. Although these temp tables will get removed from template1 at the end of the standalone-backend run, that's too late to keep them from getting copied into the template0 and postgres databases, now that we use only a single backend run for the whole sequence. While no real harm is done by the extra copies (since they'd be deleted on first use of the temp schema), it's still unsightly, and it would mean some wasted cycles for every database creation for the life of the installation. Oversight in commit c4a8812cf64b1426. Noticed by Amit Langote. --- src/bin/initdb/initdb.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/src/bin/initdb/initdb.c b/src/bin/initdb/initdb.c index 35e39ce4b3..3ed0d95df4 100644 --- a/src/bin/initdb/initdb.c +++ b/src/bin/initdb/initdb.c @@ -1781,6 +1781,13 @@ setup_description(FILE *cmdfd) " WHERE opdesc NOT LIKE 'deprecated%' AND " " NOT EXISTS (SELECT 1 FROM pg_description " " WHERE objoid = p_oid AND classoid = 'pg_proc'::regclass);\n\n"); + + /* + * Even though the tables are temp, drop them explicitly so they don't get + * copied into template0/postgres databases. + */ + PG_CMD_PUTS("DROP TABLE tmp_pg_description;\n\n"); + PG_CMD_PUTS("DROP TABLE tmp_pg_shdescription;\n\n"); } #ifdef HAVE_LOCALE_T @@ -1941,6 +1948,12 @@ setup_collation(FILE *cmdfd) " WHERE NOT EXISTS (SELECT 1 FROM pg_collation WHERE collname = tmp_pg_collation.collname)" " ORDER BY collname, encoding, (collname = locale) DESC, locale;\n\n"); + /* + * Even though the table is temp, drop it explicitly so it doesn't get + * copied into template0/postgres databases. + */ + PG_CMD_PUTS("DROP TABLE tmp_pg_collation;\n\n"); + pclose(locale_a_handle); if (count == 0 && !debug)