From dbe4ca6f418a14c5750464a3fff9a9aea266aa13 Mon Sep 17 00:00:00 2001 From: Thomas Munro Date: Thu, 20 Jan 2022 22:11:48 +1300 Subject: [PATCH] Try to stabilize reloptions test, again. Since the test requires reproducible behavior from VACUUM, and since DISABLE_PAGE_SKIPPING doesn't actually disable all forms of page skipping, let's use a temporary table to avoid contention. Back-patch to 12, like commit 3414099c. Discussion: https://postgr.es/m/20220120052404.sonrhq3f3qgplpzj%40alap3.anarazel.de --- src/test/regress/expected/reloptions.out | 2 +- src/test/regress/sql/reloptions.sql | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/test/regress/expected/reloptions.out b/src/test/regress/expected/reloptions.out index a861d167fe..cb04fb706e 100644 --- a/src/test/regress/expected/reloptions.out +++ b/src/test/regress/expected/reloptions.out @@ -89,7 +89,7 @@ ALTER TABLE reloptions_test RESET (fillfactor=12); ERROR: RESET must not include values for parameters -- Test vacuum_truncate option DROP TABLE reloptions_test; -CREATE TABLE reloptions_test(i INT NOT NULL, j text) +CREATE TEMP TABLE reloptions_test(i INT NOT NULL, j text) WITH (vacuum_truncate=false, toast.vacuum_truncate=false, autovacuum_enabled=false); diff --git a/src/test/regress/sql/reloptions.sql b/src/test/regress/sql/reloptions.sql index cf7a8a3509..4252b0202f 100644 --- a/src/test/regress/sql/reloptions.sql +++ b/src/test/regress/sql/reloptions.sql @@ -55,7 +55,7 @@ ALTER TABLE reloptions_test RESET (fillfactor=12); -- Test vacuum_truncate option DROP TABLE reloptions_test; -CREATE TABLE reloptions_test(i INT NOT NULL, j text) +CREATE TEMP TABLE reloptions_test(i INT NOT NULL, j text) WITH (vacuum_truncate=false, toast.vacuum_truncate=false, autovacuum_enabled=false);