From df40e28850eed2b1440ddada849005fb9819201a Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Fri, 30 Aug 2002 05:28:50 +0000 Subject: [PATCH] Fix off-by-one allocation error in PasswordFromFile(), per Gordon Runkle. --- src/interfaces/libpq/fe-connect.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/interfaces/libpq/fe-connect.c b/src/interfaces/libpq/fe-connect.c index b4667cfa43..f7fd94f877 100644 --- a/src/interfaces/libpq/fe-connect.c +++ b/src/interfaces/libpq/fe-connect.c @@ -8,7 +8,7 @@ * * * IDENTIFICATION - * $Header: /cvsroot/pgsql/src/interfaces/libpq/fe-connect.c,v 1.199 2002/08/29 23:06:32 momjian Exp $ + * $Header: /cvsroot/pgsql/src/interfaces/libpq/fe-connect.c,v 1.200 2002/08/30 05:28:50 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -2953,8 +2953,7 @@ PasswordFromFile(char *hostname, char *port, char *dbname, (t = pwdfMatchesString(t, dbname)) == NULL || (t = pwdfMatchesString(t, username)) == NULL) continue; - ret=(char *)malloc(sizeof(char)*strlen(t)); - strncpy(ret, t, strlen(t)); + ret = strdup(t); fclose(fp); return ret; }