mirror of
https://git.postgresql.org/git/postgresql.git
synced 2024-08-18 09:53:27 +02:00
Use a fd opened for read/write when syncing slots during startup.
Some operating systems, including the reporter's windows, return EBADFD or similar when fsync() is invoked on a O_RDONLY file descriptor. Unfortunately RestoreSlotFromDisk() does exactly that; which causes failures after restarts in at least some scenarios. If you hit the bug the error message will be something like ERROR: could not fsync file "pg_replslot/$name/state": Bad file descriptor Simply use O_RDWR instead of O_RDONLY when opening the relevant file descriptor to fix the bug. Unfortunately I have no way of verifying the fix, but we've seen similar problems in the past. This bug goes back to 9.4 where slots were introduced. Backpatch accordingly. Reported-By: Patrice Drolet Bug: #13143: Discussion: 20150424101006.2556.60897@wrigleys.postgresql.org
This commit is contained in:
parent
dcbf5948e1
commit
dfbaed4597
@ -1092,7 +1092,7 @@ RestoreSlotFromDisk(const char *name)
|
||||
|
||||
elog(DEBUG1, "restoring replication slot from \"%s\"", path);
|
||||
|
||||
fd = OpenTransientFile(path, O_RDONLY | PG_BINARY, 0);
|
||||
fd = OpenTransientFile(path, O_RDWR | PG_BINARY, 0);
|
||||
|
||||
/*
|
||||
* We do not need to handle this as we are rename()ing the directory into
|
||||
|
Loading…
Reference in New Issue
Block a user