rdelaage
/
postgresql
mirror of https://git.postgresql.org/git/postgresql.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix message style 

Mark one message not for translation, and prefer "cannot" over "may
not", per commentary from Robert Haas.

Discussion: https://postgr.es/m/20190430145813.GA29872@alvherre.pgsql
This commit is contained in:
Alvaro Herrera 2019-06-06 12:18:14 -04:00
parent 438e51987d
commit e8bdea58f9
3 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/backend/access/heap/heapam.c
View File

@ -1301,7 +1301,7 @@ heap_getnext(TableScanDesc sscan, ScanDirection direction)
if (unlikely(sscan->rs_rd->rd_tableam != GetHeapamTableAmRoutine())) if (unlikely(sscan->rs_rd->rd_tableam != GetHeapamTableAmRoutine()))
ereport(ERROR, ereport(ERROR,
(errcode(ERRCODE_FEATURE_NOT_SUPPORTED), (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
errmsg("only heap AM is supported"))); errmsg_internal("only heap AM is supported")));
/* Note: no locking manipulations needed */ /* Note: no locking manipulations needed */

3
src/backend/access/table/tableamapi.c
View File

@ -106,7 +106,8 @@ check_default_table_access_method(char **newval, void **extra, GucSource source)
{ {
if (**newval == '\0') if (**newval == '\0')
{ {
GUC_check_errdetail("default_table_access_method may not be empty."); GUC_check_errdetail("%s cannot be empty.",
"default_table_access_method");
return false; return false;
} }

2
src/test/regress/expected/create_am.out
View File

@ -110,7 +110,7 @@ NOTICE: drop cascades to index grect2ind2
-- prevent empty values -- prevent empty values
SET default_table_access_method = ''; SET default_table_access_method = '';
ERROR: invalid value for parameter "default_table_access_method": "" ERROR: invalid value for parameter "default_table_access_method": ""
DETAIL: default_table_access_method may not be empty. DETAIL: default_table_access_method cannot be empty.
-- prevent nonexistant values -- prevent nonexistant values
SET default_table_access_method = 'I do not exist AM'; SET default_table_access_method = 'I do not exist AM';
ERROR: invalid value for parameter "default_table_access_method": "I do not exist AM" ERROR: invalid value for parameter "default_table_access_method": "I do not exist AM"