From f04203ab7e683bc3e961a40b002cf3c8d1d12100 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Sun, 6 Sep 2020 12:55:13 -0400 Subject: [PATCH] Fix misleading error message about inconsistent moving-aggregate types. We reported the wrong types when complaining that an aggregate's moving-aggregate implementation is inconsistent with its regular implementation. This was wrong since the feature was introduced, so back-patch to all supported branches. Jeff Janes Discussion: https://postgr.es/m/CAMkU=1x808LH=LPhZp9mNSP0Xd1xDqEd+XeGcvEe48dfE6xV=A@mail.gmail.com --- src/backend/catalog/pg_aggregate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/backend/catalog/pg_aggregate.c b/src/backend/catalog/pg_aggregate.c index 7d887ea24a..6707fbcbf5 100644 --- a/src/backend/catalog/pg_aggregate.c +++ b/src/backend/catalog/pg_aggregate.c @@ -564,8 +564,8 @@ AggregateCreate(const char *aggName, ereport(ERROR, (errcode(ERRCODE_INVALID_FUNCTION_DEFINITION), errmsg("moving-aggregate implementation returns type %s, but plain implementation returns type %s", - format_type_be(aggmTransType), - format_type_be(aggTransType)))); + format_type_be(rettype), + format_type_be(finaltype)))); } /* handle sortop, if supplied */