mirror of
https://git.postgresql.org/git/postgresql.git
synced 2024-10-05 10:16:52 +02:00
Fix redundant error messages in client tools
A few client tools duplicate error messages already provided by libpq. Discussion: https://www.postgresql.org/message-id/flat/3e937641-88a1-e697-612e-99bba4b8e5e4%40enterprisedb.com
This commit is contained in:
parent
3459f4169b
commit
f3ad4fddfa
@ -199,8 +199,7 @@ GetConnection(void)
|
|||||||
|
|
||||||
if (PQstatus(tmpconn) != CONNECTION_OK)
|
if (PQstatus(tmpconn) != CONNECTION_OK)
|
||||||
{
|
{
|
||||||
pg_log_error("could not connect to server: %s",
|
pg_log_error("%s", PQerrorMessage(tmpconn));
|
||||||
PQerrorMessage(tmpconn));
|
|
||||||
PQfinish(tmpconn);
|
PQfinish(tmpconn);
|
||||||
free(values);
|
free(values);
|
||||||
free(keywords);
|
free(keywords);
|
||||||
|
@ -47,8 +47,7 @@ libpqConnect(const char *connstr)
|
|||||||
|
|
||||||
conn = PQconnectdb(connstr);
|
conn = PQconnectdb(connstr);
|
||||||
if (PQstatus(conn) == CONNECTION_BAD)
|
if (PQstatus(conn) == CONNECTION_BAD)
|
||||||
pg_fatal("could not connect to server: %s",
|
pg_fatal("%s", PQerrorMessage(conn));
|
||||||
PQerrorMessage(conn));
|
|
||||||
|
|
||||||
if (showprogress)
|
if (showprogress)
|
||||||
pg_log_info("connected to server");
|
pg_log_info("connected to server");
|
||||||
|
@ -296,7 +296,7 @@ main(int argc, char *argv[])
|
|||||||
|
|
||||||
if (PQstatus(pset.db) == CONNECTION_BAD)
|
if (PQstatus(pset.db) == CONNECTION_BAD)
|
||||||
{
|
{
|
||||||
pg_log_error("could not connect to server: %s", PQerrorMessage(pset.db));
|
pg_log_error("%s", PQerrorMessage(pset.db));
|
||||||
PQfinish(pset.db);
|
PQfinish(pset.db);
|
||||||
exit(EXIT_BADCONN);
|
exit(EXIT_BADCONN);
|
||||||
}
|
}
|
||||||
|
Loading…
Reference in New Issue
Block a user