Make GIN regression test stable.
Commit 7f46eaf
added the regression test which checks that
gin_clean_pending_list() cleans up the GIN pending list and returns >0.
This usually works fine. But if autovacuum comes along and cleans
the list before gin_clean_pending_list() starts, the function may
return 0, and then the regression test may fail.
To fix the problem, this commit disables autovacuum on the target
index of gin_clean_pending_list() by setting autovacuum_enabled
reloption to off when creating the table.
Also this commit sets gin_pending_list_limit reloption to 4MB on
the target index. Otherwise when running "make installcheck" with
small gin_pending_list_limit GUC, insertions of data may trigger
the cleanup of pending list before gin_clean_pending_list() starts
and the function may return 0. This could cause the regression test
to fail.
Per buildfarm member spoonbill.
Reported-By: Tom Lane
This commit is contained in:
parent
a6897efab9
commit
f8a1c1d5a3
|
@ -4,8 +4,9 @@
|
||||||
-- There are other tests to test different GIN opclassed. This is for testing
|
-- There are other tests to test different GIN opclassed. This is for testing
|
||||||
-- GIN itself.
|
-- GIN itself.
|
||||||
-- Create and populate a test table with a GIN index.
|
-- Create and populate a test table with a GIN index.
|
||||||
create table gin_test_tbl(i int4[]);
|
create table gin_test_tbl(i int4[]) with (autovacuum_enabled = off);
|
||||||
create index gin_test_idx on gin_test_tbl using gin (i) with (fastupdate = on);
|
create index gin_test_idx on gin_test_tbl using gin (i)
|
||||||
|
with (fastupdate = on, gin_pending_list_limit = 4096);
|
||||||
insert into gin_test_tbl select array[1, 2, g] from generate_series(1, 20000) g;
|
insert into gin_test_tbl select array[1, 2, g] from generate_series(1, 20000) g;
|
||||||
insert into gin_test_tbl select array[1, 3, g] from generate_series(1, 1000) g;
|
insert into gin_test_tbl select array[1, 3, g] from generate_series(1, 1000) g;
|
||||||
select gin_clean_pending_list('gin_test_idx')>10 as many; -- flush the fastupdate buffers
|
select gin_clean_pending_list('gin_test_idx')>10 as many; -- flush the fastupdate buffers
|
||||||
|
|
|
@ -5,8 +5,9 @@
|
||||||
-- GIN itself.
|
-- GIN itself.
|
||||||
|
|
||||||
-- Create and populate a test table with a GIN index.
|
-- Create and populate a test table with a GIN index.
|
||||||
create table gin_test_tbl(i int4[]);
|
create table gin_test_tbl(i int4[]) with (autovacuum_enabled = off);
|
||||||
create index gin_test_idx on gin_test_tbl using gin (i) with (fastupdate = on);
|
create index gin_test_idx on gin_test_tbl using gin (i)
|
||||||
|
with (fastupdate = on, gin_pending_list_limit = 4096);
|
||||||
insert into gin_test_tbl select array[1, 2, g] from generate_series(1, 20000) g;
|
insert into gin_test_tbl select array[1, 2, g] from generate_series(1, 20000) g;
|
||||||
insert into gin_test_tbl select array[1, 3, g] from generate_series(1, 1000) g;
|
insert into gin_test_tbl select array[1, 3, g] from generate_series(1, 1000) g;
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue