From fa42b2005f0cd825fe5a5fd4db93a7c30b5fe883 Mon Sep 17 00:00:00 2001 From: Robert Haas Date: Thu, 2 Mar 2017 17:03:50 +0530 Subject: [PATCH] Update comments overlooked by 2f5c9d9c9cec436e55847ec580606d7e88067df6. Tomas Vondra --- src/backend/catalog/index.c | 10 +++++----- src/backend/utils/cache/syscache.c | 6 ++---- 2 files changed, 7 insertions(+), 9 deletions(-) diff --git a/src/backend/catalog/index.c b/src/backend/catalog/index.c index f8d92145e8..8d42a347ea 100644 --- a/src/backend/catalog/index.c +++ b/src/backend/catalog/index.c @@ -1858,8 +1858,8 @@ index_update_stats(Relation rel, * 1. In bootstrap mode, we have no choice --- UPDATE wouldn't work. * * 2. We could be reindexing pg_class itself, in which case we can't move - * its pg_class row because CatalogUpdateIndexes might not know about all - * the indexes yet (see reindex_relation). + * its pg_class row because CatalogTupleInsert/CatalogTupleUpdate might + * not know about all the indexes yet (see reindex_relation). * * 3. Because we execute CREATE INDEX with just share lock on the parent * rel (to allow concurrent index creations), an ordinary update could @@ -3542,9 +3542,9 @@ reindex_relation(Oid relid, int flags, int options) * that the updates do not try to insert index entries into indexes we * have not processed yet. (When we are trying to recover from corrupted * indexes, that could easily cause a crash.) We can accomplish this - * because CatalogUpdateIndexes will use the relcache's index list to know - * which indexes to update. We just force the index list to be only the - * stuff we've processed. + * because CatalogTupleInsert/CatalogTupleUpdate will use the relcache's + * index list to know which indexes to update. We just force the index + * list to be only the stuff we've processed. * * It is okay to not insert entries into the indexes we have not processed * yet because all of this is transaction-safe. If we fail partway diff --git a/src/backend/utils/cache/syscache.c b/src/backend/utils/cache/syscache.c index bdfaa0ce75..b1c0b4b1be 100644 --- a/src/backend/utils/cache/syscache.c +++ b/src/backend/utils/cache/syscache.c @@ -100,10 +100,8 @@ adding/deleting caches only requires a recompile.) Finally, any place your relation gets heap_insert() or - heap_update() calls, make sure there is a CatalogUpdateIndexes() or - similar call. The heap_* calls do not update indexes. - - bjm 1999/11/22 + heap_update() calls, use CatalogTupleInsert() or CatalogTupleUpdate() + instead, which also update indexes. The heap_* calls do not do that. *--------------------------------------------------------------------------- */