mirror of
https://git.postgresql.org/git/postgresql.git
synced 2024-09-30 10:11:13 +02:00
In bootstrap mode, use default signal handling for SIGINT etc.
Previously, the code pointed the standard process-termination signals to postgres.c's die(). That would typically result in an attempt to execute a transaction abort, which is not possible in bootstrap mode, leading to PANIC. This choice seems to be a leftover from an old code structure in which the same signal-assignment code was used for many sorts of auxiliary processes, including interactive standalone backends. It's not very sensible for bootstrap mode, which has no interest in either interactivity or continuing after an error. We can get better behavior with less effort by just letting normal process termination happen, after which the parent initdb process will clean up. This is basically cosmetic in any case, since initdb will react the same way whether bootstrap dies on a signal or abort(). Given the lack of previous complaints, I don't feel a need to back-patch, even though the behavior is old. Discussion: https://postgr.es/m/3850b11a.5121.16aaf827e4a.Coremail.thunder1@126.com
This commit is contained in:
parent
037165ca95
commit
fb489e4b31
@ -558,11 +558,15 @@ bootstrap_signals(void)
|
|||||||
{
|
{
|
||||||
Assert(!IsUnderPostmaster);
|
Assert(!IsUnderPostmaster);
|
||||||
|
|
||||||
/* Set up appropriately for interactive use */
|
/*
|
||||||
pqsignal(SIGHUP, die);
|
* We don't actually need any non-default signal handling in bootstrap
|
||||||
pqsignal(SIGINT, die);
|
* mode; "curl up and die" is a sufficient response for all these cases.
|
||||||
pqsignal(SIGTERM, die);
|
* Let's set that handling explicitly, as documentation if nothing else.
|
||||||
pqsignal(SIGQUIT, die);
|
*/
|
||||||
|
pqsignal(SIGHUP, SIG_DFL);
|
||||||
|
pqsignal(SIGINT, SIG_DFL);
|
||||||
|
pqsignal(SIGTERM, SIG_DFL);
|
||||||
|
pqsignal(SIGQUIT, SIG_DFL);
|
||||||
}
|
}
|
||||||
|
|
||||||
/*
|
/*
|
||||||
|
Loading…
Reference in New Issue
Block a user