mirror of
https://git.postgresql.org/git/postgresql.git
synced 2024-08-31 16:37:25 +02:00
Fix ancient bug in ecpg's pthread_once() emulation for Windows.
We must not set the "done" flag until after we've executed the initialization function. Otherwise, other threads can fall through the initial unlocked test before initialization is really complete. This has been seen to cause rare failures of ecpg's thread/descriptor test, and it could presumably cause other sorts of misbehavior in threaded ECPG-using applications, since ecpglib relies on pthread_once() in several places. Diagnosis and patch by me, based on investigation by Alexander Lakhin. Back-patch to all supported branches (the bug dates to 2007). Discussion: https://postgr.es/m/16685-d6cd241872c101d3@postgresql.org
This commit is contained in:
parent
e4538708d5
commit
fd048e0cb5
@ -477,8 +477,8 @@ win32_pthread_once(volatile pthread_once_t *once, void (*fn) (void))
|
||||
pthread_mutex_lock(&win32_pthread_once_lock);
|
||||
if (!*once)
|
||||
{
|
||||
*once = true;
|
||||
fn();
|
||||
*once = true;
|
||||
}
|
||||
pthread_mutex_unlock(&win32_pthread_once_lock);
|
||||
}
|
||||
|
Loading…
Reference in New Issue
Block a user