Commit Graph

21026 Commits

Author SHA1 Message Date
Tom Lane 15269b5955 Avoid useless loop overhead in AtEOXact routines when the backend is
compiled with USE_ASSERT_CHECKING but is running with assert_enabled false.
2005-08-08 19:44:22 +00:00
Tom Lane 4568e0f791 Modify AtEOXact_CatCache and AtEOXact_RelationCache to assume that the
ResourceOwner mechanism already released all reference counts for the
cache entries; therefore, we do not need to scan the catcache or relcache
at transaction end, unless we want to do it as a debugging crosscheck.
Do the crosscheck only in Assert mode.  This is the same logic we had
previously installed in AtEOXact_Buffers to avoid overhead with large
numbers of shared buffers.  I thought it'd be a good idea to do it here
too, in view of Kari Lavikka's recent report showing a real-world case
where AtEOXact_CatCache is taking a significant fraction of runtime.
2005-08-08 19:17:23 +00:00
Tom Lane be27a20123 Cygwin no longer needs to hack SHLIB_LINK, now that Rocco Altier
fixed the contrib library inclusions properly.
2005-08-08 03:35:13 +00:00
Tom Lane 7117cd3a77 Cause ShutdownPostgres to do a normal transaction abort during backend
exit, instead of trying to take shortcuts.  Introduce some additional
shutdown callback routines to eliminate kluges like having ProcKill
be responsible for shutting down the buffer manager.  Ensure that the
order of operations during shutdown is predictable and what you would
expect given the module layering.
2005-08-08 03:12:16 +00:00
Tom Lane 89439b8c4f Set shlib naming convention on Cygwin to 'cygFOO.dll', which appears
to be the platform standard.  This should fix recursive-rule breakage
due to recent Makefile changes.  Per discussion.
2005-08-07 19:02:08 +00:00
Tom Lane 5337ad464e Fix count_usable_fds() to stop trying to open files once it reaches
max_files_per_process.  Going further than that is just a waste of
cycles, and it seems that current Cygwin does not cope gracefully
with deliberately running the system out of FDs.  Per Andrew Dunstan.
2005-08-07 18:47:19 +00:00
Tom Lane 9b29f9f3f8 COPY performance improvements. Avoid calling CopyGetData for each input
character, tighten the inner loops of CopyReadLine and CopyReadAttribute,
arrange to parse out all the attributes of a line in just one call instead
of one CopyReadAttribute call per attribute, be smarter about which client
encodings require slow pg_encoding_mblen() loops.  Also, clean up the
mishmash of static variables and overly-long parameter lists in favor of
passing around a single CopyState struct containing all the state data.
Original patch by Alon Goldshuv, reworked by Tom Lane.
2005-08-06 20:41:58 +00:00
Tom Lane 28d3ee4771 Actually, this macro had worse problems than a bogus name ... 2005-08-05 15:01:48 +00:00
Tom Lane 848c30a501 Fix misspelled macro name. Doesn't appear to be used anywhere yet,
so no one noticed.
2005-08-05 14:36:43 +00:00
Tom Lane 33f5bf9700 ALTER TABLE OWNER must change the ownership of the table's rowtype too.
This was not especially critical before, but it is now that we track
ownership dependencies --- the dependency for the rowtype *must* shift
to the new owner.  Spotted by Bernd Helmle.
Also fix a problem introduced by recent change to allow non-superusers
to do ALTER OWNER in some cases: if the table had a toast table, ALTER
OWNER failed *even for superusers*, because the test being applied would
conclude that the new would-be owner had no create rights on pg_toast.
A side-effect of the fix is to disallow changing the ownership of indexes
or toast tables separately from their parent table, which seems a good
idea on the whole.
2005-08-04 01:09:29 +00:00
Bruce Momjian e48b28b688 Done:
< * Prevent inherited tables from expanding temporary subtables of other
> * -Prevent inherited tables from expanding temporary subtables of other
2005-08-03 01:46:25 +00:00
Tom Lane 6eac4e69cf Tweak BgBufferSync() so that a persistent write error on a dirty buffer
doesn't block the bgwriter from making progress writing out other buffers.
This was a hard problem in the context of the ARC/2Q design, but it's
trivial in the context of clock sweep ... just advance the sweep counter
before we try to write not after.
2005-08-02 20:52:08 +00:00
Tom Lane 688784f671 Prevent planner from including temp tables of other backends when expanding
an inheritance tree.  Per recent discussions.
2005-08-02 20:27:45 +00:00
Tom Lane 558730ac6b Clean up CREATE DATABASE processing to make it more robust and get rid
of special case for Windows port.  Put a PG_TRY around most of createdb()
to ensure that we remove copied subdirectories on failure, even if the
failure happens while creating the pg_database row.  (I think this explains
Oliver Siegmar's recent report.)  Having done that, there's no need for
the fragile assumption that copydir() mustn't ereport(ERROR), so simplify
its API.  Eliminate the old code that used system("cp ...") to copy
subdirectories, in favor of using copydir() on all platforms.  This not
only should allow much better error reporting, but allows us to fsync
the created files before trusting that the copy has succeeded.
2005-08-02 19:02:32 +00:00
Tom Lane 0001e98d54 Code and docs review for pg_column_size() patch. 2005-08-02 16:11:57 +00:00
Tom Lane f023fc6689 Use ReadDir() not readdir() so as to have some modicum of error checking. 2005-08-02 15:17:24 +00:00
Tom Lane 74888b9349 Add ERROR_NO_MORE_FILES workaround to check_data_dir(). This may or
may not be obsolete, but since every other readdir loop in our code
has it, I think this should too.
2005-08-02 15:16:27 +00:00
Tom Lane 9216c8999a rmtree() reported the wrong pathname if final rmdir failed. 2005-08-02 15:14:47 +00:00
Tom Lane 35c4764f88 Un-Windows-ify newlines. 2005-08-02 14:07:27 +00:00
Tom Lane 2a4fad1a0e Add NOWAIT option to SELECT FOR UPDATE/SHARE.
Original patch by Hans-Juergen Schoenig, revisions by Karel Zak
and Tom Lane.
2005-08-01 20:31:16 +00:00
Bruce Momjian ca7abcd89d nor -> or. 2005-08-01 19:38:03 +00:00
Tom Lane f58434f18f Documentation for ALTER object SET SCHEMA commands. Also some minor
editorialization.
2005-08-01 16:11:14 +00:00
Bruce Momjian 614b6e2581 Done:
> * -Allow limits on per-db/role connections
2005-08-01 14:13:30 +00:00
Bruce Momjian 523997daf1 Done:
< 	o Allow objects to be moved to different schemas
> 	o -Allow objects to be moved to different schemas

Fix word wrap:

< 	* Allow GRANT/REVOKE permissions to be applied to all schema objects with one
< 	  command
> 	o Allow GRANT/REVOKE permissions to be applied to all schema objects
> 	  with one command
2005-08-01 14:05:03 +00:00
Tom Lane 35508d1cca Add ALTER object SET SCHEMA capability for a limited but useful set of
object kinds (tables, functions, types).  Documentation is not here yet.
Original code by Bernd Helmle, extensive rework by Bruce Momjian and
Tom Lane.
2005-08-01 04:03:59 +00:00
Bruce Momjian a85e5d1b1b Add description:
< 	  This would require a new global table that is dumped to flat file for
< 	  use by the postmaster.  We do a similar thing for pg_shadow currently.
> 	  This would add a function to load the SQL table from
>           pg_hba.conf, and one to writes its contents to the flat file.
> 	  The table should have a line number that is a float so rows
> 	  can be inserted between existing rows, e.g. row 2.5 goes
> 	  between row 2 and row 3.
2005-08-01 00:52:27 +00:00
Tom Lane d42cf5a42a Add per-user and per-database connection limit options.
This patch also includes preliminary update of pg_dumpall for roles.
Petr Jelinek, with review by Bruce Momjian and Tom Lane.
2005-07-31 17:19:22 +00:00
Bruce Momjian b125877107 Suggest syntax:
< 	o Allow postgresql.conf file values to be changed via an SQL API
> 	o Allow postgresql.conf file values to be changed via an SQL
> 	  API, perhaps using SET GLOBAL
2005-07-31 13:54:52 +00:00
Bruce Momjian 73b574c187 Add item to sentence:
< 	* Allow server logs to be remotely read using SQL commands
151a151
> * Allow server logs to be remotely read and removed using SQL commands
2005-07-31 03:28:52 +00:00
Bruce Momjian 81b1551e41 Spacing improvement. 2005-07-31 03:08:35 +00:00
Tom Lane ecf7fccebc Fix broken markup and spelling, put paragraph in a somewhat less random
place.
2005-07-30 22:53:15 +00:00
Tom Lane a42407c5a2 Use the standard spelling of the protocol argument to get/setsockopt. 2005-07-30 20:28:20 +00:00
Bruce Momjian 5b5013f502 Fix justify_days() for integer datestamp, clean up code. 2005-07-30 18:20:44 +00:00
Bruce Momjian 08d728372e More vacuum markup fixes. Alvaro 2005-07-30 17:15:35 +00:00
Bruce Momjian 31a2824263 Fix VACUUM sgml markup. 2005-07-30 17:03:56 +00:00
Bruce Momjian 2ab9997ec2 Patch to mention cost-based delay in vacuum reference
Alvaro Herrera
2005-07-30 15:45:49 +00:00
Bruce Momjian 1f54d43075 Add GUC variables to control keep-alive times for idle, interval, and
count.

Oliver Jowett
2005-07-30 15:17:26 +00:00
Bruce Momjian b2b6548c79 Please find attached diffs for documentation and simple regression
tests for the new interval->day changes. I added tests for
justify_hours() and justify_days() to interval.sql, as they take
interval input and produce interval output. If there's a more
appropriate place for them, please let me know.

Michael Glaesemann
2005-07-30 14:52:04 +00:00
Bruce Momjian 5b0bfec414 Fix compile for no O_SYNC, but introduced with O_DIRECT. 2005-07-30 14:15:44 +00:00
Bruce Momjian 90524998c0 Add constraint exclusion items:
<
> * Allow EXPLAIN to identify tables that were skipped because of
>   enable_constraint_exclusion
> * Allow EXPLAIN output to be more easily processed by scripts
760a763
> * Allow enable_constraint_exclusion to work for UPDATE and DELETE queries
2005-07-30 04:05:17 +00:00
Bruce Momjian 326816295e Add:
<
> * Allow enable_constraint_exclusion to work for UNIONs like it does for
>   inheritance
2005-07-30 03:59:23 +00:00
Bruce Momjian f9512130f9 Add:
> * Prevent inherited tables from expanding temporary subtables of other
>   sessions
2005-07-30 03:49:17 +00:00
Bruce Momjian b6af0dc49e Update AIX FAQ.
Chris Browne
2005-07-30 03:39:27 +00:00
Bruce Momjian aa8290be99 Add:
> * Add system view to show free space map contents
884c885
< 	o Move into the backend code
> 	o -Move into the backend code
2005-07-30 03:21:41 +00:00
Bruce Momjian 24df49bd5a Add:
> * Allow SELECT ... FOR UPDATE on inherited tables
2005-07-30 03:18:38 +00:00
Bruce Momjian 43e33c51d4 Clarify:
< * Add TRUNCATE permission
> * Add a separate TRUNCATE permission
2005-07-30 03:16:08 +00:00
Bruce Momjian 3fae29ef13 Add:
> * Add TRUNCATE permission
>
>   Currently only the owner can TRUNCATE a table because triggers are not
>   called, and the table is locked in exclusive mode.
>
2005-07-30 03:15:22 +00:00
Bruce Momjian 1521aef1db SUNOS4_CC -> SUNOS_CC. 2005-07-30 03:07:42 +00:00
Bruce Momjian 9ebe05c5bc Add:
> * Add PQescapeIdentifier() to libpq
2005-07-30 02:52:30 +00:00
Tom Lane 284e4739ef Fix an oversight I introduced on 2003-12-28: find_nots/push_nots should
continue to recurse after eliminating a NOT-below-a-NOT, since the
contained subexpression will now be part of the top-level AND/OR structure
and so deserves to be simplified.  The real-world impact of this is
probably minimal, since it'd require at least three levels of NOT to make
a difference, but it's still a bug.
Also remove some redundant tests for NULL subexpressions.
2005-07-29 21:40:02 +00:00