Commit Graph

10040 Commits

Author SHA1 Message Date
Bruce Momjian 7160c86ec2 These patches should fix check constraints not inheriting
when added by alter table add constraint.  The first file
patches backend/commands/command.c and the latter is a patch
to the alter table regression test.

Stephan Szabo
2001-05-30 13:00:03 +00:00
Bruce Momjian 3f5563d131 Playing with the earthdistance stuff, and found I needed the following
patch:

Larry Rosenman
2001-05-30 12:58:45 +00:00
Bruce Momjian 36546c98b5 Attached is my patch that adds DROP CONSTRAINT support to PostgreSQL. I
basically want your guys feedback.  I have sprinkled some of my q's thru
the text delimited with the @@ symbol.  It seems to work perfectly.

[ Removed @@ comments because patch was reviewed. ]

At the moment it does CHECK constraints only, with inheritance.  However,
due to the problem mentioned before with the mismatching between inherited
constraints it may be wise to disable the inheritance feature for a while.
it is written in an extensible fashion to support future dropping of other
types of constraint, and is well documented.

Please send me your comments, check my use of locking, updating of
indices, use of ERROR and NOTICE, etc. and I will rework the patch based
on feedback until everyone
is happy with it...

Christopher Kings
2001-05-30 12:57:36 +00:00
Tom Lane 7d4854f85c Correct obsolete example of FROM-less query. 2001-05-30 04:32:30 +00:00
Bruce Momjian aa665d901f In chapter:
7.7. Keys

you have

    However, my application requires that each collection will also have a
    unique name. Why? So that a human being who wants to modify a collection
    will be able to identify it. It's much harder to know, if you have two
    collections named "Life Science", the the one tagged 24433 is the one
you
    need, and the one tagged 29882 is not

    I think 'the the' shouldn't be repeated twice. Although taken from an
email it would be cool to fix.

Cheers,
Maxim Maletsky
2001-05-30 04:01:11 +00:00
D'Arcy J.M. Cain 8d7952fdc4 Further conversions to Version 1 API. Also, fix boolean return to use
PG_RETURN_BOOL(0) instead of return 0.
2001-05-30 02:11:46 +00:00
D'Arcy J.M. Cain d34a5d8e2d Add missing comma. 2001-05-30 02:04:49 +00:00
Tom Lane 8a3b80deb0 Make text <=> char conversion functions convert zero character to and
from an empty text string.  This makes them consistent with the de facto
behavior of type char's I/O conversion functions, and avoids generating
text values with embedded nulls, which confuse many text operators.
2001-05-28 21:58:32 +00:00
Tom Lane a056f14be0 Cause plpgsql's PERFORM to behave according to its documentation,
which says that PERFORM will execute any SELECT query and discard the
result.  The former implementation would in fact raise an error if the
result contained more than one row or more than one column.

Also, change plpgsql's error-logging mechanism to emit the additional
messages about error location at NOTICE rather than DEBUG level.  This
allows them to be seen by the client without having to dig into the
postmaster log file (which may be nonexistent or inaccessible by the
client).
2001-05-28 19:33:24 +00:00
D'Arcy J.M. Cain 505d9037cd Upgraded code to use the current version 1 calling conventions. 2001-05-28 15:34:27 +00:00
Tom Lane 2ba48262b9 Suppress useless memmove() when buffer already contains left-justified
data.
2001-05-28 15:29:51 +00:00
Peter Eisentraut 3fdfce6839 markup fix 2001-05-28 14:58:58 +00:00
Bruce Momjian 411d7e4278 Update TODO list. 2001-05-28 04:28:36 +00:00
Bruce Momjian 32762facf6 Sample output that appears below the table attributes for \d:
Indicies: palm_buy_date_idx
          palm_user_date_idx
Primary Key: palm_buyers_pkey
Unique Key: palm_buyers_username
Constraint: "$1" ((sex = 'M'::bpchar) OR (sex = 'F'::bpchar))

Note that check constraint name now shown as well.  (Makes it a lot easier
to test inheritance support in ADD/DROP constraint :) )

Attached is a docs change for psql.

Christopher Kings
2001-05-28 04:27:17 +00:00
Bruce Momjian d66a404983 This just breaks down the indices in to three groups:
non-unique: stay as they were
unique and primary: become listed as primary keys
unique and non-primary: become listed as unique keys

I also made it so that it shows the names of check constraints ie:

Check: "$1" (a > 5)

Christopher Kings
2001-05-28 02:01:22 +00:00
Tatsuo Ishii e23f8c4557 Fix a message error in utf_to_local 2001-05-28 01:00:25 +00:00
Bruce Momjian 0380765cc1 Attached is a patch to fix the problem Thomas mentions below. The JDBC
driver now correctly handles timezones that are offset fractional hours
from GMT (ie. -06:30).

Barry Lind
2001-05-28 00:37:00 +00:00
Peter Eisentraut 9a61532a6a Don't use multi-line string literals. 2001-05-27 21:50:50 +00:00
Tom Lane 9e7243063c When using a junkfilter, the output tuple should NOT be stored back into
the same tuple slot that the raw tuple came from, because that slot has
the wrong tuple descriptor.  Store it into its own slot with the correct
descriptor, instead.  This repairs problems with SPI functions seeing
inappropriate tuple descriptors --- for example, plpgsql code failing to
cope with SELECT FOR UPDATE.
2001-05-27 20:48:51 +00:00
Tom Lane a3855c5761 Cause ExecCountSlots() accounting to bear some relationship to reality.
Rather surprising we hadn't seen bug reports about this ...
2001-05-27 20:42:20 +00:00
D'Arcy J.M. Cain 2bc1c14ab0 Changed use of macros for extracting information. According to comments
in c.h we should be using the visible structure.  We should only see
de-TOASTed values in this program.  The old method refused to compile
because the length macro was no longer an lvalue.
2001-05-27 19:06:20 +00:00
Tom Lane 73d1040bd9 Fix eqjoinsel() to make use of new statistics. 2001-05-27 17:37:48 +00:00
Bruce Momjian a001f13506 Update TODO list. 2001-05-27 16:31:30 +00:00
Peter Eisentraut 96147a6d1c Make UPDATE and DELETE privileges distinct. Add REFERENCES and TRIGGER
privileges.  INSERT and COPY FROM now require INSERT (only).  Add
privileges regression test.
2001-05-27 09:59:30 +00:00
D'Arcy J.M. Cain 52350c7ad9 Add NUMERICOID return type. Treat it as floating point for now. This
could be changed if we create a new Python type that matches it better
but NUMERIC <==> FLOAT probably works fine for most cases.
2001-05-27 08:24:52 +00:00
Bruce Momjian 97c7db2e15 Mention failure of ANT to delete directories on clean. 2001-05-25 16:29:17 +00:00
Bruce Momjian 06a8346c84 See attached for a small patch that enables plpython to build cleanly
under Cygwin.  This patch together with my previous Python patch:

    http://postgresql.readysetnet.com/mhonarc/pgsql-patches/2001-05/msg00075.htm
l

enables full Python support (i.e., configure --with-python) for Cygwin
PostgreSQL.

Jason Tishler
2001-05-25 15:48:33 +00:00
Bruce Momjian f6923ff3ac Oops, only wanted python change in the last commit. Backing out. 2001-05-25 15:45:34 +00:00
Bruce Momjian dffb673692 While changing Cygwin Python to build its core as a DLL (like Win32
Python) to support shared extension modules, I have learned that Guido
prefers the style of the attached patch to solve the above problem.
I feel that this solution is particularly appropriate in this case
because the following:

    PglargeType
    PgType
    PgQueryType

are already being handled in the way that I am proposing for PgSourceType.

Jason Tishler
2001-05-25 15:34:50 +00:00
Bruce Momjian 3f7c542a60 Back out, per Peter E.
> > The attached patch changes src/interfaces/python/GNUmakefile to use the
> > value of DESTDIR like the rest (or at least most) of the PostgreSQL
> > makefiles.  I found this problem when trying to package a pre-built
> > Cygwin PostgreSQL distribution, but this problem is platform independent.
2001-05-25 15:32:33 +00:00
Bruce Momjian eeca4bdb31 The attached patch changes src/interfaces/python/GNUmakefile to use the
value of DESTDIR like the rest (or at least most) of the PostgreSQL
makefiles.  I found this problem when trying to package a pre-built
Cygwin PostgreSQL distribution, but this problem is platform independent.

The problem manifests itself when one tries to install into a stagging
area (e.g., to build a tarball) instead of a real install.  In this case,
pg.py and _pgmodule$(SO) still end up being installed in the configured
prefix directory ignoring the value of DESTDIR.

Unfortunately, this patch does not handle the case where PostgreSQL
and Python are configured with different prefixes.  Since the Python
Makefile is automatically generated and does not use DESTDIR, I believe
that this issue will be difficult to correct.  If anyone has ideas on
how to fix this issue, then I'm quite willing to rework the patch to
take the suggestion into account.

Jason Tishler
2001-05-25 14:29:39 +00:00
Bruce Momjian 74068dfed6 The following patch corrects a make install problem when building
under Cygwin.  The root cause of this problem is that (Sun) java is a
native Win32 app and hence does not understand Cygwin Posix style paths.
The solution is to use Cygwin's cygpath utility to convert the Posix style
JDBC installation directory path into a Win32 one before invoking ant.

I'm not sure if my patch is the best way to correct this issue but
my goal was to confine the Cygwin specific constructs to

Jason Tishler
2001-05-25 14:28:58 +00:00
Hiroshi Inoue e5cff3fe64 Get rid of the following size limit.
1) Query size limit(was 65536) for >=7.0 servers.
2) Text size limit(was 8190) for 7.1 servers.
2001-05-25 08:12:32 +00:00
Bruce Momjian f3c1ae58f2 Another Makefile fix for qnx patch. 2001-05-25 04:26:21 +00:00
Bruce Momjian 248a5a7257 Fix tabs in Makefile. 2001-05-25 04:24:33 +00:00
Bruce Momjian a1f14d30b1 Back out qnx plpgsql/Makefile change and move to src/Makefile. 2001-05-24 22:33:18 +00:00
Bruce Momjian f36fc7bb63 I haven't tried building postgres with the Watcom compiler for 7.1 because
it does not support 64bit integers. AFAIK that's the default data type for
OIDs, so I am not surprised that this does not work. Use gcc instead.
BTW., 7.1 does not compile as is with gcc either, I believed the
required patches made it into the 7.1.1 release but obviously I missed
the deadline.
Since the ports mailing list does not seem to be archived I have attached
a copy of the patch (for 7.1 and 7.1.1).

I've just performed a build of a Watcom compiled version and found a couple
of bugs in the watcom specific part of that patch. Please use the attached
version instead.

Tegge, Bernd
2001-05-24 15:53:34 +00:00
Bruce Momjian 6f101c806b There are a number of changes. The main ones are:
return oid on insert
 handle all primitive data types
 handle single quotes and newlines in Strings
 handle null variables
 deal with non public and final variables (not very
   well, though)

Ken K
2001-05-24 15:48:32 +00:00
Bruce Momjian 23287c106d Update TODO list. 2001-05-24 14:36:31 +00:00
Peter Eisentraut 444c5bf1b2 SQL function bit_length 2001-05-24 09:29:29 +00:00
Peter Eisentraut 8a987af4a1 Unset PGLIB so it doesn't slip in from the environment. 2001-05-24 00:13:13 +00:00
Peter Eisentraut 623453a807 Make createlang use dynamic loader enhancements (automatic path and suffix). 2001-05-23 22:00:43 +00:00
Bruce Momjian 0995a5103f Fix ANT for *.properties files. 2001-05-23 20:54:12 +00:00
Bruce Momjian 7c2916a9ee Fix ANT so it only has '*.class' files, not the 'tags' file. 2001-05-23 19:30:35 +00:00
Bruce Momjian 371a04fccf Update TODO list. 2001-05-23 16:02:55 +00:00
Bruce Momjian 02f4ee1a81 Update TODO list. 2001-05-23 00:42:25 +00:00
Bruce Momjian 50bad5ed41 Update FAQ. 2001-05-22 21:50:34 +00:00
Bruce Momjian ef4893e605 Update TODO list. 2001-05-22 19:38:22 +00:00
Bruce Momjian 18b02b9673 Back out timezone fix. Not needed in jdbc1. 2001-05-22 19:19:55 +00:00
Bruce Momjian a62c19e4ec Fix for comments at top of functions. 2001-05-22 17:24:58 +00:00