b4a7e5980b
Cleanup ClusterInfo initialization in pg_upgrade
2011-02-16 14:06:17 -03:00
1cc19cc358
Fix bug in 9.1 pg_upgrade processing of old/new relations; adjust debug
...
output.
2011-02-15 19:01:33 -05:00
8b2557553c
Make pg_upgrade compile again
2011-02-15 19:52:32 -03:00
fe8f15d5d2
Adjust pg_upgrade error message, array freeing, and add error check.
2011-02-15 15:00:47 -05:00
629b3af27d
Convert contrib modules to use the extension facility.
...
This isn't fully tested as yet, in particular I'm not sure that the
"foo--unpackaged--1.0.sql" scripts are OK. But it's time to get some
buildfarm cycles on it.
sepgsql is not converted to an extension, mainly because it seems to
require a very nonstandard installation process.
Dimitri Fontaine and Tom Lane
2011-02-13 22:54:49 -05:00
caddcb8f4b
Fix pg_upgrade to handle extensions.
...
This follows my proposal of yesterday, namely that we try to recreate the
previous state of the extension exactly, instead of allowing CREATE
EXTENSION to run a SQL script that might create some entirely-incompatible
on-disk state. In --binary-upgrade mode, pg_dump won't issue CREATE
EXTENSION at all, but instead uses a kluge function provided by
pg_upgrade_support to recreate the pg_extension row (and extension-level
pg_depend entries) without creating any member objects. The member objects
are then restored in the same way as if they weren't members, in particular
using pg_upgrade's normal hacks to preserve OIDs that need to be preserved.
Then, for each member object, ALTER EXTENSION ADD is issued to recreate the
pg_depend entry that marks it as an extension member.
In passing, fix breakage in pg_upgrade's enum-type support: somebody didn't
fix it when the noise word VALUE got added to ALTER TYPE ADD. Also,
rationalize parsetree representation of COMMENT ON DOMAIN and fix
get_object_address() to allow OBJECT_DOMAIN.
2011-02-09 19:18:08 -05:00
cd7d748d51
Repair multiple breakage in Windows-specific code for appending '.exe'.
2011-02-02 20:26:43 -05:00
2b6e2dee78
Fix wrong verb in pg_upgrade text message, per Haas.
2011-02-02 16:53:12 -05:00
9d220fc17e
Simplify pg_upgrade checking of executable permissions.
2011-02-02 15:40:52 -05:00
2bb87a61a8
Add pg_upgrade comment for why we can't use template1 inheritance for
...
the support functions.
2011-02-01 12:23:08 -05:00
6238473adb
Fix pg_upgrade to create pg_authid restore functions in the 'postgres'
...
database, not in the os-user database, per report from Magnus.
2011-01-31 20:16:15 -05:00
0a5f119931
A toast relid field are no longer needed in pg_upgrade's rel arrays, so
...
remove them. Also other renaming.
2011-01-10 11:46:02 -05:00
002c105a07
In pg_upgrade, remove functions that did sequential array scans looking
...
up relations, but rather order old/new relations and use the same array
index value for both. This should speed up pg_upgrade for databases
with many relations.
2011-01-08 13:44:44 -05:00
ebaf648ad2
In pg_upgrade, clarify use of install_db_support_functions().
2011-01-08 09:11:48 -05:00
a60b32b3dc
In pg_upgrade, remove unnecessary separate handling of toast tables now
...
that we restore by oid; they can be handled like regular tables when
creating the file mapping structure.
2011-01-08 08:01:52 -05:00
133641a48e
Document why pg_upgrade preserves pg_auth.oid (because they are stored
...
in pg_largeobject_metadata).
2011-01-07 23:02:03 -05:00
2f657e4d72
More pg_upgrade relfilenode C comments added.
2011-01-07 22:57:30 -05:00
3095643d37
Simplify pg_upgrade C comment about what is preserved.
2011-01-07 22:46:41 -05:00
f75383e6e8
In pg_upgrade, track only one copy of namespace/relname in FileNameMap
...
because the old and new values are identical.
2011-01-07 22:36:51 -05:00
519c008a96
Fix C indenting in pg_upgrade function.
2011-01-07 22:01:44 -05:00
d8d3d2a4f3
Fix pg_upgrade of large object permissions by preserving pg_auth.oid,
...
which is stored in pg_largeobject_metadata.
No backpatch to 9.0 because you can't migrate from 9.0 to 9.0 with the
same catversion (because of tablespace conflict), and a pre-9.0
migration to 9.0 has not large object permissions to migrate.
2011-01-07 21:59:29 -05:00
2896c87ce4
Force pg_upgrade's to preserve pg_class.oid, not pg_class.relfilenode.
...
Toast tables have identical pg_class.oid and pg_class.relfilenode, but
for clarity it is good to preserve the pg_class.oid.
Update comments regarding what is preserved, and do some
variable/function renaming for clarity.
2011-01-07 21:26:13 -05:00
46d28820b6
Improve C comments about backend variables set by pg_upgrade_support
...
functions.
2011-01-06 22:45:36 -05:00
56a9adcb96
Rename pg_upgrade variables, for clarity.
2011-01-05 20:14:59 -05:00
e66e43988a
Update pg_upgrade C comments.
2011-01-05 14:09:01 -05:00
a45beaac64
Fix for recent pg_upgrade commit to fix large objects relfilenode
...
handling. (metadata user ids still an open issue).
2011-01-05 13:52:44 -05:00
b1f2a94fa2
In pg_upgrade, adjust transfer_relfile()'s parameters to be more logical.
2011-01-05 12:07:45 -05:00
5cff5b5779
Clarify pg_upgrade's creation of the map file structure. Also clean
...
up pg_dump's calling of pg_upgrade_support functions.
2011-01-05 11:37:08 -05:00
3302334b48
In pg_upgrade, copy pg_largeobject_metadata and its index for 9.0+
...
servers because, like pg_largeobject, it is a system table whose
contents are not dumped by pg_dump --schema-only.
2011-01-04 23:35:49 -05:00
0857a84498
In pg_upgrade, fix backward logging display of link operations.
2011-01-04 21:33:36 -05:00
25cc7424e3
Simplify functions and parameters used by pg_upgrade.
2011-01-04 19:11:37 -05:00
5d950e3b0c
Stamp copyrights for year 2011.
2011-01-01 13:18:15 -05:00
67c9e4442f
Furter pg_upgrade optimizations to reduce function call argument count.
2011-01-01 12:28:48 -05:00
6e6bee987f
In pg_upgrade, remove use of whichCluster, and just pass old/new cluster
...
pointers, which simplifies the code. This was not possible in 9.0 because
everything was in a single nested struct, but is possible now.
Per suggestion from Tom.
2011-01-01 12:06:36 -05:00
f82b3e58f8
In pg_upgrade, rename "CLUSTERNAME" to "CLUSTER_NAME".
2010-12-31 20:42:29 -05:00
88c803457a
Improve pg_upgrade's checks for required executables.
...
Don't insist on pg_dumpall and psql being present in the old cluster,
since they are not needed. Do insist on pg_resetxlog being present
(in both old and new), since we need it. Also check for pg_config,
but only in the new cluster. Remove the useless attempt to call
pg_config in the old cluster; we don't need to know the old value of
--pkglibdir. (In the case of a stripped-down migration installation
there might be nothing there to look at anyway, so any future change
that might reintroduce that need would have to be considered carefully.)
Per my attempts to build a minimal previous-version installation to support
pg_upgrade.
2010-12-29 13:43:53 -05:00
16b5e08dec
Use "upgrade" in preference over "migrate" in pg_upgrade messages and
...
documentation. (Many were left over from the old pg_migrator naming.)
2010-12-15 07:11:31 -05:00
3864afa1d1
Clean up some copied-and-pasted code in pg_upgrade.
...
1. Don't reimplement S_ISDIR() and S_ISREG() badly.
2. Don't reimplement access() badly.
This code appears to have been copied from ancient versions of the
corresponding backend routines, and not patched to incorporate subsequent
fixes (see my commits of 2008-03-31 and 2010-01-14 respectively).
It might be a good idea to change it to just *call* those routines,
but for now I'll just transpose these fixes over.
2010-12-11 14:17:46 -05:00
fc946c39ae
Remove useless whitespace at end of lines
2010-11-23 22:34:55 +02:00
5aa446c961
Cleanup various comparisons with the constant "true".
...
Itagaki Takahiro, with slight modifications.
2010-11-14 21:03:48 -05:00
11e482c350
Move copydir() prototype into its own header file.
...
Having this in src/include/port.h makes no sense, now that copydir.c lives
in src/backend/strorage rather than src/port. Along the way, remove an
obsolete comment from contrib/pg_upgrade that makes reference to the old
location.
2010-11-12 16:39:53 -05:00
71baff1786
Fix buffer overrun in pg_upgrade.
...
Problem reported, and cause identified, by Hernan Gonzalez.
2010-11-02 17:31:41 -04:00
84c123be1d
Allow new values to be added to an existing enum type.
...
After much expenditure of effort, we've got this to the point where the
performance penalty is pretty minimal in typical cases.
Andrew Dunstan, reviewed by Brendan Jurd, Dean Rasheed, and Tom Lane
2010-10-24 23:05:41 -04:00
a52aa6c6db
Clean up pg_upgrade cache lookup code; remove useless NULL pointer tests.
2010-10-20 20:02:37 +00:00
691a67b922
Rename pg_upgrade 'log' to 'log_opts', to avoid platform naming conflict.
2010-10-20 02:31:17 +00:00
3325c9bddb
Further speed up pg_upgrade lookups.
2010-10-20 02:06:06 +00:00
1c72614be7
Fix for new pg_upgrade cache code.
2010-10-20 01:24:31 +00:00
333b4a45f1
Cache most recent relfilenode lookups, for speed, after report of
...
pg_upgrade slowness for 150k tables.
2010-10-20 00:55:16 +00:00
ad06db2610
In pg_upgrade, use cached copy of directory listing, rather than calling
...
scandir() with a pattern for every table.
Optimization after report of pg_upgrade slowness with 150k tables.
2010-10-20 00:33:19 +00:00
07456b45e6
Pgindent run on pg_upgrade source after restructuring.
2010-10-19 22:37:04 +00:00
e13f7e9a71
Restructure the pg_upgrade code to use several global structures rather
...
than packing everything into 'ctx' and passing that to every function.
2010-10-19 21:38:34 +00:00
722d5beeb2
In pg_upgrade, rename SHELL_EXT to SCRIPT_EXT, for clarity.
2010-10-19 15:57:55 +00:00
51eeccd6cc
Add removal of PG_VERSION to optional old cluster deletion script.
...
Backpatch to 9.0.X.
2010-10-19 15:52:43 +00:00
9df96f9bb1
In pg_upgrade, rename macro EXEC_EXT to SHELL_EXT for clarity.
...
Backpatch to 9.0.X.
2010-10-19 02:56:16 +00:00
fe61db6f0c
Have pg_upgrade use strtoul(), not strtol().
2010-09-29 02:40:25 +00:00
807005c024
Use macro atooid() for conversion of strings to oids, per suggestion
...
from Tom.
2010-09-28 22:11:39 +00:00
9340fb80b1
In pg_upgrade, properly handle oids > 2^31 by using strtoul() internally
...
rather than atol().
Per report from Brian Hirt
2010-09-28 21:41:03 +00:00
a1bb570de9
Fix leak patch that was using fclose() instead of close().
2010-09-28 21:27:32 +00:00
f175884520
Properly close files after read file failure to prevent potential
...
resource leak. Of course, any such failure aborts pg_upgrade, but might
as well be clean about it.
Per patch from Grzegorz Ja?kiewicz.
2010-09-28 19:28:34 +00:00
fe9b36fd59
Convert cvsignore to gitignore, and add .gitignore for build targets.
2010-09-22 12:57:04 +02:00
9f2e211386
Remove cvs keywords from all files.
2010-09-20 22:08:53 +02:00
c5d94a34fb
Modify pg_upgrade to set/restore all environment variables related to
...
collation/encoding to match English when reading controldata. This now
matches the English variable setting used by pg_regress.c.
Backpatch to 9.0.X.
2010-09-07 14:10:30 +00:00
3f11971916
Remove extra newlines at end and beginning of files, add missing newlines
...
at end of files.
2010-08-19 05:57:36 +00:00
8af787ea24
Adjust check_for_isn_and_int8_passing_mismatch() so it is called for all
...
migrations.
Backpatch to 9.0.
2010-07-25 03:47:29 +00:00
f31b1fd7c1
Prevent pg_upgrade from migrating databases that use reg* data types
...
where the oid is not preserved by pg_upgrade (everything but pg_type).
Update documentation.
Per bug report from depstein@alliedtesting.com .
2010-07-25 03:28:32 +00:00
4504a1bc01
On Win32, pg_upgrade cannot sent any server log output to the log file
...
because of file access limitations on that platform.
2010-07-13 20:03:32 +00:00
477c01b00d
Remove incorrect email address for pg_upgrade bug reports.
2010-07-13 18:14:14 +00:00
f87bd25f00
In pg_upgrade, report /bin directory checks independent of /data checks.
2010-07-13 18:09:55 +00:00
804f96accb
In pg_upgrade, prevent psql AUTOCOMMIT=off by not loading .psqlrc.
2010-07-13 15:56:53 +00:00
a0d7c5f689
Properly report errno/out-of-disk-space error from pg_upgrade when in
...
copy mode, per report from depstein@alliedtesting.com .
Patch suggestion from Magnus.
Backpatch to 9.0.X.
2010-07-09 16:51:23 +00:00
239d769e7e
pgindent run for 9.0, second run
2010-07-06 19:19:02 +00:00
da254e3d16
Make pg_upgrade copyrights just 2010, not 2010-2010.
2010-07-03 16:33:15 +00:00
de255a6eb1
Add copyrights to pg_upgrade and pg_upgrade_tools files, per Tom.
2010-07-03 16:25:01 +00:00
ccbe0c14e6
Add CVS tags to pg_upgrade and pg_upgrade_support files, per request
...
from Tom.
2010-07-03 14:23:14 +00:00
600fc1dc9d
Get rid of some more stuff that duplicates c.h or port.h.
2010-07-01 15:52:52 +00:00
14bd1c3d9e
Remove port.h prototypes from pg_upgrade.h, per report from Robert Haas.
2010-07-01 14:37:53 +00:00
c1b617987d
Add username designations to all pg_upgrade utility calls that support it.
2010-06-23 20:04:50 +00:00
601d1eeddc
Fix pg_upgrade's use of pg_ctl on Win32 to not send command and sever
...
output to the same file, because it is impossible.
Also set user name for pg_dumpall in pg_upgrade.
2010-06-22 16:45:10 +00:00
1aa117506d
Fix pg_upgrade to remove malloc(0) call.
2010-06-16 19:43:11 +00:00
24cb6ab9af
Fix storage of getopt() return, should be 'int', for pg_upgrade.
...
Steve Singer
2010-06-15 23:25:01 +00:00
8141523e35
Properly define pg_upgrade global variable, per bug report from Chris
...
Ruprecht on Mac (64 bit).
2010-06-15 02:08:01 +00:00
785c2acc12
Update pg_upgrade C comment about cwd.
2010-06-12 17:45:28 +00:00
1dc7c796c9
Have pg_upgrade create its output files in the current directory, rather
...
than in a subdirectory of the $HOME directory, or $TMP in Windows.
2010-06-12 17:05:29 +00:00
9b6dba1193
Remove IMPLEMENTATION.jp file from pg_upgrade docs; still in pgFoundry
...
for pg_migrator, per suggestion from Magnus.
2010-05-25 16:53:24 +00:00
02265f06b7
Update pg_upgrade IMPLEMENTATION doc file to match current 9.0 behavior.
2010-05-25 16:09:29 +00:00
238d21d7d2
Modify pg_standby, pgbench, and pg_upgrade manual pages to be consistent
...
in their display of command-line options with other client applications.
2010-05-25 15:55:28 +00:00
f4e9436026
Add Japanese Implementation file to CVS.
2010-05-25 02:56:36 +00:00
7a74d70e71
Re-order pg_upgrade 'help' options to be alphabetical.
2010-05-25 02:55:58 +00:00
6368682788
In pg_upgrade, test for datallowconn instead of hardcoding template0.
2010-05-24 19:52:33 +00:00
00be75415c
Split apart pg_upgrade user lookup and root check so '--help' shows
...
proper default username.
2010-05-24 16:34:35 +00:00
add8044778
issue_warnings() has no business freeing its parameter, especially not when
...
its sole caller does that too. Jan Matousek, via Pavel Stehule
2010-05-23 16:54:13 +00:00
3245bd5240
Simplify pg_upgrade queries by using IN instead of multiple OR clauses
...
comparing the same column to multiple values.
2010-05-19 18:56:47 +00:00
573e446f6f
For pg_upgrade, update template0's datfrozenxid and its relfrozenxids to
...
match the behavior of autovacuum, which does this as the xid advances
even if autovacuum is turned off.
2010-05-19 18:27:43 +00:00
64719a18db
Use a 'datallowconn' check for avoiding 'template0', rather than
...
hardcoding a 'template0' check, per suggestion from Alvaro.
This might fix a problem where someone has allowed 'template0'
connections, but it is a cleaner approach even if doesn't fix the
bug.
2010-05-18 18:40:51 +00:00
37953b2d20
Add pg_upgrade TESTING files explaining a testing method.
2010-05-18 03:26:12 +00:00
5c337fb45c
Adjust pg_upgrade BSD defines for scandir(), per report from Giles Lean
2010-05-15 10:21:54 +00:00
5781d96dc3
Change bsdi define to __bsdi__
2010-05-15 10:08:28 +00:00
88fba7089e
Fix another obvious bug pointed out by a compiler warning.
2010-05-14 00:43:42 +00:00
0546906064
Remove another unsafe use of random data as a format string.
2010-05-14 00:39:51 +00:00
8eac39780d
Get rid of unsafe sprintf and snprintf usages. Per compiler warnings.
2010-05-14 00:32:21 +00:00
Alvaro Herrera
Bruce Momjian
Tom Lane
Peter Eisentraut
Robert Haas
Magnus Hagander