c1b617987d
Add username designations to all pg_upgrade utility calls that support it.
2010-06-23 20:04:50 +00:00
601d1eeddc
Fix pg_upgrade's use of pg_ctl on Win32 to not send command and sever
...
output to the same file, because it is impossible.
Also set user name for pg_dumpall in pg_upgrade.
2010-06-22 16:45:10 +00:00
8327060dc2
Updated expected-output file for hstore.
...
This is an oversight in my previous patch to deprecate => as an operator
name. Per buildfarm.
2010-06-22 12:54:22 +00:00
31c47e53aa
Rename hstore => text[] operator to %
...
This is not yet in any released version, so we still have the option to
change the name. We may want to reserve the token => in a future release.
2010-06-18 03:52:03 +00:00
449c73f466
Clean up pg_archivecleanup's error and logging output: put newlines in
...
sane places, make messages follow project's message style guidelines.
Also, avoid closedir(NULL).
Fujii Masao and Tom Lane
2010-06-17 17:31:27 +00:00
1aa117506d
Fix pg_upgrade to remove malloc(0) call.
2010-06-16 19:43:11 +00:00
24cb6ab9af
Fix storage of getopt() return, should be 'int', for pg_upgrade.
...
Steve Singer
2010-06-15 23:25:01 +00:00
c0989c67fa
Change the interpretation of the primary_key_attnums parameter of
...
dblink_build_sql_insert() and related functions. Now the column numbers
are treated as logical not physical column numbers. This will provide saner
behavior in the presence of dropped columns; furthermore, if we ever get
around to allowing rearrangement of logical column ordering, the original
definition would become nearly untenable from a usability standpoint.
Per recent discussion of dblink's handling of dropped columns.
Not back-patched for fear of breaking existing applications.
2010-06-15 20:29:01 +00:00
b17129b589
Remove hstore's text[] => text[] operator.
...
This is not yet in any released version, so we still have the option to
backtrack. Instead, document hstore(text[], text[]). Per discussion.
2010-06-15 19:48:30 +00:00
3b3706d2cf
Fix dblink_build_sql_insert() and related functions to handle dropped
...
columns correctly. In passing, get rid of some dead logic in the
underlying get_sql_insert() etc functions --- there is no caller that
will pass null value-arrays to them.
Per bug report from Robert Voinea.
2010-06-15 19:04:15 +00:00
48a7245391
Consolidate and improve checking of key-column-attnum arguments for
...
dblink_build_sql_insert() and related functions. In particular, be sure to
reject references to dropped and out-of-range column numbers. The numbers
are still interpreted as physical column numbers, though, for backward
compatibility.
This patch replaces Joe's patch of 2010-02-03, which handled only some aspects
of the problem.
2010-06-15 16:22:19 +00:00
8141523e35
Properly define pg_upgrade global variable, per bug report from Chris
...
Ruprecht on Mac (64 bit).
2010-06-15 02:08:01 +00:00
6bbaa3148d
Rearrange dblink's dblink_build_sql_insert() and related routines to open and
...
lock the target relation just once per SQL function call. The original coding
obtained and released lock several times per call. Aside from saving a
not-insignificant number of cycles, this eliminates possible race conditions
if someone tries to modify the relation's schema concurrently. Also
centralize locking and permission-checking logic.
Problem noted while investigating a trouble report from Robert Voinea --- his
problem is still to be fixed, though.
2010-06-14 20:49:33 +00:00
ca65f2190a
Files for pg_archivecleanup
2010-06-14 16:19:24 +00:00
25fee5cfbd
New contrib module for use as an archive_cleanup_command, or as a
...
standalone utility for removing files from archive.
2010-06-14 16:17:56 +00:00
785c2acc12
Update pg_upgrade C comment about cwd.
2010-06-12 17:45:28 +00:00
1dc7c796c9
Have pg_upgrade create its output files in the current directory, rather
...
than in a subdirectory of the $HOME directory, or $TMP in Windows.
2010-06-12 17:05:29 +00:00
5a41c317c5
Avoid "identifier will be truncated" warning in dblink
...
when connection string is longer than NAMEDATALEN.
The previous fix for long connection name broke the behavior.
2010-06-09 03:39:26 +00:00
a624356072
Fix connection leak in dblink when dblink_connect() or dblink_connect_u()
...
end with "duplicate connection name" errors.
Backported to release 7.4.
2010-06-09 00:56:02 +00:00
3e7451a6df
Add missed function dblink_connect_u(text[,text]) to uninstall script
2010-06-07 15:14:36 +00:00
7dff7260af
Fix dblink to treat connection names longer than NAMEDATALEN-2 (62 bytes).
...
Now long names are adjusted with truncate_identifier() and NOTICE messages
are raised if names are actually truncated.
Backported to release 8.0.
2010-06-03 09:38:33 +00:00
9b6dba1193
Remove IMPLEMENTATION.jp file from pg_upgrade docs; still in pgFoundry
...
for pg_migrator, per suggestion from Magnus.
2010-05-25 16:53:24 +00:00
02265f06b7
Update pg_upgrade IMPLEMENTATION doc file to match current 9.0 behavior.
2010-05-25 16:09:29 +00:00
238d21d7d2
Modify pg_standby, pgbench, and pg_upgrade manual pages to be consistent
...
in their display of command-line options with other client applications.
2010-05-25 15:55:28 +00:00
f4e9436026
Add Japanese Implementation file to CVS.
2010-05-25 02:56:36 +00:00
7a74d70e71
Re-order pg_upgrade 'help' options to be alphabetical.
2010-05-25 02:55:58 +00:00
6368682788
In pg_upgrade, test for datallowconn instead of hardcoding template0.
2010-05-24 19:52:33 +00:00
00be75415c
Split apart pg_upgrade user lookup and root check so '--help' shows
...
proper default username.
2010-05-24 16:34:35 +00:00
add8044778
issue_warnings() has no business freeing its parameter, especially not when
...
its sole caller does that too. Jan Matousek, via Pavel Stehule
2010-05-23 16:54:13 +00:00
3245bd5240
Simplify pg_upgrade queries by using IN instead of multiple OR clauses
...
comparing the same column to multiple values.
2010-05-19 18:56:47 +00:00
573e446f6f
For pg_upgrade, update template0's datfrozenxid and its relfrozenxids to
...
match the behavior of autovacuum, which does this as the xid advances
even if autovacuum is turned off.
2010-05-19 18:27:43 +00:00
64719a18db
Use a 'datallowconn' check for avoiding 'template0', rather than
...
hardcoding a 'template0' check, per suggestion from Alvaro.
This might fix a problem where someone has allowed 'template0'
connections, but it is a cleaner approach even if doesn't fix the
bug.
2010-05-18 18:40:51 +00:00
37953b2d20
Add pg_upgrade TESTING files explaining a testing method.
2010-05-18 03:26:12 +00:00
5c337fb45c
Adjust pg_upgrade BSD defines for scandir(), per report from Giles Lean
2010-05-15 10:21:54 +00:00
5781d96dc3
Change bsdi define to __bsdi__
2010-05-15 10:08:28 +00:00
de4e18a34d
Fix typos in comments, spotted by Josh Kupershmidt.
2010-05-15 09:31:57 +00:00
88fba7089e
Fix another obvious bug pointed out by a compiler warning.
2010-05-14 00:43:42 +00:00
0546906064
Remove another unsafe use of random data as a format string.
2010-05-14 00:39:51 +00:00
8eac39780d
Get rid of unsafe sprintf and snprintf usages. Per compiler warnings.
2010-05-14 00:32:21 +00:00
adf6b8edfb
Spell __darwin__ correctly, to suppress compiler warning on OSX.
2010-05-14 00:19:46 +00:00
e9ad14f9f4
Use NAMEDATALEN instead of local define.
...
Modify path separators for Win32.
Per ideas from Takahiro Itagaki
2010-05-14 00:13:38 +00:00
36d3afd2d4
Remove all mentions of EnterpriseDB Advanced Server from pg_upgrade;
...
EDB must maintain their own patch set for this.
2010-05-13 22:51:00 +00:00
382ff21203
Fix up lame idea of not using autoconf to determine if platform has scandir().
...
Should fix buildfarm failures.
2010-05-13 22:07:43 +00:00
2b61b3e507
Assorted fixes to make pg_upgrade build on MSVC.
...
* There is no chmod() on Windows.
* Must always use the 3-parameter version of open()
* There is no dynloader.h - but it also appears unnecessary on all platforms
* Don't include shlobj.h because it causes compile errors, and from what I can
see it's not actually used. This may need to be added back for mingw
and/or cygwin in the worst case.
2010-05-13 15:58:15 +00:00
c2e7f78abe
Fix wrong subdir. Per buildfarm.
2010-05-13 05:17:16 +00:00
9885206cab
Move pg_upgrade shared library out into its own /contrib directory
...
(pg_upgrade_support).
2010-05-13 01:03:01 +00:00
44e55690fd
Hook pg_upgrade into the contrib makefile structure so it gets built
...
on the buildfarm.
2010-05-12 16:50:58 +00:00
c9c25a982c
Clean up unnecessary unportability and compiler warnings by removing the
...
cmp parameter for pg_scandir(). The code failed to support this anyway
for Sun/Windows, so pretending we could accept a parameter other than
NULL was just asking for trouble.
2010-05-12 16:50:00 +00:00
b460b5cd11
Move pg_upgrade TODO to TODO wiki.
2010-05-12 13:59:21 +00:00
395d1259ad
Add PGFILEDESC description to Makefiles for all /contrib executables.
...
Add PGAPPICON to all executable makefiles.
2010-05-12 11:33:10 +00:00
Bruce Momjian
Robert Haas
Tom Lane
Simon Riggs
Itagaki Takahiro
Teodor Sigaev
Heikki Linnakangas
Magnus Hagander