67c9e4442f
Furter pg_upgrade optimizations to reduce function call argument count.
2011-01-01 12:28:48 -05:00
6e6bee987f
In pg_upgrade, remove use of whichCluster, and just pass old/new cluster
...
pointers, which simplifies the code. This was not possible in 9.0 because
everything was in a single nested struct, but is possible now.
Per suggestion from Tom.
2011-01-01 12:06:36 -05:00
f82b3e58f8
In pg_upgrade, rename "CLUSTERNAME" to "CLUSTER_NAME".
2010-12-31 20:42:29 -05:00
88c803457a
Improve pg_upgrade's checks for required executables.
...
Don't insist on pg_dumpall and psql being present in the old cluster,
since they are not needed. Do insist on pg_resetxlog being present
(in both old and new), since we need it. Also check for pg_config,
but only in the new cluster. Remove the useless attempt to call
pg_config in the old cluster; we don't need to know the old value of
--pkglibdir. (In the case of a stripped-down migration installation
there might be nothing there to look at anyway, so any future change
that might reintroduce that need would have to be considered carefully.)
Per my attempts to build a minimal previous-version installation to support
pg_upgrade.
2010-12-29 13:43:53 -05:00
16b5e08dec
Use "upgrade" in preference over "migrate" in pg_upgrade messages and
...
documentation. (Many were left over from the old pg_migrator naming.)
2010-12-15 07:11:31 -05:00
3864afa1d1
Clean up some copied-and-pasted code in pg_upgrade.
...
1. Don't reimplement S_ISDIR() and S_ISREG() badly.
2. Don't reimplement access() badly.
This code appears to have been copied from ancient versions of the
corresponding backend routines, and not patched to incorporate subsequent
fixes (see my commits of 2008-03-31 and 2010-01-14 respectively).
It might be a good idea to change it to just *call* those routines,
but for now I'll just transpose these fixes over.
2010-12-11 14:17:46 -05:00
fc946c39ae
Remove useless whitespace at end of lines
2010-11-23 22:34:55 +02:00
5aa446c961
Cleanup various comparisons with the constant "true".
...
Itagaki Takahiro, with slight modifications.
2010-11-14 21:03:48 -05:00
11e482c350
Move copydir() prototype into its own header file.
...
Having this in src/include/port.h makes no sense, now that copydir.c lives
in src/backend/strorage rather than src/port. Along the way, remove an
obsolete comment from contrib/pg_upgrade that makes reference to the old
location.
2010-11-12 16:39:53 -05:00
71baff1786
Fix buffer overrun in pg_upgrade.
...
Problem reported, and cause identified, by Hernan Gonzalez.
2010-11-02 17:31:41 -04:00
84c123be1d
Allow new values to be added to an existing enum type.
...
After much expenditure of effort, we've got this to the point where the
performance penalty is pretty minimal in typical cases.
Andrew Dunstan, reviewed by Brendan Jurd, Dean Rasheed, and Tom Lane
2010-10-24 23:05:41 -04:00
a52aa6c6db
Clean up pg_upgrade cache lookup code; remove useless NULL pointer tests.
2010-10-20 20:02:37 +00:00
691a67b922
Rename pg_upgrade 'log' to 'log_opts', to avoid platform naming conflict.
2010-10-20 02:31:17 +00:00
3325c9bddb
Further speed up pg_upgrade lookups.
2010-10-20 02:06:06 +00:00
1c72614be7
Fix for new pg_upgrade cache code.
2010-10-20 01:24:31 +00:00
333b4a45f1
Cache most recent relfilenode lookups, for speed, after report of
...
pg_upgrade slowness for 150k tables.
2010-10-20 00:55:16 +00:00
ad06db2610
In pg_upgrade, use cached copy of directory listing, rather than calling
...
scandir() with a pattern for every table.
Optimization after report of pg_upgrade slowness with 150k tables.
2010-10-20 00:33:19 +00:00
07456b45e6
Pgindent run on pg_upgrade source after restructuring.
2010-10-19 22:37:04 +00:00
e13f7e9a71
Restructure the pg_upgrade code to use several global structures rather
...
than packing everything into 'ctx' and passing that to every function.
2010-10-19 21:38:34 +00:00
722d5beeb2
In pg_upgrade, rename SHELL_EXT to SCRIPT_EXT, for clarity.
2010-10-19 15:57:55 +00:00
51eeccd6cc
Add removal of PG_VERSION to optional old cluster deletion script.
...
Backpatch to 9.0.X.
2010-10-19 15:52:43 +00:00
9df96f9bb1
In pg_upgrade, rename macro EXEC_EXT to SHELL_EXT for clarity.
...
Backpatch to 9.0.X.
2010-10-19 02:56:16 +00:00
fe61db6f0c
Have pg_upgrade use strtoul(), not strtol().
2010-09-29 02:40:25 +00:00
807005c024
Use macro atooid() for conversion of strings to oids, per suggestion
...
from Tom.
2010-09-28 22:11:39 +00:00
9340fb80b1
In pg_upgrade, properly handle oids > 2^31 by using strtoul() internally
...
rather than atol().
Per report from Brian Hirt
2010-09-28 21:41:03 +00:00
a1bb570de9
Fix leak patch that was using fclose() instead of close().
2010-09-28 21:27:32 +00:00
f175884520
Properly close files after read file failure to prevent potential
...
resource leak. Of course, any such failure aborts pg_upgrade, but might
as well be clean about it.
Per patch from Grzegorz Ja?kiewicz.
2010-09-28 19:28:34 +00:00
fe9b36fd59
Convert cvsignore to gitignore, and add .gitignore for build targets.
2010-09-22 12:57:04 +02:00
9f2e211386
Remove cvs keywords from all files.
2010-09-20 22:08:53 +02:00
c5d94a34fb
Modify pg_upgrade to set/restore all environment variables related to
...
collation/encoding to match English when reading controldata. This now
matches the English variable setting used by pg_regress.c.
Backpatch to 9.0.X.
2010-09-07 14:10:30 +00:00
3f11971916
Remove extra newlines at end and beginning of files, add missing newlines
...
at end of files.
2010-08-19 05:57:36 +00:00
8af787ea24
Adjust check_for_isn_and_int8_passing_mismatch() so it is called for all
...
migrations.
Backpatch to 9.0.
2010-07-25 03:47:29 +00:00
f31b1fd7c1
Prevent pg_upgrade from migrating databases that use reg* data types
...
where the oid is not preserved by pg_upgrade (everything but pg_type).
Update documentation.
Per bug report from depstein@alliedtesting.com .
2010-07-25 03:28:32 +00:00
4504a1bc01
On Win32, pg_upgrade cannot sent any server log output to the log file
...
because of file access limitations on that platform.
2010-07-13 20:03:32 +00:00
477c01b00d
Remove incorrect email address for pg_upgrade bug reports.
2010-07-13 18:14:14 +00:00
f87bd25f00
In pg_upgrade, report /bin directory checks independent of /data checks.
2010-07-13 18:09:55 +00:00
804f96accb
In pg_upgrade, prevent psql AUTOCOMMIT=off by not loading .psqlrc.
2010-07-13 15:56:53 +00:00
a0d7c5f689
Properly report errno/out-of-disk-space error from pg_upgrade when in
...
copy mode, per report from depstein@alliedtesting.com .
Patch suggestion from Magnus.
Backpatch to 9.0.X.
2010-07-09 16:51:23 +00:00
239d769e7e
pgindent run for 9.0, second run
2010-07-06 19:19:02 +00:00
da254e3d16
Make pg_upgrade copyrights just 2010, not 2010-2010.
2010-07-03 16:33:15 +00:00
de255a6eb1
Add copyrights to pg_upgrade and pg_upgrade_tools files, per Tom.
2010-07-03 16:25:01 +00:00
ccbe0c14e6
Add CVS tags to pg_upgrade and pg_upgrade_support files, per request
...
from Tom.
2010-07-03 14:23:14 +00:00
600fc1dc9d
Get rid of some more stuff that duplicates c.h or port.h.
2010-07-01 15:52:52 +00:00
14bd1c3d9e
Remove port.h prototypes from pg_upgrade.h, per report from Robert Haas.
2010-07-01 14:37:53 +00:00
c1b617987d
Add username designations to all pg_upgrade utility calls that support it.
2010-06-23 20:04:50 +00:00
601d1eeddc
Fix pg_upgrade's use of pg_ctl on Win32 to not send command and sever
...
output to the same file, because it is impossible.
Also set user name for pg_dumpall in pg_upgrade.
2010-06-22 16:45:10 +00:00
1aa117506d
Fix pg_upgrade to remove malloc(0) call.
2010-06-16 19:43:11 +00:00
24cb6ab9af
Fix storage of getopt() return, should be 'int', for pg_upgrade.
...
Steve Singer
2010-06-15 23:25:01 +00:00
8141523e35
Properly define pg_upgrade global variable, per bug report from Chris
...
Ruprecht on Mac (64 bit).
2010-06-15 02:08:01 +00:00
785c2acc12
Update pg_upgrade C comment about cwd.
2010-06-12 17:45:28 +00:00
Bruce Momjian
Tom Lane
Peter Eisentraut
Robert Haas
Magnus Hagander