Commit Graph

2135 Commits

Author SHA1 Message Date
Vadim B. Mikheev
d65584d297 Get rid of #include "../backend/parser/parse.h 1997-08-31 11:41:20 +00:00
Vadim B. Mikheev
4e9a3f4ef0 Workplace for CREATE/DROP TRIGGER 1997-08-31 11:40:13 +00:00
Vadim B. Mikheev
f2cc46dd54 Indexing of pg_trigger 1997-08-31 09:56:18 +00:00
Vadim B. Mikheev
2d7b93c0ca Welcome, triggers 1997-08-31 09:55:24 +00:00
Marc G. Fournier
6a061da272 Update patch from Peter <patches@maidast.demon.co.uk> 1997-08-31 08:15:13 +00:00
Vadim B. Mikheev
0b6dc93b32 Add spi.o 1997-08-30 10:28:47 +00:00
Bruce Momjian
65191fabfd indent flag change. 1997-08-29 21:41:33 +00:00
Bruce Momjian
0aea0f2063 Cleanup. 1997-08-29 21:20:09 +00:00
Bruce Momjian
fddc57bfcd Add PGINDENT and support program. 1997-08-29 21:13:00 +00:00
Vadim B. Mikheev
448332a769 TupleUpdatedByCurXactAndCmd () changed due to
Fix very old bug which made tuples changed/inserted by a commnd
visible to command itself (so we had multiple update of updated tuples,
etc).
1997-08-29 09:12:20 +00:00
Vadim B. Mikheev
d8933d5cff New results destination for SPI manager. 1997-08-29 09:06:27 +00:00
Vadim B. Mikheev
0d0254d1fb SPI manager. 1997-08-29 09:05:57 +00:00
Vadim B. Mikheev
3152996ffb Fix very old bug which made tuples changed/inserted by a commnd
visible to command itself (so we had multiple update of updated tuples,
etc).
1997-08-29 09:05:25 +00:00
Bruce Momjian
e06099c607 heap_getattr fix for aix. 1997-08-29 00:44:55 +00:00
Vadim B. Mikheev
8fd0898814 Fix time_cmp 1997-08-28 05:06:29 +00:00
Vadim B. Mikheev
ed118276e3 Clean CommandInfo after posting to client. 1997-08-28 05:05:43 +00:00
Vadim B. Mikheev
becd2f9b82 Fix for "default = '...'" in CREATE TYPE 1997-08-28 05:02:01 +00:00
Vadim B. Mikheev
174bc0c1e7 Tests for CHECK/DEFAULT 1997-08-28 04:49:34 +00:00
Vadim B. Mikheev
3751b49545 Number of tuples inserted/affected by INSERT/UPDATE/DELETE... 1997-08-27 09:05:24 +00:00
Vadim B. Mikheev
40ac5a692b heap_delete returns int now (for non-functional deletes). 1997-08-27 09:03:47 +00:00
Marc G. Fournier
ceac1d5a4e Only need to check for strerror once :) 1997-08-27 05:06:20 +00:00
Bruce Momjian
ed7a17dca0 Remove unneeded stat calls. 1997-08-27 03:48:50 +00:00
Bruce Momjian
75c6c2b608 Inlined heap_getattr(). 1997-08-26 23:31:58 +00:00
Bruce Momjian
20afa04d03 Fix for pointer arithmetic. 1997-08-26 19:24:36 +00:00
Bruce Momjian
6451b04a08 rename sections. 1997-08-26 17:39:32 +00:00
Bruce Momjian
ed626314e6 unix.1 renamed to pgintro.1. 1997-08-26 17:30:09 +00:00
Bruce Momjian
99e9deac73 Manual page renaming. 1997-08-26 17:00:23 +00:00
Bruce Momjian
5927d47b4f Change void * to Dllist*. 1997-08-26 14:05:47 +00:00
Bruce Momjian
0bdd6d1e00 pg_passwd cleanup. 1997-08-25 23:28:04 +00:00
Bruce Momjian
86062218da pg_passwd cleanup. 1997-08-25 23:11:21 +00:00
Bruce Momjian
c6e7baa7e1 pg_passwd cleanup 1997-08-25 20:00:03 +00:00
Bruce Momjian
f8fda03d12 pg_password utility. Cleanup for psql passwords. New datetime contrib stuff for new version. Fix for strutils needing config.h. 1997-08-25 19:41:52 +00:00
Bruce Momjian
8d0e658d06 Small cleanup. 1997-08-25 04:15:40 +00:00
Bruce Momjian
c4cb617504 Major patch to speed up backend startup after profiling analysis. 1997-08-24 23:08:01 +00:00
Bruce Momjian
281ba3f40d Update .similar version file. 1997-08-22 18:48:25 +00:00
Bruce Momjian
e045278e7e Fix for no NULL in CREATE TABLE. 1997-08-22 17:15:41 +00:00
Bruce Momjian
50881e336b Remove compile warning. 1997-08-22 16:48:14 +00:00
Bruce Momjian
0a50d30bd7 Warning in makefile added from DArcy. 1997-08-22 16:38:33 +00:00
Vadim B. Mikheev
c16d29f990 + ExecConstraints () 1997-08-22 14:39:33 +00:00
Vadim B. Mikheev
c0784f6d96 Restore CONSTRAINT keyword (was lost ... by unknown way) 1997-08-22 14:33:21 +00:00
Vadim B. Mikheev
d40885cc40 + ExecConstraints() 1997-08-22 14:28:20 +00:00
Vadim B. Mikheev
faebf2f8a2 Turn constraints off for sequences & views
elog(WARN,"ADD ATTRIBUTE: DEFAULT is not implemented, yet");
Call ExecConstraints in CopyFrom
1997-08-22 14:22:14 +00:00
Vadim B. Mikheev
530876fea5 Remove DEFAULT/CHECK infos from catalog on DROP TABLE
Store CHECK infos on CREATE TABLE
1997-08-22 14:10:26 +00:00
Bruce Momjian
021778eed3 We store Cash/money as int of size 4, so make it an int rather than a long. 1997-08-22 07:13:01 +00:00
Bruce Momjian
7515bb484e Fix for psql pager when no tty, cleanup for vacuum attdisbursion type. 1997-08-22 04:13:18 +00:00
Vadim B. Mikheev
5f7f236ba4 ConstraintDef changed 1997-08-22 04:05:27 +00:00
Vadim B. Mikheev
d67547d82d Set attbyval for attdisbursion to FALSE
Set atttype for relchecks to 21 (int2)
Set relkind for pg_attrdef & pg_relcheck to 'n'
1997-08-22 04:04:19 +00:00
Vadim B. Mikheev
ee5f09f07c + CreateTupleDescCopyConstr
+ FreeTupleDesc
1997-08-22 03:55:39 +00:00
Vadim B. Mikheev
ac0029aa0b Fetch information about DEFAULT/CHECK while openning a relation. 1997-08-22 03:35:44 +00:00
Vadim B. Mikheev
9b6d8878fd There is no NULL constraint in CREATE TABLE - only NOT NULL one. 1997-08-22 03:17:55 +00:00
Vadim B. Mikheev
ed2c54b240 DEFAULT handling
Use  for 'selct .. into ..' copy of TupleDesc (without constraints)
#ifdef NOT_USED for resetVarAttrLenForCreateTable (just free tupdesc copy)
1997-08-22 03:12:19 +00:00
Vadim B. Mikheev
b5b3e03e34 DefineRelation: DEFAULT/CHECK handling 1997-08-22 03:03:56 +00:00
Vadim B. Mikheev
9e9584cc99 Store attr DEFAULT info in heap_create 1997-08-22 02:58:51 +00:00
Vadim B. Mikheev
55f7d4ea7d CreateTupleDescCopy don't copy constraints now!
+ CreateTupleDescCopyConstr to copy them too.
+ FreeTupleDesc
1997-08-22 02:55:39 +00:00
Bruce Momjian
76501c8aed Make psql use pager only when it has a tty. 1997-08-22 00:17:26 +00:00
Bruce Momjian
3dd23aadf0 Allow functions and operators on internally-identical types to succeed. 1997-08-22 00:02:19 +00:00
Bruce Momjian
0ab2921290 Change time function names to be more consistent, and check for zero divides, from Michael Reifenberg. 1997-08-21 23:57:00 +00:00
Bruce Momjian
23cce4ad4f Name change cleanup. 1997-08-21 14:33:05 +00:00
Bruce Momjian
671c4ea6f5 Remove unused spin function when no spinlocks. 1997-08-21 13:43:46 +00:00
Vadim B. Mikheev
d37e93aafd #definitions for pg_attrdef & pg_relcheck names 1997-08-21 04:33:20 +00:00
Vadim B. Mikheev
cc332d612b AttrConstr --> TupleConstr 1997-08-21 04:10:25 +00:00
Bruce Momjian
e482462960 Rename pg_attribute.attnvals to attdisbursion. 1997-08-21 03:02:13 +00:00
Bruce Momjian
f1edf02cc1 Change pg_attribute.attnvals to float4, change #ifdef 0 to #if 0, fix aix call to strNcpy, fix pg_super_user_id in pg_dumpall, change pg_database.dtadba from oid to int4. 1997-08-21 02:28:55 +00:00
Vadim B. Mikheev
ac3d7b3146 + extern double *box_area(BOX *box); 1997-08-21 01:40:30 +00:00
Vadim B. Mikheev
f2dd89b6fa + struct ConstaintDef - for constraints. 1997-08-21 01:39:25 +00:00
Vadim B. Mikheev
25aa0f8d04 New system relations to store DEFAULT/CHECK expressions. 1997-08-21 01:37:55 +00:00
Vadim B. Mikheev
197ced5923 Read info for DEFAULT from pg_attrdef. 1997-08-21 01:36:09 +00:00
Vadim B. Mikheev
e3accffe66 Syntax for [CONSTRAINT name] CHECK ... 1997-08-21 01:34:44 +00:00
Vadim B. Mikheev
e4247023f1 Get rid of attproc, atttyparg, attcanindex, attdefrel, attbound
from pg_attribute. atthasdef added.
1997-08-21 01:32:19 +00:00
Bruce Momjian
63fbdd358f Portability fix for pg_dumpall. 1997-08-20 15:06:48 +00:00
Bruce Momjian
11ac1bf268 More NOT_USEDs 1997-08-20 14:54:35 +00:00
Bruce Momjian
36c9c968c0 Add static finding script. 1997-08-20 02:10:47 +00:00
Vadim B. Mikheev
4a132abf6c HTNegate/HTCommute/HTNegateCommute are not used. 1997-08-20 02:01:42 +00:00
Vadim B. Mikheev
0c001f080b CHECK/DEFAULT syntax (some tricks to get current scan position). 1997-08-20 01:50:06 +00:00
Vadim B. Mikheev
4527172b80 CHECK/DEFAULT syntax 1997-08-20 01:12:38 +00:00
Marc G. Fournier
bb951c6cb4 Changes for Digital Unix 1997-08-20 00:50:11 +00:00
Bruce Momjian
4e9e00cb68 Fix for sunos4 difftime() call. 1997-08-19 21:47:07 +00:00
Bruce Momjian
1d8bbfd2e7 Make functions static where possible, enclose unused functions in #ifdef NOT_USED. 1997-08-19 21:40:56 +00:00
Vadim B. Mikheev
b992e200b8 NOT NULL implementation (submitted by Robson Paniago de Miranda). 1997-08-19 04:46:15 +00:00
Bruce Momjian
b99c63cfc0 Now that names are null terminated, no need to do all that NAMEDATALEN stuff. 1997-08-18 20:53:48 +00:00
Bruce Momjian
022903f22e Reduce open() calls. Replace fopen() calls with calls to fd.c functions. 1997-08-18 02:15:04 +00:00
Marc G. Fournier
eaae21fb4d Fixes for alphalinux port by abrams@philos.umass.edu 1997-08-17 02:40:00 +00:00
Marc G. Fournier
9d90de5de7 Changes so that it actually checks for <readline/history.h>, instead
of assuming it does exist
1997-08-17 00:48:51 +00:00
Marc G. Fournier
5410203949 Make sure that LIBPQDIR points to the right directory 1997-08-17 00:39:02 +00:00
Marc G. Fournier
9093238c7e Fix up paths to $(SRCDIR) 1997-08-17 00:33:28 +00:00
Marc G. Fournier
f63f5680e3 Add appropriate links into the interfaces directory, as well as a Makefile
covering the interfaces directory
1997-08-16 20:56:28 +00:00
Marc G. Fournier
ff246d7b64 Bring in Adrian's JDBC driver as an interface 1997-08-16 20:51:53 +00:00
Bruce Momjian
fd86ae151a Cleanup global variables, remove stable memory stuff. 1997-08-14 16:11:41 +00:00
Vadim B. Mikheev
e99e4ba833 sprintf "...%d...", ... (int)getpid(), ...
^^^^^
1997-08-14 05:04:38 +00:00
Vadim B. Mikheev
ccc77423db _hash_checkpage: cleanup for CASSERT 1997-08-14 05:01:32 +00:00
Bruce Momjian
0b2eb99f01 These changes allow the module to compile quietly when assert checking is
not being done.
1997-08-12 23:03:50 +00:00
Bruce Momjian
ea5b5357cd Remove more (void) and fix -Wall warnings. 1997-08-12 22:55:25 +00:00
Bruce Momjian
0f6a961e29 cleanup of patch 1997-08-12 20:39:16 +00:00
Bruce Momjian
edb58721b8 Fix pgproc names over 15 chars in output. Add strNcpy() function. remove some (void) casts that are unnecessary. 1997-08-12 20:16:25 +00:00
Bruce Momjian
4b851b1cfc Add bsdi gcc2 options. 1997-08-08 03:51:33 +00:00
Bruce Momjian
dc374505fa Fix for psort again. 1997-08-06 17:11:20 +00:00
Bruce Momjian
677efc7679 Another psort fix. 1997-08-06 07:39:20 +00:00
Bruce Momjian
42c0cd33a2 I think I finally got psort working for all cases. 1997-08-06 07:02:49 +00:00
Bruce Momjian
cc24b846dd psort cleanups. 1997-08-06 05:38:46 +00:00
Bruce Momjian
8fd7db8163 Another fix. 1997-08-06 05:08:37 +00:00
Bruce Momjian
ead219384f Fix for palloc(0) in new code 1997-08-06 04:45:39 +00:00
Bruce Momjian
f5f366e188 Allow internal sorts to be stored in memory rather than in files. 1997-08-06 03:42:21 +00:00
Bruce Momjian
3bea7b138b Add developers help file. 1997-08-06 03:37:34 +00:00
Bruce Momjian
1ebc1280e8 Fix for os version handling. 1997-08-06 03:33:45 +00:00
Vadim B. Mikheev
b3d8beaa1a Catch non-functional delete attempts. 1997-08-06 02:08:39 +00:00
Bruce Momjian
6ed1715b1f Cleanup for NAMEDATALEN use. 1997-08-03 02:38:47 +00:00
Bruce Momjian
ea210dc611 Comment out code that makes no sense, and Purify complains about. 1997-08-03 02:28:10 +00:00
Bruce Momjian
8015ba0836 Prevent relname unallocated string length from being copied into database. 1997-08-02 19:09:33 +00:00
Bruce Momjian
105889e1d8 Makei configure less os-version specific, were possible. 1997-08-02 16:32:51 +00:00
Bruce Momjian
4b965f5758 Fix stout/stderr paging. Do not page \h select, but page \h *. 1997-08-01 04:07:55 +00:00
Bruce Momjian
da76711714 FIx solaris template finding. 1997-08-01 03:49:22 +00:00
Bruce Momjian
a67fd49091 Fix psql error output. 1997-08-01 03:33:02 +00:00
Bruce Momjian
f5f18af02b Configure cleanup for /usr/ucb patch. 1997-07-31 01:37:56 +00:00
Bruce Momjian
aff479b4d1 Look in /usr/ucb first for install. 1997-07-30 19:16:23 +00:00
Bruce Momjian
cdc2c06386 configure.in cleanup for tr and strerror2. 1997-07-30 18:27:18 +00:00
Bruce Momjian
775098bd28 Add -o to psql manual page. 1997-07-30 17:21:29 +00:00
Bruce Momjian
1b20f8ac11 Fix c++ copy example code. 1997-07-30 15:53:57 +00:00
Marc G. Fournier
ecefacd07d Due to BIND 8.1.1, my Solaris 2.5.1 machine doesn't define MAXHOSTNAMELEN...
so, add a check that basically says if it isn't defined, set it to 256...
1997-07-30 14:08:11 +00:00
Marc G. Fournier
5089f6ce87 Check for and use <netdb.h> for postmaster.c, instead of checking if
MAXHOSTNAMELEN is defined.  For some reason, my 2.5.1 Solaris box at
work fails on that check...
1997-07-30 14:03:33 +00:00
Vadim B. Mikheev
ac994a69d6 Allow use parameters in target list having aggregates in functions. 1997-07-30 04:42:26 +00:00
Bruce Momjian
6c93fe8f9d configure.in cleanup from sco install. 1997-07-30 01:32:44 +00:00
Bruce Momjian
bcc883fed3 Remove HAVE_USAGE because it is no longer used. 1997-07-30 00:09:42 +00:00
Bruce Momjian
c86e85df92 Update COPY manual page to remove unneeded warnings. 1997-07-29 21:43:40 +00:00
Bruce Momjian
9db76f384d Update configure after sunos4 update. 1997-07-29 21:16:52 +00:00
Bruce Momjian
461f80cf9a Add strerror to pg_version for sunos4. 1997-07-29 16:36:43 +00:00
Thomas G. Lockhart
622af87fd2 Results from initial changes to add new functions and for bug fixes.
Not all cleaned up yet.
1997-07-29 16:24:04 +00:00
Thomas G. Lockhart
3d5dd9bdd9 Start adding tests for new geometry functions.
Not all cleaned up yet.
1997-07-29 16:22:48 +00:00
Thomas G. Lockhart
c5035643af Use better routines from geometry library. 1997-07-29 16:21:12 +00:00
Thomas G. Lockhart
840ea2497d Change call definition for isreltime(). 1997-07-29 16:19:26 +00:00
Thomas G. Lockhart
3c2d74d2af Add new operators and functions for geometric types.
Add text concatenation operator and function.
Add text trim function for SQL92 support.
1997-07-29 16:17:52 +00:00
Thomas G. Lockhart
e89d139dbe Add new routines.
Change definition for isreltime().
Change some names of #define constants to avoid conflicts with the yacc parser.
1997-07-29 16:16:14 +00:00
Thomas G. Lockhart
e1d9cf096c Remove some unnecessary include statements (comment out with #ifdef FALSE). 1997-07-29 16:14:40 +00:00
Thomas G. Lockhart
bf138e2139 Add routines for text trimming on both ends, substring, and string position.
Used to support SQL92 compatibility.
1997-07-29 16:12:07 +00:00
Thomas G. Lockhart
d95c93bf99 Fix bug to allow hh:mm:ss time entry for timespan/reltime types. 1997-07-29 16:09:38 +00:00
Thomas G. Lockhart
215bc83d75 Remove #ifdef'd support for old i/o styles.
Change box terminology from "length" to "width".
 Use length terminology in common with other geometric types (usually perimeter).
Fix bugs in line arithmetic which resulted in bad intersection calculations.
Deprecate temporary unstored slope fields.
Check explicitly for intersections at endpoints to avoid rounding ugliness.
Add center() routines for lseg, path, polygon.
Add distance() routines for circle-polygon, polygon-polygon.
Check explicitly for points and polygons contained within polygons
 using an axis-crossing algorithm. (Old code just checked bounding boxes).
Add routine to convert circle-box.
*whew*
1997-07-29 16:08:18 +00:00
Thomas G. Lockhart
1ba73ed3a0 Update some reltime code to use new common routines.
Use standard decoder for isreltime().
1997-07-29 15:54:49 +00:00
Thomas G. Lockhart
9d8ae79774 Add debugging statements. 1997-07-29 15:51:33 +00:00
Bruce Momjian
8d25436d70 mkLinux patches from Tatsuo Ishii. 1997-07-29 14:09:11 +00:00
Bruce Momjian
7c5afb87c3 Makefile fix from Tatsuo Ishii. 1997-07-28 23:57:20 +00:00
Bruce Momjian
fd6b3c26ef fix small memory free error. 1997-07-28 23:53:54 +00:00
Bruce Momjian
8338f90d4e Add SCO files. 1997-07-28 01:34:24 +00:00
Bruce Momjian
79e78f0b80 Added SCO support, from Daniel Harris. 1997-07-28 00:57:08 +00:00
Bruce Momjian
5a38a119b2 Remove sparc dir, add difftime macro for sunos. 1997-07-28 00:13:39 +00:00
Bruce Momjian
cfd15d16fa Rename sparc to sunos4 directory. Was misnamed. 1997-07-28 00:08:41 +00:00
Bruce Momjian
d5e21e0924 HPUX 10 patches from Vladimir Turin 1997-07-27 18:52:43 +00:00
Bruce Momjian
3ac9d2fff3 Various compile errors concerning overflow due to shifts, unsigned, and bad prototypes, from Solaris, from Diab Jerius 1997-07-24 20:19:10 +00:00
Bruce Momjian
8447148aad psql: Add PAGER for \h and \?,\C fix, indices spell fix. 1997-07-24 20:01:33 +00:00
Bruce Momjian
4d8a5efcef Add single quotes to \\h set help 1997-07-24 19:11:53 +00:00
Bruce Momjian
9ad6e0db30 More pg_dump patch cleanups. 1997-07-23 17:42:25 +00:00
Bruce Momjian
a7d417cc2f Fix problems with pg_dump for iheritance, sequences, archive tables. 1997-07-23 17:15:13 +00:00
Bruce Momjian
41b805b913 Solaris .similar update. 1997-07-16 02:25:16 +00:00
Marc G. Fournier
012cb6d8c8 Search for ginstall before the other installs...
As requested by Dr. Andrew C.R. Martin
1997-07-15 23:11:38 +00:00
Bruce Momjian
441648d955 .similar patch for irix 1997-07-15 17:16:46 +00:00
Bruce Momjian
5eb4fadeaa Prevent psql optarg free-ing 1997-07-14 22:08:56 +00:00
Bruce Momjian
31fba1d974 Mips sysv4 support. 1997-07-14 16:52:13 +00:00
Bruce Momjian
10da89c1fb Add sysv4 support to configure and docs. 1997-07-14 16:47:36 +00:00
Bruce Momjian
e3be2f9dd7 Update supported ports for 6.1.1 release. 1997-07-14 16:37:36 +00:00
Bruce Momjian
69e5d63839 AIX nm fix from Gerhard 1997-07-13 19:52:10 +00:00
Bruce Momjian
0fca4afbf4 Change char to int as used in EOF compare, Gerhard 1997-07-12 20:31:47 +00:00
Bruce Momjian
a89f9731e9 Have pg_dumpall return proper status on exit 1997-07-12 15:57:31 +00:00
Thomas G. Lockhart
e66f5c05eb Remove endian information which is now in port-specific header files.
Note that this version is probably identical to two versions ago.
1997-07-11 14:09:00 +00:00
Thomas G. Lockhart
c6df30edb9 Modify port-specific definitions to support missing endian information.
Add extra include file for aix to find endian information.
1997-07-11 14:03:01 +00:00
Bruce Momjian
a11ad874e4 Fix for assembler from Yoshihiko ICHIKAWA 1997-07-10 02:32:51 +00:00
Bruce Momjian
3b7ee8f5f9 Allow underscores in user names. 1997-07-10 02:27:27 +00:00
Bruce Momjian
35a952a2ed Fixes from Jody Winston 1997-07-10 01:15:11 +00:00
Bruce Momjian
a5d80cb0cf Date-type fixes from Tatsuo Ishii 1997-07-08 22:06:46 +00:00
Thomas G. Lockhart
75ebaa748e Add information regarding date and time types and functions,
including arguments allowed.
1997-07-02 14:13:14 +00:00
Thomas G. Lockhart
54c38a95ee Add test results for "SET DateStyle" alternative datetime formats. 1997-07-02 01:34:24 +00:00
Thomas G. Lockhart
48b5432769 Include tests for DateStyle output format variations. 1997-07-01 00:34:34 +00:00
Thomas G. Lockhart
3ded6fd511 Fix code to do the right thing with mixed-endian clients and servers. 1997-07-01 00:32:27 +00:00
Thomas G. Lockhart
bf3bcb6a6d Include definitions for endian info if not in system includes. 1997-07-01 00:31:10 +00:00
Thomas G. Lockhart
7bdf9ba35b Add flags to allow dynamic loader to find Postgres sharable libraries without
having to modify the system-wide library database.
1997-07-01 00:29:40 +00:00
Thomas G. Lockhart
495fdfba98 Rearrange DTK_x constants.
Define constants to allow day of week decoding.
Add new datetime and timespan routines.
1997-07-01 00:25:30 +00:00
Thomas G. Lockhart
8507ddb9c6 Use common parser and encoder for timestamp data type.
Remove older date and time code (retain NEW_DATE_CODE and NEW_TIME_CODE).
Use common encoder for date and time.
Fix datetime +/- timespan math bug.
1997-07-01 00:22:46 +00:00
Bruce Momjian
43deb7a45f Fox case-sensitivity for \d and allow trailing ; on backslash commands. 1997-06-29 17:29:28 +00:00
Bruce Momjian
1952f15c5c Fix memory leak in psql. 1997-06-29 05:06:43 +00:00
Vadim B. Mikheev
eb9c8e0a59 _hash_first: release buf & metabuf if no tuples found for a key. 1997-06-28 05:45:40 +00:00
Bruce Momjian
fc96d50a5c lextest cleanup. 1997-06-25 22:21:29 +00:00
Bruce Momjian
7e75f5e8b3 Small pg_dumpall cleanup. 1997-06-25 21:24:57 +00:00
Bruce Momjian
c2010d8e4d fix for initdb --debug core dump, from Tatsuo Ishii 1997-06-25 21:12:19 +00:00
Bruce Momjian
c666255112 Typo changes in tests/ examples. 1997-06-25 19:59:57 +00:00
Thomas G. Lockhart
c05a7bd972 Test "SET DateStyle TO..." output options. 1997-06-23 15:08:59 +00:00
Thomas G. Lockhart
3267b4b767 Adapt expected output to drop ".00" from datetime seconds field.
This is compatible with abstime formats.
1997-06-23 15:07:54 +00:00
Thomas G. Lockhart
89abee4691 Test the "SET DateStyle TO..." date formatting modes. 1997-06-23 15:05:52 +00:00
Thomas G. Lockhart
45409f0cdd Remove code not previously enabled with USE_NEW_DATE and USE_NEW_TIME
#defines.
1997-06-23 15:03:45 +00:00
Thomas G. Lockhart
742425447d Drop internal routines for formatting time output. Use default formatter.
Add timezone info to abstime2tm().
1997-06-23 14:58:51 +00:00
Thomas G. Lockhart
1f4f4534a0 Use the standard date/time encoder rather than strftime() for output.
This allows use of the DateStyle session variable.
1997-06-23 14:56:15 +00:00
Thomas G. Lockhart
01264e84ba Modify EncodeDateTime() to suppress trailing ".00" in seconds field.
This matches the behavior of the original formatting for abstime.
Repair datetime + timespan date arithmetic for year boundaries.
 From patch submitted by Dave Skinner.
1997-06-23 14:50:56 +00:00
Thomas G. Lockhart
d9bccec0d2 Expunge code not enabled with USE_NEW_DATE and USE_NEW_TIME #defines. 1997-06-23 14:47:26 +00:00
Bruce Momjian
a53d85404e pg_dump, pg_dumpall cleanups. 1997-06-21 16:08:17 +00:00
Thomas G. Lockhart
374b0009fd Fix predicted output for month boundary arithmetic problems in
datetime +/- timespan. Only manifested when date is at end of month
 and time pushes the date into the next month.
1997-06-20 17:20:55 +00:00
Thomas G. Lockhart
2f09dd9958 Fix broken parsing for lists of options. Apparently broken when support was
added for keyword=value options.
1997-06-20 17:17:03 +00:00
Thomas G. Lockhart
9af564ada6 Add parser category for "DST" Daylight Savings Time qualifier on time zones. 1997-06-20 17:15:00 +00:00
Thomas G. Lockhart
3cef45d330 Fix leap year and month boundary arithmetic for datetime +/- timespan;
the problem only manifests itself when adding years/months and hours
 when the hours:minutes:seconds pushes over midnight.
Fix interpretation of times with explicit timezone when the timezone is
 in daylight savings time and is not the default timezone.
Allow interpretation of explicit timezone when it is specified as two words:
 <standard time> DST". For example, "MET DST" (Middle European Time Daylight
 Savings Time). This syntax is found in the zic package on Linux boxes at least.
1997-06-20 17:12:54 +00:00
Bruce Momjian
a75d6aaa41 Check pgdump return request. 1997-06-20 16:37:10 +00:00
Bruce Momjian
dd2c410616 Allow pg_dump to preserve owners of all objects. 1997-06-20 02:20:26 +00:00
Vadim B. Mikheev
41882fde34 setVarAttrLenForCreateTable(): use varnoold/varoattno instead of
varno/varattno.
1997-06-13 03:24:26 +00:00
Thomas G. Lockhart
380eaaa139 Add a few words from Vadim and an example on explain output.
Update the update date.
1997-06-12 23:45:54 +00:00
Vadim B. Mikheev
0f576413bc Fix replace_agg_clause() for unary operators. 1997-06-12 17:26:15 +00:00
Bruce Momjian
8f846a321c Update psql EXPLAIN help description, from Thomas. 1997-06-12 16:43:08 +00:00
Vadim B. Mikheev
7540eda8f4 Someone forgot about aligning in fastgetiattr()... 1997-06-12 15:41:52 +00:00
Vadim B. Mikheev
9392a19196 Datum *idatum;
^
1997-06-12 15:39:44 +00:00
Vadim B. Mikheev
1561684a2d Compare 'char' and 'text' lexicographically. 1997-06-11 05:20:05 +00:00
Vadim B. Mikheev
0346ab7175 Lexicographically compare 'char' and 'text'. 1997-06-11 05:18:02 +00:00
Vadim B. Mikheev
dee872de5c geqo_rel_paths(): compute_joinrel_size() shouldn't be called
for non-JoinPath path! So now we have:
    if ( IsA_JoinPath (cheapest) )
        rel->size = compute_joinrel_size(cheapest);
1997-06-11 02:44:12 +00:00
Marc G. Fournier
5c2649b616 From: Darren King <aixssd!darrenk@abs.net>
Subject: [PORTS] Makefile.aix patch.

Have to add libc.a to the link when making a shared lib.
1997-06-11 01:14:49 +00:00
Marc G. Fournier
90d0cf0000 From: Robert Bruccoleri <bruc@bms.com>
Subject: [PORTS] Patches for Irix 6.4

I have worked out how to compile PostgreSQL on Irix 6.4 using the -n32 compiler
mode and version 7.1 of the C compiler. (The n32 compiler use 32 bits
addressing,
but allows access to all the instructions in the MIPS4 instruction set.)
There were several problems:

1) The ld command is not referenced as a macro in all the Makefiles. On
this platform, you have to include -n32 on all the ld commands. Makefiles
were changed as needed.

3) Lots of warnings are generated from the compiler. Since the regression
tests worked OK, I didn't attempt to fix them. If anyone wants the compilation
log, please let me know, and I'll email it to you.

The version of postgresql was 970602. Here is Makefile.custom:

CUSTOM_COPT = -O2 -n32
MK_NO_LORDER = 1
LD = ld -n32
CC += -n32
1997-06-11 01:13:10 +00:00
Marc G. Fournier
4ea3844680 From: "Brian E. Gallew" <geek+@cmu.edu>
Subject: Re: [PORTS] Re: [PATCHES] DG/UX 5.4R11 patches

Comments in boot.sed break DG/UX port
1997-06-11 01:05:48 +00:00
Marc G. Fournier
735bf0b7f2 From: Igor <igor@sba.miami.edu>
Subject: [PATCHES] sequences display in psql

Well, I am away at Progress training (not Postgres!!) and desided to do
this patch during a break. This will allow listing of sequences in
addition to listing of tables and indicies:
\d would should indicies, tables, and sequences
\ds would show sequences only.
1997-06-11 01:03:38 +00:00
Marc G. Fournier
65c4a526fe From: "Eric H. Raskin" <ehr@listworks.com>
Subject: [PATCHES] DG/UX 5.4R11 patches

1) config.guess -- it doesn't understand that the new default
                   "TARGET_BINARY_INTERFACE" (m88kdgux) is now an ELF
                   format, not BCS.
1997-06-11 01:02:01 +00:00
Bruce Momjian
fb5be867ef LO patches for loimport/loexport from Raymond Toy 1997-06-10 13:01:32 +00:00
Vadim B. Mikheev
f4161503e6 if ( rel->size <= 0 )
rel->size = compute_rel_size(rel);
1997-06-10 07:55:47 +00:00
Vadim B. Mikheev
cbb4213af4 if ( new_rel->size <= 0 )
new_rel->size = compute_rel_size(new_rel);
1997-06-10 07:53:55 +00:00
Vadim B. Mikheev
71b3e93c50 Duplicates handling... 1997-06-10 07:28:50 +00:00
Bruce Momjian
858f35510e Cleanup on xinv# table names. 1997-06-07 17:34:35 +00:00
Bruce Momjian
5c34462d9c Make LO patter consistent with psql. 1997-06-07 05:29:22 +00:00
Bruce Momjian
51b03770d7 avoid xinv* table name conflict with large objects. 1997-06-07 05:19:06 +00:00
Marc G. Fournier
0105b79f4f From: Igor <igor@sba.miami.edu>
Subject: [PATCHES] destroydb.1 patch

This is a patch to destroydb man page so that it shows and explains "-i"
option.
1997-06-06 22:08:04 +00:00
Marc G. Fournier
e721e58c03 From: Darren King <aixssd!darrenk@abs.net>
Subject: [PATCHES] psql and large objects fix

Psql was broken by using "Inv[0-9]+" instead of "xin[xv][0-9]+" to not
show large object files.  Been this way for a long time too. Relic of
an older naming convention, perhaps?
1997-06-06 22:05:23 +00:00
Marc G. Fournier
e318022e1a From: "D'Arcy J.M. Cain" <darcy@druid.net>
Subject: [PATCHES] backend/storage/ipc/shmem.c

  - strname is only used if assert checking is on
1997-06-06 22:04:04 +00:00
Marc G. Fournier
0f94738c33 From: "D'Arcy J.M. Cain" <darcy@druid.net>
Subject: [PATCHES] backend/lib/fstack.c

  - The FixedStackIsValid so obviously needs to be a macro
  - FixedStackContains only called if assert checking on
1997-06-06 22:02:37 +00:00
Thomas G. Lockhart
20e71222ea Change one date away from PST to avoid trouble after daylight savings time. 1997-06-06 06:13:10 +00:00
Thomas G. Lockhart
e7044d70ef Change one date away from PST to avoid trouble after daylight savings time. 1997-06-06 06:05:53 +00:00
Bruce Momjian
a089cdd9d3 lowercase large object table name fix. 1997-06-06 03:41:16 +00:00
Vadim B. Mikheev
e3d2f1f35d gimme_tree(): got rid of compute_rel_size() -
compute_joinrel_size already called by geqo_rel_paths.
1997-06-06 03:18:02 +00:00
Vadim B. Mikheev
c8a38d5d97 Added check is new item successfuly inserted to a page or not. 1997-06-06 03:11:46 +00:00
Marc G. Fournier
8d1f52ef24 From: Igor <igor@sba.miami.edu>
Subject: [PATCHES] More psql and libpq patches

Well..these would be the last patches until the release (I hope)...
I ran the regression tests while watching psql under purify, and it did
not leak even one byte.

In this patch:

* Plugged a major leak when PSQL reads files for input (either through
  \i options or through -f option)
* Fixed the one remaining leak in PSQL in not clearing PGresult *results
  everywhere it is supposed to. (Thanks Tymm)
* Fixed A small leak in PSQL not clearing all the PGsettings correctly.
* A not-so-obvious (but small) leak in Libpq when PQsetdb fails for any
  reason.
* Added \n to some Libpq error messages to make them easier to digest..
* Finally, added /* PURIFY */ comment to some of the code indicating
  the reason for why it was added/changed...for future developers.
1997-06-06 01:42:02 +00:00
Marc G. Fournier
442306fe36 From: "Brian E. Gallew" <geek+@cmu.edu>
Define USE_POSIX_TIME for dgux port
1997-06-06 01:39:24 +00:00
Marc G. Fournier
11c7d75560 From: Phil Nelson <phil@cs.wwu.edu>
Subject: [PATCHES] Patches to allow generic NetBSD support
1997-06-06 01:38:24 +00:00
Marc G. Fournier
15da18508f From: Phil Nelson <phil@cs.wwu.edu>
Subject: [PATCHES] Added support for NetBSD/pc532.
1997-06-06 01:37:23 +00:00
Marc G. Fournier
355d6a2767 From: PortSite <info@portsite.nl>
The GNUmakefile in src/test/regress uses `gmake' for
the make program. This should be $(MAKE)
1997-06-06 01:35:57 +00:00
Marc G. Fournier
c0178f27a2 From: "D'Arcy J.M. Cain" <darcy@druid.net>
Subject: [HACKERS] src.original/./backend/lib/fstack.c

Another change I suggested.  I bracket an unused function and add a
return to quiet the compiler.  In addition I added an internal
consistency check.
1997-06-06 00:38:17 +00:00
Marc G. Fournier
f50b103ce1 From: "D'Arcy J.M. Cain" <darcy@druid.net>
Subject: [HACKERS] backend/optimizer/geqo/geqo_erx.c

I sent these changes in with a bunch of others.  Some were folded in but
others, like these, were not.  I am not sure why so I am resending this
to the developers list by itself for discussion.

The readon why I suggest these changes is that the compiler can't tell
that minimum_count is initialized before it is used.  The tests that I
add in here will cause an immediate error if it doesn't.  As the comments
below suggest, if it is 100% guaranteed that the variable will always
be initialized then how this is so should be commented here.  I don't
know how much strain the actual test puts on the performance but if it
isn't too much then maybe leave it in for absolute safety anyway.

There are also a few returns just to stop warnings.
1997-06-06 00:37:23 +00:00
Bruce Momjian
a668b7ac2d Fix for large objects and case sensitivity, from Raymond Toy. 1997-06-05 22:59:45 +00:00
Bruce Momjian
ce2fcd0180 bsdi configure detection fix. 1997-06-05 17:36:43 +00:00
Vadim B. Mikheev
11073bee5c allpaths.c:find_join_paths(): compute_rel_size() shouldn't be called
for join-relations. Sizes already computed by
prune_rel_paths():compute_joinrel_size().

joinrels.c:
<                   if ( _use_right_sided_plans_ )
---
>                   if ( _use_right_sided_plans_ &&
>                               length (outer_rel->relids) > 1 )

 - r_plans are useful when outer_rel is join-relation... It
decreases the size of search space...
1997-06-05 09:33:52 +00:00
Vadim B. Mikheev
39c73eff63 Definition for RelationForgetRelation(). 1997-06-04 09:01:49 +00:00
Vadim B. Mikheev
9c6cdb4d7b heap_destroy() now calls RelationForgetRelation() to really flush
the relation from the relcache.
1997-06-04 08:59:22 +00:00
Vadim B. Mikheev
ded4650642 New func RelationForgetRelation();
*         RelationFlushRelation + if the relation is local then get rid of
 *         the relation descriptor from the newly created relation list.
1997-06-04 08:56:51 +00:00
Bruce Momjian
21437b747b Add bsdi to template detection. 1997-06-03 20:08:06 +00:00
Thomas G. Lockhart
98b56067ed Use error message syntax consistant with other messages from the same
reference platform (Linux/gcc-lib/i686).
1997-06-03 14:34:51 +00:00
Thomas G. Lockhart
e6924c9750 Update to reflect new "drop aggregate" syntax and messages. 1997-06-03 14:31:46 +00:00
Thomas G. Lockhart
8aefe09731 Update to show new path and polygon syntax. 1997-06-03 14:29:51 +00:00
Thomas G. Lockhart
3d9584c9d9 Update path and polygon syntax to new conventions. 1997-06-03 14:24:12 +00:00
Thomas G. Lockhart
ad7952aae3 Update to use new path geometric type syntax.
Order in streets.data changed and is now alphabetical (sorry).
1997-06-03 14:21:36 +00:00
Thomas G. Lockhart
dc5bcc8621 Modify banner to suggest using PST8PDT time zone rather than full specifier
string.
1997-06-03 14:19:28 +00:00
Thomas G. Lockhart
066fce7bf9 Update to suggest using PST8PDT time zone rather than full time zone string.
Include section on error message differences.
1997-06-03 14:18:38 +00:00
Thomas G. Lockhart
4bd4a55b98 Add upgradepath(), isoldpath(), upgradepoly() and revertpoly() to allow
upgrading from existing pre-v6.1 path and polygon geometric data types.
1997-06-03 14:11:28 +00:00
Thomas G. Lockhart
3887d41b13 Put parens around macro arguments for safety per D'Arcy's suggestion. 1997-06-03 14:07:24 +00:00
Thomas G. Lockhart
06ea3c9a24 Add upgradepath(), isoldpath(), upgradepoly() and revertpoly() to allow
migration from pre-v6.1 geometric data types.
Only allow new input syntax for paths and polygons.
1997-06-03 14:01:22 +00:00
Thomas G. Lockhart
fe74581fa0 Use finite() macro if available to check returns from pow() and exp(). 1997-06-03 13:58:06 +00:00
Thomas G. Lockhart
93ac35f06c Fix a few DATEDEBUG print statements. 1997-06-03 13:56:32 +00:00
Vadim B. Mikheev
fa940fda67 cc1: warnings being treated as errors
dt.c: In function `timespan2tm':
dt.c:1722: warning: unused variable `funit'
dt.c:1722: warning: unused variable `iunit'

-> got rid of them.
1997-06-03 06:32:56 +00:00
Vadim B. Mikheev
b46e5b5281 SET geqo TO 'on' restores _use_geqo_rels_ to GEQO_RELS, not
to last specified with 'on' #.
What is better ?
1997-06-03 06:29:31 +00:00
Vadim B. Mikheev
f1cf69c080 cc1: warnings being treated as errors
remove.c: In function `RemoveAggregate':
remove.c:413: warning: unused variable `typename'

-> got rid of it.
1997-06-03 06:23:24 +00:00
Vadim B. Mikheev
9d14ef9465 SET var TO '...'
^^ - added
1997-06-03 06:19:11 +00:00
Vadim B. Mikheev
cd3f1bcab0 cc1: warnings being treated as errors
psql.c: In function `HandleSlashCmds':
psql.c:1141: warning: `optarg3' might be used uninitialized in this function
psql.c:1157: warning: `optarg3' might be used uninitialized in this function

-> char           *optarg3 = NULL;
1997-06-03 06:17:34 +00:00
Vadim B. Mikheev
2c7e2851d7 Cleanups. 1997-06-03 04:14:31 +00:00
Bruce Momjian
3fd9a62088 Add \dt and \di to psql help. 1997-06-03 03:35:46 +00:00
Vadim B. Mikheev
3afafc8c69 New description of currval. 1997-06-03 03:19:08 +00:00
Vadim B. Mikheev
9c0d64c21c #define GEQO_RELS 6 (not 7) 1997-06-03 03:15:50 +00:00
Vadim B. Mikheev
2f8c2e997b Fix deleted tuples re-incarnation possible when vacuum transaction
start time equal to tuple->t_tmax.

Privent shrinking if there are tuples modifyed by running transactions
(it concerns system relations only, currently).
1997-06-03 01:29:26 +00:00
Edmund Mergl
234776dbbc *** empty log message *** 1997-06-02 19:42:14 +00:00
Bruce Momjian
09e41a037e Update man and psqlHelp for new SET GEQO=# option. 1997-06-02 14:12:40 +00:00
Bruce Momjian
290bef4e05 Allow for EOF or \0 as input() return from lex. 1997-06-02 13:55:19 +00:00
Vadim B. Mikheev
5b5c83f9e7 Oracle like currval behaviour. 1997-06-02 11:22:52 +00:00
Vadim B. Mikheev
465047d604 #define GEQO_RELS 7
moved from geqo.h to internal.h.
1997-06-02 11:19:33 +00:00
Vadim B. Mikheev
05404562fb Use GEQO if _use_geqo_ is TRUE and # of relations is >= _use_geqo_rels_
(both are settable via SET geqo TO ...).
1997-06-02 11:14:40 +00:00
Vadim B. Mikheev
cda886fd06 SET var TO 'a=b'
^^ is supported by get_token now.
(SET geqo TO 'on=XXX' works now).
1997-06-02 11:00:57 +00:00
Marc G. Fournier
541f18558d From: Igor <igor@sba.miami.edu>
Subject: [PATCHES] patch for a memory leak

Well...I screwed up and posted the wrong patch for psql originally..
The patch for that patch wposted below will fix it..
1997-06-02 03:04:50 +00:00
Marc G. Fournier
8445ccd57a From: Igor <igor@sba.miami.edu>
Subject: [PATCHES] Another destroydb patch

This is a patch to my previous destroydb patch cause some people wanted
slightly different behavior. After this patch is applied, destroydb
will destroy a database as usual, but if added -i flag (which could be
aliased like rm -i) would ask for confirmation.
1997-06-02 02:53:00 +00:00
Marc G. Fournier
f9f98e3aff From: Igor <igor@sba.miami.edu>
Subject: [PATCHES] pg_dump memory leak patch

This patch fixes a HUGE memory leak problem in pg_dump.
Pretty much anything that was allocated was never freed and Purify
reported about 40% possible memory leak and 6% actual leak. I added
functions to clear out all the allocated structures. After the patch
Purify returns 0 for number of bytes leaked...
1997-06-02 02:52:06 +00:00
Marc G. Fournier
a27fafecc5 Ordering of libraries changed so that -lbsd is *after* -lm
Fixes a problem Darren reports with AIX, and doesn't seem to break either
FreeBSD or Linux(David?)...
1997-06-01 16:25:34 +00:00
Marc G. Fournier
ff038a5b97 From: Darren King <aixssd!darrenk@abs.net>
Subject: [PATCHES] psql - \dt,\di commands.

I sent this a couple of months ago in re a request by Maxim
Kozin, but I had the patch reversed, creating some confusion
over applying it.

Here's a more complete version.

Adds \dt to list only tables/views and \di to list only
indicies.  \d will still work as before.
1997-06-01 15:53:24 +00:00
Marc G. Fournier
187e0f2405 From: Phil Nelson <phil@cs.wwu.edu>
Subject: [PATCHES] Support for NetBSD/sparc

The following is a patch to allow BSD44_derived to support NetBSD/sparc.
1997-06-01 15:51:10 +00:00
Marc G. Fournier
b3db8ee0b2 From: Darren King <aixssd!darrenk@abs.net>
Subject: [PATCHES] aix.h needs POSIX...
1997-06-01 15:50:08 +00:00
Marc G. Fournier
ad8d504f90 From: Robert Bruccoleri <bruc@bms.com>
One more Irix related patch for Dynamic Linking
1997-06-01 15:41:40 +00:00
Marc G. Fournier
3903296b2a From: Igor <igor@sba.miami.edu>
Subject: [PATCHES] destroydb patch

I am including a patch for destroydb to ask for confirmation before
deleting databases (after I accidentally deleted mine)...destroydb -y
would force delete without any confirmation.
1997-06-01 15:40:08 +00:00
Marc G. Fournier
9a5529f4d1 From: Igor <igor@sba.miami.edu>
Subject: [PATCHES] memory leak patches in libpq and psql

A couple of small memory leak patches (detected with Purify) primarily
in libpq.

* Fixed (NULL) border problem in psql (run psql, do \m, then select
  something from a table...row separators will be nulls)
* Fixed memory leak with the abovementioned border not being freed
  properly.
* Fixed memory leak in freePGconn() not freeing conn->port
* Fixed up PQclear() to free parts of PGresult only if these
  parts are not null.
* Fixed a decent memory leak that occured after executing every command
  in psql. PGresult *results was not freed most of the time.

There is still a leak being detected (2 bytes) in readline functions, but
I think this is old readline library. I will install new one and test it.
1997-06-01 15:39:08 +00:00
Bruce Momjian
d95572767e Added \n to error message. 1997-06-01 04:59:25 +00:00
Bruce Momjian
6c82ae2c02 Add R_PLANS to psql help, and SET cleanup. 1997-06-01 04:53:44 +00:00
Bruce Momjian
6ed9f2f17b DROP agg psql help change from Darren. 1997-06-01 04:32:41 +00:00
Bruce Momjian
195d7dea00 SET R_PLANS added to manual page. 1997-06-01 04:23:12 +00:00
Bruce Momjian
afb089d4a4 Put back old lines. 1997-06-01 04:16:16 +00:00
Bruce Momjian
f93bd64504 Add bsdi 3.0 to configure. 1997-06-01 04:05:26 +00:00
Bruce Momjian
93b03649d4 Cleanup for AIX from Darren. 1997-06-01 03:39:28 +00:00
Bruce Momjian
35717aa24f Escape newline in select output, from A. Duursma. 1997-06-01 03:18:32 +00:00
Bruce Momjian
8bc7439ccf Enable GEQO for more than six tables, from Martin. 1997-06-01 02:56:00 +00:00
Bruce Momjian
4d9b4dc973 Changed 1943 to 1947 to fix, other cleanups. 1997-06-01 02:30:25 +00:00
Bruce Momjian
c3a960ad8a Fix for SELECT * INTO TABLE for char(), varchar() fields. 1997-05-31 16:52:19 +00:00
Vadim B. Mikheev
ad01dd270d If there is no table in RangeTable for colname then
elog (WARN, "attribute %s not found", colname);
1997-05-31 07:10:25 +00:00
Vadim B. Mikheev
139858e699 If we have to split leaf page in the chain of duplicates
then we try to look at our right sibling first, but not farther,
as it was in yesterday fix.
1997-05-31 06:35:56 +00:00
Vadim B. Mikheev
5cf55737a4 Added: new BTP_CHAIN flag (if hikey == firstkey then it's not
last page in chain of duplicates).
1997-05-30 18:40:02 +00:00
Vadim B. Mikheev
3f5834fb8c Fix duplicates handling. 1997-05-30 18:35:40 +00:00
Thomas G. Lockhart
43b6f1e678 Clean up support for USE_POSIX_TIME, ! HAVE_INT_TIMEZONE machines.
Remove references to modf() which is buggy on some platforms (Sparc/Linux).
1997-05-30 15:02:51 +00:00
Thomas G. Lockhart
07f0647808 Ensure double alignment for time and arrays of circles. 1997-05-26 16:55:23 +00:00
Marc G. Fournier
cf88367751 From: David Friend <dfriend@atlsci.atlsci.com>
Subject: [PATCHES] pqcomprim.c patch

This is the patch by Robert Bruccoleri to fix the endian problem.
(Actually, it's the reverse of his patch.  He must have gotten the
order wrong.)
1997-05-26 00:26:56 +00:00
Marc G. Fournier
ca746f512d -m <arg> -M weren't setup properly in getopts()...
These are undocumented in the man pages though...should they be removed?

Reported by: "A. Duursma" <it@portsite.nl>
1997-05-25 15:37:15 +00:00
Bruce Momjian
098dea8633 Fix core dump on \c. 1997-05-24 14:38:05 +00:00
Bruce Momjian
656d88c611 Fix \c option after breaking it. 1997-05-24 01:45:17 +00:00
Thomas G. Lockhart
ac534bee01 Clean up redundant tests for valid pointers in geometric types.
Fix up decoder field masks for timespan and reltime.
1997-05-23 05:24:53 +00:00
Thomas G. Lockhart
0828204538 Enable new date and time definitions to allow Solaris and Irix -O2 compilation.
Move date and time field type labels to less than 32 to allow use as masks.
1997-05-23 05:10:03 +00:00
Vadim B. Mikheev
d865228807 AllocateFile():
fdleft = pg_nofile() - allocatedFiles - nfile;
looks more realistic, but too noisy -
   fdleft = pg_nofile() - allocatedFiles;
restored.
1997-05-23 02:56:48 +00:00
Bruce Momjian
449e575595 Only free memory if environment value is replaced. 1997-05-23 01:53:42 +00:00
Bruce Momjian
658f229ac6 Comment on fix added. 1997-05-23 00:20:20 +00:00
Bruce Momjian
148f7203fa Preserve putenv() memory in psql \connect user fix. 1997-05-22 23:57:27 +00:00
Bruce Momjian
65ff0feacf Fix backslash commands broken when \connect user added. 1997-05-22 18:55:40 +00:00
Vadim B. Mikheev
c9be1bccc1 RelationPurgeLocalRelation():
/*
             * RelationFlushRelation () below will flush relation information
             * from the cache. We must call smgrclose to flush relation
             * information from SMGR & FMGR, too. We assume that for temp
             * relations smgrunlink is already called by heap_destroyr
             * and we skip smgrclose for them.          - vadim 05/22/97
             */
            smgrclose(reln->rd_rel->relsmgr, reln);

 - it avoids memory leaks in SMGR & VFD.

RelationFlushRelation():
   there is no more call FileInvalidate(RelationGetSystemPort(relation));
   - invalid (FileInvalidate() expects File, not SMGR' fd)
   - unuseful anyway.
1997-05-22 17:24:20 +00:00
Vadim B. Mikheev
19269069dc 1. Fix md memory leak:
mdunlink() and mdclose() (too !!!) now free MdfdVec for relation
   and add it to free list, so it may be re-used for another relation
   later.
2. Fix VFD-manager memory leak (found by Massimo ... and me):
   mdunlink() has to call FileUnlink() to free allocation for fileName
   and add the Vfd slot to the free list.
1997-05-22 17:08:35 +00:00
Vadim B. Mikheev
ff8ce5230d 1. Cleanup (no more FreeFd - unuseful; others).
2. FreeFile() has to do nothing with nfile (# of files opened
   by VFD manager).
1997-05-22 16:51:19 +00:00
Vadim B. Mikheev
12d9a12eda gist.h:
/*
** You can have as many strategies as you please in GiSTs, as
** long as your consistent method can handle them
*/
#define GISTNStrategies                 100
                                        ^^^
- too big number:

strat.h->StrategyEvaluationData->StrategyExpression  expression[12]
                                                                ^^
 - so 12 is real max # of strategies, or StrategyEvaluationIsValid
crashes backend (called if CASSER defined).
1997-05-22 16:09:57 +00:00
Vadim B. Mikheev
737ab85cc0 1. Pass GISTENTRYs to giststate->penaltyFn by pointers, not by vals.
2. Re-initialize keys in gistrescan (if gist used in inner scan).
1997-05-22 16:01:33 +00:00
Marc G. Fournier
4800abc7c1 From: Darren King <aixssd!darrenk@abs.net>
To: pgsql-patches@postgreSQL.org
Subject: [PATCHES] DROP AGGREGATE gram.y typo...


Somehow I dropped a comma in the gram.y part (line 129) of my
patch for drop aggregate.  Here's a correct patch for gram.y.

PS. I hope I got the right comma, manually applied :) (scrappy)
1997-05-22 00:24:07 +00:00
Marc G. Fournier
5e7c0a0b9a From: Darren King <aixssd!darrenk@abs.net>
Subject: [PATCHES] DROP AGGREGATE patch/fix.


Here's a patch that fixes the DROP AGGREGATE command to delete
the desired aggregate for a specific type.
1997-05-22 00:17:24 +00:00
Marc G. Fournier
021ccf0b8c Oops, missed the commit on this one by Darren King also...new Makefile.aix 1997-05-22 00:12:03 +00:00
Marc G. Fournier
24ed6d604d From: Darren King <aixssd!darrenk@abs.net>
Subject: [PATCHES] AIX make patch resubmitted.

Misc patches for AIX from Darren:

1)  New src/makefiles/Makefile.aix  This patch should only be
    applied if the following patch (4) is applied to backend/Makefile!
    Still looking into having configure determine the last line to do
    the shared link.  The 325 code will work for 41, so I put that in
    as the default.  Included a commented out 41 line for completeness.

*and*

4)  Patch the backend Makefile.  I've reviewed this patch with respect to the
    other ports that use MAKE_EXPORTS (svr4 and univel) as closely as I could
    and I don't see where it will break them.  If it does, please let me know
    and I'll rework it somehow.
1997-05-22 00:11:29 +00:00
Marc G. Fournier
3e871388b5 From: Darren King <aixssd!darrenk@abs.net>
Subject: [PATCHES] Re: [PORTS] AIX 6.1 fixes...

Here are the patches for the two things that wouldn't make it thru the AIX
compiler.  The geo_ops.c change is harmless I believe.  The nbtcompare.c patch
fixes me, but I don't know about any other ports.  Maybe wait on that one
until Vadim decides what to do about the unsigned vs signed chars varlena
issue.
1997-05-22 00:07:30 +00:00
Bruce Momjian
fce2c41b6c Updated pg_dumpall and psql to preserve database owners. 1997-05-21 03:12:23 +00:00
Bruce Momjian
cb8396d9fc Add SRCDIR to lextest 1997-05-21 00:45:24 +00:00
Bruce Momjian
ca56c2a311 Fix for lextest return value. 1997-05-20 21:35:16 +00:00
Vadim B. Mikheev
92ab5dc2b5 Little memmory leak in RelationFlushRelation() in freeing
relation->rd_att (relation' TupleDesc).
1997-05-20 11:41:38 +00:00
Vadim B. Mikheev
b0dfe8e38e Define FREE(x) as pfree. 1997-05-20 11:37:33 +00:00
Vadim B. Mikheev
5f893a1e32 Shouldn't we use palloc instead of malloc ?
Because of
 *      resetpsort  - resets (frees) malloc'd memory for an aborted Xaction
 *
 *      Not implemented yet.
1997-05-20 11:35:50 +00:00
Vadim B. Mikheev
e7f7cf4a1c 1. LocalBufferSync(): set nextFreeLocalBuf to 0 - we're freeing
all local buffers @ xact commit, so accordingly nextFreeLocalBuf
   is first local buffer now.
   It helps to avoid unnecessary local buffer allocations in LocalBufferAlloc()
   latter ("memmory leaks" in 'order by').
2. ResetLocalBufferPool() lost allocated local buffers:

   memset(LocalBufferDescriptors, 0, sizeof(BufferDesc) * NLocBuffer);

   (local buffers leak @ xact aborts).
1997-05-20 11:30:32 +00:00
Vadim B. Mikheev
4a8c3dddc3 Consider right-sided plans if _use_right_sided_plans_ is true. 1997-05-20 10:37:26 +00:00
Vadim B. Mikheev
c4ab256383 New VAR r_plans added to enable turn ON/OFF
using right-sided plans.
1997-05-20 10:31:42 +00:00
Vadim B. Mikheev
0f67fb46f6 Initialize internal keys if rtree used in inner scan. 1997-05-20 10:29:30 +00:00
Bruce Momjian
a1157deb57 Added fcvt() prot for bsdi.
Made PQsetdb() and PQfnumber() case-insensitive.
Removed attempt to set table ownership via pg_dumpall.
1997-05-20 03:39:02 +00:00
Marc G. Fournier
9860926148 From: Darren King <aixssd!darrenk@abs.net>
Subject: [PATCHES] AIX 6.2 make patch.

New template files to replace the old AIX template
1997-05-20 03:00:17 +00:00
Bruce Momjian
8073af5267 Remove create_database interactive prohibition from manual. 1997-05-19 14:23:08 +00:00
Bruce Momjian
b1ae7aac93 Add Makefile.global to lextest makefile. 1997-05-19 14:19:13 +00:00
Marc G. Fournier
6ea80b470b From: Olaf Mittelstaedt <MSTAEDT@va-sigi.va.fh-ulm.de>
Minor patches to geo_ops.c to clean up compile under AIX 4.1.3
1997-05-19 03:49:39 +00:00
Marc G. Fournier
500b17eadf These two files got reversed somehow... -K PIC is a cc'ism and -fPIC is a
gcc'ism
1997-05-19 03:21:55 +00:00
Edmund Mergl
33a629cfef added const declaration in form() E.Mergl 1997-05-17 16:25:57 +00:00
Edmund Mergl
0c67d28a08 added const declaration E.Mergl 1997-05-17 16:23:06 +00:00
Thomas G. Lockhart
5bc1024225 Remove troublesome type coersions from the char8 return statements.
Noted in trying to port to AIX.
1997-05-17 06:20:34 +00:00
Thomas G. Lockhart
99643abec7 Spiff up description of the regression tests and outcomes. 1997-05-17 06:17:45 +00:00
Thomas G. Lockhart
02233addcc Include information for reset, set, and show commands. 1997-05-17 06:16:34 +00:00
Marc G. Fournier
e454d8a116 From: David Friend <dfriend@atlsci.atlsci.com>
Add an entry for the Sparc/Linux port in .similar
1997-05-17 03:02:04 +00:00
Thomas G. Lockhart
51e0fe5c88 Improve informational messages for "show" command responses. 1997-05-16 07:24:13 +00:00
Thomas G. Lockhart
f8d4b3cf40 Fix expected output for datetime and abstime to/from date conversions.
This results from improvements in datetime.c which ensures that the
 conversions are done in local time rather than GMT.
1997-05-16 07:22:28 +00:00
Thomas G. Lockhart
e35b759fed Fix datetime and abstime conversions to and from date.
Bring optional new-storage date and time up to date and test.
This new storage format should fix the "Sparc gcc -O2 bug".
(Enable new code with USE_NEW_DATE and USE_NEW_TIME in dt.h)
1997-05-16 07:19:50 +00:00
Thomas G. Lockhart
07f01fc274 Add documentation for reset, set, and show, and cross-reference in built-in. 1997-05-16 07:13:54 +00:00
Marc G. Fournier
d7a85cb2c9 Modify lextest and GNUmakefile so that if the test does fail, the
make doesn't proceed
1997-05-16 02:00:03 +00:00
Marc G. Fournier
718adf8bf7 Have Make process exit if lextest fails 1997-05-16 01:09:39 +00:00
Marc G. Fournier
cc349d2c87 From: Robert E. Bruccoleri <bruc@bms.com>
Fixes:

	Shared objects are not linked correctly
1997-05-15 22:55:35 +00:00
Bruce Momjian
2fc04874a6 Allow pg_dumpall to preserve database ownership. 1997-05-14 19:49:34 +00:00
Bruce Momjian
029873a109 Remove README.flex and make lextest point to INSTALL. 1997-05-14 17:12:30 +00:00
Bruce Momjian
bb50eeb740 lextest Makefile cleanup 1997-05-14 04:46:47 +00:00
Thomas G. Lockhart
9fd868d16a Rename new float and int conversion routines to avoid conflicts with
system calls on AIX (and probably other machines too).
1997-05-14 04:35:10 +00:00
Bruce Momjian
d906936e0e Add test for flex bug as part of make, and point them to README.flex. 1997-05-14 03:32:40 +00:00
Vadim B. Mikheev
073adc5a25 Added:
Note: currently, only btree access method supports  multi-
       attribute indices.  Up to 7 keys may be specified.
1997-05-14 01:38:34 +00:00
Marc G. Fournier
45165538c5 From: "Brian E. Gallew" <geek+@cmu.edu>
Subject: [PORTS] minor fix for DGUX port

src/include/port/dgux.h needs the following three lines appended:

#ifndef         BYTE_ORDER
#define         BYTE_ORDER      BIG_ENDIAN
#endif


I believe this to be correct for DG/UX on M88k processors.  I don't have one of
the new Intel-based boxes to check on.
1997-05-13 22:13:33 +00:00
Bruce Momjian
f22f57ca35 Update manual pages for vacuum and create index for Vadim. 1997-05-13 04:41:54 +00:00
Thomas G. Lockhart
1e790e207f Fix return value for tm2datetime to properly indicate failure. 1997-05-13 04:26:07 +00:00
Bruce Momjian
b6b41172f6 fix for sizeof pointed out by Ed Buddington 1997-05-13 01:46:00 +00:00
Vadim B. Mikheev
3e248edf43 Added _readAggreg() to work with T_Aggreg type. 1997-05-12 07:17:23 +00:00
Thomas G. Lockhart
8ce8d6550f Update to current information for upcoming v6.1 production release. 1997-05-11 15:46:19 +00:00
Thomas G. Lockhart
cc25efef92 More tables are listed in the user-defined relations from other regression
tests, including new tests.
1997-05-11 15:45:10 +00:00
Thomas G. Lockhart
83b8cf5b6b Add inter-type regression tests for geometry, date/time, and numbers.
Add regression tests for circles, line segments, and paths.
Modify regression tests to allow GEQ optimizer (order results).
1997-05-11 15:42:09 +00:00
Thomas G. Lockhart
57f55032ff Add type conversion functions between floats and integers.
Include some additional path functions which were coded but omitted here.
Add translation and rotation/scaling operators for some geometric types.
Fix bugs in some geometry comparison operator declarations.
1997-05-11 15:19:33 +00:00
Thomas G. Lockhart
407cd4ee24 Add a few type conversion functions.
Pass an additional argument for date/time formatting to better handle timezones.
1997-05-11 15:13:49 +00:00
Thomas G. Lockhart
64d9b50893 Fix timezone manipulation code to avoid crashes on some machines.
Add type conversion functions for floating point numbers.
Check for zero in unary minus floating point code (IEEE allows an
 explicit negative zero which looks ugly in a query result!).
Ensure circle type has non-negative radius.
1997-05-11 15:11:47 +00:00
Marc G. Fournier
498d2d1edc From: Edmund Mergl <E.Mergl@bawue.de>
Subject: [PATCHES] libpq patch

Hi,

here is a small patch which fixes two problems:

1. libpq/libpq-fe.h:

somehow disappeared the line

#define DefaultOption ""

now compilation stops with an error complainig an
unknown DefaultOption (970508).


2. Same patch as I sent already twice, but it never made it
  into the source tree:  there is no default value for
  AuthType and Password. This way any libpq-application
  (i.e. perl-scripts) which use the function PQconnectdb
  will break with PostgreSQL-6.1. The patch simply uses
  an empty string as default value.
1997-05-09 03:28:54 +00:00
Marc G. Fournier
6ef382c621 From: Keith Parks <emkxp01@mtcc.demon.co.uk>
Subject: [PATCHES] Patches for boolean, timespan and reltime regression tests.

Hi All,

Here are a couple of patches to the regression tests to introduce
some specific ordering to the results.

I've only made changes to the queries that were exhibiting differences
on my regression runs.

This will also have the side effect of testing the ordering code for
the boolean and some of the time types.
1997-05-09 03:26:56 +00:00
Bruce Momjian
91f4df2f2c Fix typechecking problem pointed out by Thomas. 1997-05-08 02:45:53 +00:00
Bruce Momjian
ffb38bd3ae Update for bsdi 1997-05-08 02:30:23 +00:00
Marc G. Fournier
8217202134 From: "Martin J. Laubach" <mjl@CSlab.tuwien.ac.at>
Subject: [PATCHES] libpq SET var TO patch

  One last, I hope. This one corrects a bogus format string, and
actually sends the contents of PG_DATESTYLE to the backend. That
means, you can do a setenv PG_DATESTYLE 'iso', and your libpq
will pick that up and tell the backend.
1997-05-07 03:13:50 +00:00
Marc G. Fournier
9f2d714620 From: "Paul M. Aoki" <aoki@CS.Berkeley.EDU>
Subject: [PATCHES] port patch: ultrix4

ultrix4 doesn't compile without this.  this also fixes a problem
with dynamic loading (ultrix relocatable objects must be loaded
with -G 0).
1997-05-07 03:12:46 +00:00
Marc G. Fournier
a5d7eb90a8 From: Keith Parks <emkxp01@mtcc.demon.co.uk>
Subject: [PATCHES] Three small patches.

Hi,

Here are 3 small patches to the postgreSQL source sup'd on
the 6th May 1997.

The 1st 2 fix the shell backslash "c" handling used to suppress
the newline on some unix shells. (The \c needs to be inside quote.)

The 3rd may or may not be the correct way to fix the missing
define of INDEX_MAX_KEYS in pg_dump.h
1997-05-07 02:59:59 +00:00
Marc G. Fournier
505a4709e2 From: Erich Stamberger <eberger@gewi.kfunigraz.ac.at>
Subject: [PATCHES] oracle_compat functions core dumping on NULL-fields
1997-05-07 02:46:45 +00:00
Thomas G. Lockhart
d464e31593 Remove valid pointer checks for returns from palloc() since palloc() will not
return if storage is not allocated. Ref: Vadim 97/05/01
1997-05-06 07:27:51 +00:00
Thomas G. Lockhart
36d18351aa Change dummy array dimensions from [0] to [1] to keep non-gcc compilers happy.
No real change in the support code is required since the actual size
 of the structures is calculated using offsetof() rather than sizeof().
1997-05-06 07:24:42 +00:00
Thomas G. Lockhart
6e27af13eb Rename LOread() and LOwrite() to loread() and lowrite() to allow use by
case-insensitive SQL parser.
1997-05-06 07:20:53 +00:00
Thomas G. Lockhart
ef2821d0d6 Change LOread() and LOwrite() to loread() and lowrite() to allow use
with case-insensitive SQL parser.
1997-05-06 07:19:04 +00:00
Thomas G. Lockhart
fad56c5211 Change LOread() and LOwrite() to loread() and lowrite() to allow use
by case-insensitive SQL parser.
1997-05-06 07:16:21 +00:00
Thomas G. Lockhart
94123219bf Rename LOread() and LOwrite() to be lower case to allow use
in case-insensitive SQL. Define LOread() and LOwrite() as macros
 to avoid having to update calls everywhere.
1997-05-06 07:14:34 +00:00
Vadim B. Mikheev
a65dd5290e 1. Multi-column indices support.
2. Fix for function indices with more than 1 attrs.
1997-05-06 05:20:21 +00:00
Vadim B. Mikheev
13f41aa90b mdcreate():
fd = FileNameOpenFile(path, O_RDWR|O_CREAT|O_EXCL, 0600);

    /*
     *  If the file already exists and is empty, we pretend that the
     *  create succeeded.  During bootstrap processing, we skip that check,
     *  because pg_time, pg_variable, and pg_log get created before their
     *  .bki file entries are processed.
     *
>    *  As the result of this pretence it was possible to have in
>    *  pg_class > 1 records with the same relname. Actually, it
>    *  should be fixed in upper levels, too, but... -  vadim 05/06/97
>    */
1997-05-06 02:03:20 +00:00
Vadim B. Mikheev
b45128f1c3 Kill re-incarnated bug arround
Assert ( --Vnpages > 0 );
	and
Assert ( --Fnpages > 0 );
1997-05-05 10:01:02 +00:00
Vadim B. Mikheev
3e1933bc05 There is no more _CWD_ tag in sources... 1997-05-05 06:53:36 +00:00
Vadim B. Mikheev
7cbfb19c46 WARN:parser: parser error ...
changed to
WARN:parser: syntax error ...
1997-05-05 06:50:28 +00:00
Vadim B. Mikheev
62d1d23b6b If SELECT uses index (btree) then ordered results are returned. 1997-05-05 06:47:47 +00:00
Vadim B. Mikheev
fb100e6bf2 There is no partial index onek2_u1_prtl in tests... 1997-05-05 06:43:59 +00:00
Vadim B. Mikheev
c3b51e0d67 Bug: backend crashes in btbeginscan()->btrescan()->_bt_orderkeys()
when btree used in innerscan with run-time key which value
passed by pointer.

Fix: keys ordering stuff moved to _bt_first().

Pointed by Thomas Lockhart.
1997-05-05 03:41:19 +00:00
Thomas G. Lockhart
917abdd140 Add substitution from output/.. to input/.. to match templates from inputs. 1997-05-02 13:43:14 +00:00
Thomas G. Lockhart
50f058e26f Update to work with new regression tests and directory structure. 1997-05-02 13:13:44 +00:00
Thomas G. Lockhart
f550efa237 New test data for aggregate functions. 1997-05-02 13:08:11 +00:00
Vadim B. Mikheev
fe91ceb62b Fix old bug in _hash_first() for scan without keys:
if 1st bucket chain is empty then need to continue scan in the rest buckets.
1997-04-30 06:31:16 +00:00
Vadim B. Mikheev
3055eeff93 More informative NOTICEs in tuple checks. 1997-04-30 03:05:43 +00:00
Edmund Mergl
0aba92a2c5 creation for postgresql-6.1 1997-04-29 19:37:10 +00:00
Thomas G. Lockhart
a2fd844c3b Reorder tests and move aggregate table data to data/. 1997-04-29 14:29:16 +00:00
Thomas G. Lockhart
1594bf2a93 Added initial set of expected outputs for new regression testing.
Modified a few tests to match results on RedHat Linux/gcc for v6.1beta.
1997-04-29 14:23:51 +00:00
Vadim B. Mikheev
de97e7fae8 SET geqo TO ON|OFF 1997-04-29 04:38:58 +00:00
Vadim B. Mikheev
a4792bd3d6 #ifdef GEQO
bool _use_geqo_ = true;
#else
bool _use_geqo_ = false;
#endif

_use_geqo_ is settable via SET var TO ...
1997-04-29 04:37:22 +00:00
Vadim B. Mikheev
a1fbd470a9 Fix GroupBy: enable functions over aggregates and GroupBy-ed fields
in target list.
1997-04-29 04:32:50 +00:00
Marc G. Fournier
f4279c46e7 Fix configure so that installbsd gets -c also
From: Lee Roth <roth@tpusa.com>
1997-04-28 22:40:35 +00:00
Marc G. Fournier
81acad4932 Add a netbsd template file and update linux-elf and .similar 1997-04-28 16:19:50 +00:00
Marc G. Fournier
d938b755dc From: "D'Arcy J.M. Cain" <darcy@druid.net>
Subject: [HACKERS] Inputting money

I notice that I have to put single quotes around money amounts if there
is a decimal point in the value.  I appears to be happening because there
is something changing things like "123.45" to "123.450000" and the code
has a problem with that.  There may be a better way to fix this but here
is a simple change to cash.c that lets it accept trailing zeroes.
1997-04-28 16:15:13 +00:00
Thomas G. Lockhart
36712e8808 Provide template for the misc tests which contain path names. 1997-04-27 19:28:23 +00:00