Commit Graph

17 Commits

Author SHA1 Message Date
Bruce Momjian
66cd6a0fb2 Currently, contrib/oid2name doesn't bother to free() the memory that it
malloc()'s. This isn't too serious (because oid2name is a short-lived
utility, so the memory will soon be returned to the OS on process
termination), but I still think it's poor style.

This patch changes oid2name so that it allocates memory on the stack
where possible and free()s the remaining heap-allocated memory. The
patch also fixes a typo a comment and adds 'const' qualifiers to a few
'char *' function parameters.

Neil Conway
2002-03-05 05:54:07 +00:00
Tom Lane
06f08209a9 Fix typo in usage message, per Oleg. 2002-01-25 15:40:13 +00:00
Tom Lane
92a2598f97 The result of getopt() should be compared to -1, not EOF, per
pgsql-hackers discussion of this date.
2002-01-10 01:11:45 +00:00
Bruce Momjian
d4337f6a7c Read getopt() into an int, not char. 2001-11-15 18:40:52 +00:00
Tom Lane
a5dafa3177 Tweak to test HAVE_GETOPT_H before including <getopt.h>, so as to
build on systems without.
2001-10-02 22:38:43 +00:00
Peter Eisentraut
17cc78ef01 To fix the perpetually broken makefiles in the contrib tree, I have
written a generic framework of rules that the contrib makefiles can
use instead of writing their own each time.  You only need to set a few
variables and off you go.
2001-09-06 10:49:30 +00:00
Bruce Momjian
558fae16e3 The attached patch enables the contrib subtree to build cleanly under
Cygwin with the possible exception of mSQL-interface.  Since I don't
have mSQL installed, I skipped this tool.

Except for dealing with a missing getopt.h (oid2name) and HUGE (seg),
the bulk of the patch uses the standard PostgreSQL approach to deal with
Windows DLL issues.

I tested the build aspect of this patch under Cygwin and Linux without
any ill affects.  Note that I did not actually attempt to test the code
for functionality.

The procedure to apply the patch is as follows:

    $ # save the attachment as /tmp/contrib.patch
    $ # change directory to the top of the PostgreSQL source tree
    $ patch -p0 </tmp/contrib.patch

Jason
2001-06-18 21:38:02 +00:00
Bruce Momjian
9e1552607a pgindent run. Make it all clean. 2001-03-22 04:01:46 +00:00
Peter Eisentraut
cb6edf9d56 Make sure -L and -I's for our source tree are always before system include
or library directories on the command line.
2001-02-20 19:20:30 +00:00
Bruce Momjian
d99df62c31 Bruce Momjian <pgman@candle.pha.pa.us> writes:
> OK, add #include <stdio.h> to the file.  That should fix it.

Seems unlikely, since libpq-fe.h already includes <stdio.h>.

The real problem here is that the code is wrong: it's passing NULL
to an int parameter.

                        regards, tom lane
2001-02-12 21:49:24 +00:00
Bruce Momjian
f6df410022 Add stdio to file. 2001-02-12 18:37:35 +00:00
Bruce Momjian
9fdd81de1d Add #include <unistd.h> 2001-02-12 13:55:36 +00:00
Bruce Momjian
623bf843d2 Change Copyright from PostgreSQL, Inc to PostgreSQL Global Development Group. 2001-01-24 19:43:33 +00:00
Bruce Momjian
92681e975d Oops, got binary in there too. 2001-01-24 05:49:09 +00:00
Bruce Momjian
80d24370e0 Oops, had .o file in there. 2001-01-24 05:06:15 +00:00
Bruce Momjian
a939e97451 Update 2001-01-24 03:40:33 +00:00
Bruce Momjian
2c591cb821 Add oid2name. Add streaming option later. 2001-01-24 00:41:25 +00:00