-hackers a couple days ago.
Notes/caveats:
- added regression tests for the new functionality, all
regression tests pass on my machine
- added pg_dump support
- updated PL/PgSQL to support per-statement triggers; didn't
look at the other procedural languages.
- there's (even) more code duplication in trigger.c than there
was previously. Any suggestions on how to refactor the
ExecXXXTriggers() functions to reuse more code would be
welcome -- I took a brief look at it, but couldn't see an
easy way to do it (there are several subtly-different
versions of the code in question)
- updated the documentation. I also took the liberty of
removing a big chunk of duplicated syntax documentation in
the Programmer's Guide on triggers, and moving that
information to the CREATE TRIGGER reference page.
- I also included some spelling fixes and similar small
cleanups I noticed while making the changes. If you'd like
me to split those into a separate patch, let me know.
Neil Conway
results due to doing arithmetic on uninitialized values. Add some
documentation about the AT TIME ZONE construct. Update some other
date/time documentation that seemed out of date for 7.3.
database access outside a transaction; revert bogus performance improvement
in SIBackendInit(); improve comments; add documentation (this part courtesy
Neil Conway).
parameter to allow it to be forced off for comparison purposes.
Add ORDER BY clauses to a bunch of regression test queries that will
otherwise produce randomly-ordered output in the new regime.
- CLUSTER ALL clusters all the tables that have some index with
indisclustered set and the calling user owns.
- CLUSTER tablename clusters the named table, using the index with
indisclustered set. If no index has the bit set, throws elog(ERROR).
- The multi-relation version (CLUSTER ALL) uses a multitransaction
approach, similar to what VACUUM does.
Alvaro Herrera
before commit, not after :-( --- the original coding is not only unsafe
if an error occurs while it's processing, but it generates an invalid
sequence of WAL entries. Resurrect 7.2 logic for deleting items when
no longer needed. Use an enum instead of random macros. Editorialize
on names used for routines and constants. Teach backend/nodes routines
about new field in CreateTable struct. Add a regression test.
PL/PgSQL. Previously, it had been bundled together with the assign
statement implementation, for some reason that wasn't clear to me
(they certainly don't share any code with one another). So I separated
them and made PERFORM a statement like any other. No changes in
functionality.
Along the way, I added some regression tests for PERFORM, added a
bunch more SGML tags to the PL/PgSQL docs, and removed an obsolete
comment relating to the implementation of RETURN NEXT.
Neil Conway
"traditional" behavior, so the change should be transparent. Use the
command "\pset pager always" to turn it on. Anything else does the
normal toggle between "on" and "off"
Greg Sabino Mullane
precision for float4, float8, and geometric types. Set it in pg_dump
so that float data can be dumped/reloaded exactly (at least on platforms
where the float I/O support is properly implemented). Initial patch by
Pedro Ferreira, some additional work by Tom Lane.
the documentation and behavior of "pg_result $res -oid" when $res is not
from an INSERT. The documentation says it should return an empty
string, but in fact it returns 0. I think it used to return an empty
string around PostgreSQL-7.1.3 when PQoidStatus() was used, but now it
uses PQoidValue() which returns InvalidOid, 0 in this case.
Assuming the current behavior is desired, here is a patch to the
documentation doc/src/sgml/libpgtcl.sgml to match what really happens:
ljb
> * Add GUC variables extra_float_digits and extra_double_digits to
> control output digits
419a422
> * Research interaction of setitimer() and sleep() used by statement_timeout
< A dash (-) marks changes that will appear in the upcoming 7.3 release.
> A dash (-) marks changes that will appear in the upcoming 7.4 release.
38d37
< * -Change DEBUG startup tag to LOG (Bruce)
40,51d38
< * -Add pg_backend_pid() function to backend
< * -Allow logging of query durations
<
<
< Permissions
< ===========
<
< * -Improve control over user privileges, including table creation
< * -Allow user/group names to be specified directly in pg_hba.conf (Bruce)
< * -Add ~/.pgpass to store passwords with user/host/password combinations
< * -Allow permissions for functions (Peter E)
< * -Allow object creation to be disabled for specific users
58,60d44
< * -Make it easier to create a database owned by someone who can't createdb,
< perhaps CREATE DATABASE dbname WITH OWNER = "user" (Gavin)
< * -Make equals sign optional in CREATE DATABASE WITH param = 'val'
65,66d48
< * -Prevent SIGHUP and 'pg_ctl reload' from changing command line
< specified parameters to postgresql.conf defaults (Peter E)
69,70d50
< * -Reserve last few process slots for super-user if max_connections reached
< * -Add GUC parameter to print queries that generate errors
79d58
< * -Add domain capability (Rod Taylor)
82,84d60
< * -SELECT cash_out(2) crashes because of opaque
< * -Declare typein/out functions in pg_proc with a special "C string" data type
< * -Functions returning sets do not totally work
89d64
< * -Add GUC parameter for DATESTYLE
91,93d65
< * -Allow bytea to handle LIKE with non-TEXT patterns
< * -to_char(0,'FM999.99') returns a period, to_char(1,'FM999.99') doesn't (Karel)
< * -Add floor(float8) and other missing functions
97d68
< o -Store binary-compatible type information in the system
104d74
< o -Ensure we have array-eq operators for every built-in array type
139,140d108
< * -Remove brackets as multi-statement rule grouping, must use parens (Bruce)
< * -Prevent aggregates from being used in rule WHERE clauses
154d121
< * -Allow UPDATE/DELETE on inherited table
166d132
< * -Add deleted bit to index tuples to reduce heap access
176d141
< * -Test hash index performance and discourage usage
182d146
< * -Add SIMILAR TO to allow character classes, 'pg_[a-c]%'
184d147
< * -Remove LIMIT #,# and force use LIMIT and OFFSET clauses in 7.3 (Bruce)
186,187d148
< * -Disallow TRUNCATE on tables that are involved in referential constraints
< * -Add OR REPLACE clauses to non-FUNCTION object creation
190d150
< * -Prevent create/drop scripts from allowing extra args (Bruce)
201,205d160
< o -Add ALTER TABLE DROP COLUMN feature
< o -Add ALTER TABLE DROP non-CHECK CONSTRAINT
< o -ALTER TABLE ADD PRIMARY KEY (Tom)
< o -ALTER TABLE ADD UNIQUE (Tom)
< o -ALTER TABLE ALTER COLUMN SET/DROP NOT NULL (Christopher)
210d164
< o -Have ALTER TABLE OWNER change all dependant objects like indexes
214,216d167
< o -Cluster all tables at once using pg_index.indisclustered set during
< previous CLUSTER
< o -Prevent loss of indexes, permissions, inheritance
221d171
< o -Allow specification of column names
224d173
< o -Change syntax to WITH DELIMITER, (keep old syntax around?)
228d176
< o -Generate failure on short COPY lines rather than pad NULLs
242,243d189
< o -Allow INSERT INTO my_table VALUES (a, b, c, DEFAULT, x, y, z, ...)
< o -Disallow missing columns in INSERT ... (col) VALUES, per ANSI
248,249d193
< o -Add command to display locks
< o -Add SET or BEGIN timeout parameter to cancel query
251d194
< o -Remove SET KSQO option now that OR processing is improved (Bruce)
254,256d196
< o -Add SHOW command to see locale
< o -Allow SHOW to output as a query result, like EXPLAIN
< o -Abort all SET changes made in an aborted transaction
264d203
< o -Fix PL/PgSQL to handle quoted mixed-case identifiers
287,291d225
< * -Have pg_dump use LEFT OUTER JOIN in multi-table SELECTs
< or multiple SELECTS to avoid bad system catalog entries
< * -Have pg_dump -C dump database location and encoding information
< * -Allow psql \d to show foreign keys
< * -Allow psql \d to show temporary table structure (Tom)
294d227
< * -Have pg_dump use ADD PRIMARY KEY after COPY, for performance (Neil)
302d234
< o -Updateable resultSet
307d238
< o -Implement cancel() method on Statement
309d239
< o -Add support for CallableStatements
311d240
< o -Compile under jdk 1.4
334d262
< * -Allow oid to act as a foreign key
337,338d264
< * -Allow user to control trigger firing order (Tom)
< * -Add ALTER TRIGGER ... RENAME
341d266
< * -Fix foreign key constraints to not error on intermediate db states (Stephan)
350,359d274
< * -Add pg_depend table for dependency recording; use sysrelid, oid,
< depend_sysrelid, depend_oid, name
< * -Auto-destroy sequence on DROP of table with SERIAL; perhaps a separate
< SERIAL type
< * -Prevent column dropping if column is used by foreign key
< * -Propagate column or table renaming to foreign key constraints
< * -Automatically drop constraints/functions when object is dropped
< * -Make foreign key constraints clearer in dump file
< * -Make other constraints clearer in dump file
< * -Make foreign keys easier to identify
367d281
< * -Allow autocommit so always in a transaction block
377d290
< * -Add SQL92 schemas (Tom)
400d312
< * -Cache most recent query plan(s) (Neil) [prepare]
439d350
< * -Cache system catalog information in per-database files (Tom)
450,451d360
< * -Reorder postgresql.conf WAL items in order of importance (Bruce)
< * -Remove wal_files postgresql.conf option because WAL files are now recycled
465,466d373
< * -Improve dynamic memory allocation by introducing tuple-context memory
< allocation (Tom)
468d374
< * -Nested FULL OUTER JOINs don't work (Tom)
470,472d375
< * -Add new pg_proc cachable settings to specify whether function can be
< evaluated only once or once per query
< * -Change FIXED_CHAR_SEL to 0.20 from 0.04 to give better selectivity (Bruce)
494,496d396
< * -Add Intimate Shared Memory(ISM) for Solaris
< * -Use faster flex flags for performance improvement (Peter E)
< * -Add BSD-licensed qsort() for Solaris
503,507d402
< * -Fix problems with libpq non-blocking/async code
< * -Make sure all block numbers are unsigned to increase maximum table size
< * -Merge LockMethodCtl and LockMethodTable into one shared structure (Bruce)
< * -HOLDER/HOLDERTAB rename to PROCLOCK/PROCLOCKTAG (Bruce)
< * -Remove LockMethodTable.prio field, not used (Bruce)
512,513d406
< * -Make one version of simple_prompt() in code (Bruce, Tom)
< * -Compile in syslog functionaility by default (Tatsuo)
517d409
< * -Report failure to find readline or zlib at end of configure run
519,520d410
< * -Increase identifier length (NAMEDATALEN) if small performance hit,
< * -Increase maximum number of function parameters if little wasted space
529,530d418
< * -Fix glibc's mktime() to handle pre-1970's dates
< * -Move /contrib/retep to gborg.postgresql.org
where it's safe to do database access. Along the way, fix core dump
for 'DEFAULT' parameters to CREATE DATABASE. initdb forced due to
change in pg_proc entry.
< * Add floor(float8) and other missing functions
> * -Add floor(float8) and other missing functions
174c174
< * Improve concurrency of hash indexes (Neil Conway)
> * Improve concurrency of hash indexes (Neil)
277c277
< o Allow array declarations and other data types in PL/PgSQl DECLARE
> o Allow array declarations and other data types in PL/PgSQL DECLARE
293c293
< * -Have pg_dump use ADD PRIMARY KEY after COPY, for performance (Neil Conway)
> * -Have pg_dump use ADD PRIMARY KEY after COPY, for performance (Neil)
474c474
< * Precompile SQL functions to avoid overhead (Neil Conway)
> * Precompile SQL functions to avoid overhead (Neil)
549c549
< * Neil is Neil Conway <nconway@klamath.dyndns.org>
> * Neil is Neil Conway <neilc@samurai.com>
rather than being reordered according to INSTEAD attribute for
implementation convenience.
Also, increase compiled-in recursion depth limit from 10 to 100 rewrite
cycles. 10 seems pretty marginal for situations where multiple rules
exist for the same query. There was a complaint about this recently,
so I'm going to bump it up. (Perhaps we should make the limit a GUC
parameter, but that's too close to being a new feature to do in beta.)
a column list. Bring its parsing of quoted names and quoted strings
somewhat up to speed --- I believe it now handles all non-error cases
the same way the backend would, but weird boundary conditions are not
necessarily done the same way.
- Wrap them in the <database class="table"> tags, since thats what they
are (no markup rules for this, so it inherits from parent -- no style
change)
- Mention that pg_database, pg_shadow, and pg_group are global, and the
rest are local to the specific DB. (I believe this is correct).
> Works for me, though I suppose we could explain what the exceptions are
> like in general terms. Perhaps something like
>
> 'Most system catalogs are copied from the template database during
> database creation, and are thereafter database-specific. A few
> catalogs are physically shared across all databases in an installation;
> these are marked in the descriptions of the individual catalogs.'
Ok, new patch.
Rod Taylor
> > > > found in the postmaster and not included from elsewhere)
> >
> > shared libs on AIX need to be able to resolve all symbols at linkage time.
> > Those two symbols are in backend/utils/SUBSYS.o but not in the postgres
> > executable.
>
> They are defined in backend/utils/mb/conv.c and declared in
> include/mb/pg_wchar.h. They're also linked into the
> postmaster. I don't see anything unusual.
Attached is a patch to fix the mb linking problems on AIX. As a nice side effect
it reduces the duplicate symbol warnings to linking libpq.so and libecpg.so
(all shlibs that are not postmaster loadable modules).
Please apply to current (only affects AIX).
The _LARGE_FILES problem is unfortunately still open, unless Peter
has fixed it per his recent idea.
Zeugswetter Andreas SB SD
Bruce Momjian
Tom Lane
Peter Eisentraut
Barry Lind
Tatsuo Ishii