Compare commits

...

2 Commits

Author SHA1 Message Date
Masahiko Sawada 2d758dca1b Fix wrong description of BackgroundPsql's timeout.
Backpatch through 16 where this was introduced by 664d757531.

Reviewed-by: Daniel Gustafsson
Backpatch-through: 16
Discussion: http://postgr.es/m/CAD21AoBXMEqDBLoDuAWVWoTLYB4aNsxx4oYNmyJJbhfq_vGQBQ@mail.gmail.com
2023-11-30 11:23:05 +09:00
Masahiko Sawada c684d7c80f Fix BackgroundPsql's set_query_timer_restart() issue without argument.
The set_query_timer_restart() required an argument to define a value
to query_timer_restart, but none of the existing callers passes an
argument to this function.

This changes the function to set a value without an argument.

Backpatch through 16 where the background psql TAP functions were
refactored by 664d757531.

Reviewed-by: Bharath Rupireddy, Tom Lane
Discussion: https://postgr.es/m/CAD21AoA0B6VKe_5A9nZi8i5umwSN-zJJuPVNht9DaOZ9SJumMA@mail.gmail.com
Backpatch-through: 16
2023-11-30 10:14:26 +09:00
2 changed files with 3 additions and 5 deletions

View File

@ -301,7 +301,7 @@ sub set_query_timer_restart
{
my $self = shift;
$self->{query_timer_restart} = shift if @_;
$self->{query_timer_restart} = 1;
return $self->{query_timer_restart};
}

View File

@ -1972,8 +1972,7 @@ sub psql
Invoke B<psql> on B<$dbname> and return a BackgroundPsql object.
A default timeout of $PostgreSQL::Test::Utils::timeout_default is set up,
which can be modified later.
A timeout of $PostgreSQL::Test::Utils::timeout_default is set up.
psql is invoked in tuples-only unaligned mode with reading of B<.psqlrc>
disabled. That may be overridden by passing extra psql parameters.
@ -2039,8 +2038,7 @@ sub background_psql
Invoke B<psql> on B<$dbname> and return a BackgroundPsql object, which the
caller may use to send interactive input to B<psql>.
A default timeout of $PostgreSQL::Test::Utils::timeout_default is set up,
which can be modified later.
A timeout of $PostgreSQL::Test::Utils::timeout_default is set up.
psql is invoked in tuples-only unaligned mode with reading of B<.psqlrc>
disabled. That may be overridden by passing extra psql parameters.