asprintf(), aside from not being particularly portable, has a fundamentally badly-designed API; the psprintf() function that was added in passing in the previous patch has a much better API choice. Moreover, the NetBSD implementation that was borrowed for the previous patch doesn't work with non-C99-compliant vsnprintf, which is something we still have to cope with on some platforms; and it depends on va_copy which isn't all that portable either. Get rid of that code in favor of an implementation similar to what we've used for many years in stringinfo.c. Also, move it into libpgcommon since it's not really libpgport material. I think this patch will be enough to turn the buildfarm green again, but there's still cosmetic work left to do, namely get rid of pg_asprintf() in favor of using psprintf(). That will come in a followon patch. |
||
---|---|---|
.. | ||
.gitignore | ||
Makefile | ||
README | ||
chklocale.c | ||
crypt.c | ||
dirent.c | ||
dirmod.c | ||
erand48.c | ||
fls.c | ||
fseeko.c | ||
getaddrinfo.c | ||
gethostname.c | ||
getopt.c | ||
getopt_long.c | ||
getpeereid.c | ||
getrusage.c | ||
gettimeofday.c | ||
inet_aton.c | ||
inet_net_ntop.c | ||
isinf.c | ||
kill.c | ||
memcmp.c | ||
noblock.c | ||
open.c | ||
path.c | ||
pg_crc.c | ||
pgcheckdir.c | ||
pgmkdirp.c | ||
pgsleep.c | ||
pgstrcasecmp.c | ||
pqsignal.c | ||
pthread-win32.h | ||
qsort.c | ||
qsort_arg.c | ||
quotes.c | ||
random.c | ||
rint.c | ||
snprintf.c | ||
sprompt.c | ||
srandom.c | ||
strerror.c | ||
strlcat.c | ||
strlcpy.c | ||
tar.c | ||
thread.c | ||
unsetenv.c | ||
win32.ico | ||
win32env.c | ||
win32error.c | ||
win32setlocale.c | ||
win32ver.rc |
README
src/port/README libpgport ========= libpgport must have special behavior. It supplies functions to both libraries and applications. However, there are two complexities: 1) Libraries need to use object files that are compiled with exactly the same flags as the library. libpgport might not use the same flags, so it is necessary to recompile the object files for individual libraries. This is done by removing -lpgport from the link line: # Need to recompile any libpgport object files LIBS := $(filter-out -lpgport, $(LIBS)) and adding infrastructure to recompile the object files: OBJS= execute.o typename.o descriptor.o data.o error.o prepare.o memory.o \ connect.o misc.o path.o exec.o \ $(filter snprintf.o, $(LIBOBJS)) The problem is that there is no testing of which object files need to be added, but missing functions usually show up when linking user applications. 2) For applications, we use -lpgport before -lpq, so the static files from libpgport are linked first. This avoids having applications dependent on symbols that are _used_ by libpq, but not intended to be exported by libpq. libpq's libpgport usage changes over time, so such a dependency is a problem. Win32, Linux, and Darwin use an export list to control the symbols exported by libpq.