mirror of
https://git.postgresql.org/git/postgresql.git
synced 2024-10-01 16:11:22 +02:00
c7b8998ebb
Change pg_bsd_indent to follow upstream rules for placement of comments
to the right of code, and remove pgindent hack that caused comments
following #endif to not obey the general rule.
Commit e3860ffa4d wasn't actually using
the published version of pg_bsd_indent, but a hacked-up version that
tried to minimize the amount of movement of comments to the right of
code. The situation of interest is where such a comment has to be
moved to the right of its default placement at column 33 because there's
code there. BSD indent has always moved right in units of tab stops
in such cases --- but in the previous incarnation, indent was working
in 8-space tab stops, while now it knows we use 4-space tabs. So the
net result is that in about half the cases, such comments are placed
one tab stop left of before. This is better all around: it leaves
more room on the line for comment text, and it means that in such
cases the comment uniformly starts at the next 4-space tab stop after
the code, rather than sometimes one and sometimes two tabs after.
Also, ensure that comments following #endif are indented the same
as comments following other preprocessor commands such as #else.
That inconsistency turns out to have been self-inflicted damage
from a poorly-thought-through post-indent "fixup" in pgindent.
This patch is much less interesting than the first round of indent
changes, but also bulkier, so I thought it best to separate the effects.
Discussion: https://postgr.es/m/E1dAmxK-0006EE-1r@gemulon.postgresql.org
Discussion: https://postgr.es/m/30527.1495162840@sss.pgh.pa.us
112 lines
2.6 KiB
C
112 lines
2.6 KiB
C
/* src/tutorial/funcs.c */
|
|
|
|
/******************************************************************************
|
|
These are user-defined functions that can be bound to a Postgres backend
|
|
and called by Postgres to execute SQL functions of the same name.
|
|
|
|
The calling format for these functions is defined by the CREATE FUNCTION
|
|
SQL statement that binds them to the backend.
|
|
|
|
NOTE: this file shows examples of "old style" function call conventions.
|
|
See funcs_new.c for examples of "new style".
|
|
*****************************************************************************/
|
|
|
|
#include "postgres.h" /* general Postgres declarations */
|
|
|
|
#include "executor/executor.h" /* for GetAttributeByName() */
|
|
#include "utils/geo_decls.h" /* for point type */
|
|
|
|
PG_MODULE_MAGIC;
|
|
|
|
/* These prototypes just prevent possible warnings from gcc. */
|
|
|
|
int add_one(int arg);
|
|
float8 *add_one_float8(float8 *arg);
|
|
Point *makepoint(Point *pointx, Point *pointy);
|
|
text *copytext(text *t);
|
|
text *concat_text(text *arg1, text *arg2);
|
|
bool c_overpaid(HeapTupleHeader t, /* the current instance of EMP */
|
|
int32 limit);
|
|
|
|
|
|
/* By Value */
|
|
|
|
int
|
|
add_one(int arg)
|
|
{
|
|
return arg + 1;
|
|
}
|
|
|
|
/* By Reference, Fixed Length */
|
|
|
|
float8 *
|
|
add_one_float8(float8 *arg)
|
|
{
|
|
float8 *result = (float8 *) palloc(sizeof(float8));
|
|
|
|
*result = *arg + 1.0;
|
|
|
|
return result;
|
|
}
|
|
|
|
Point *
|
|
makepoint(Point *pointx, Point *pointy)
|
|
{
|
|
Point *new_point = (Point *) palloc(sizeof(Point));
|
|
|
|
new_point->x = pointx->x;
|
|
new_point->y = pointy->y;
|
|
|
|
return new_point;
|
|
}
|
|
|
|
/* By Reference, Variable Length */
|
|
|
|
text *
|
|
copytext(text *t)
|
|
{
|
|
/*
|
|
* VARSIZE is the total size of the struct in bytes.
|
|
*/
|
|
text *new_t = (text *) palloc(VARSIZE(t));
|
|
|
|
SET_VARSIZE(new_t, VARSIZE(t));
|
|
|
|
/*
|
|
* VARDATA is a pointer to the data region of the struct.
|
|
*/
|
|
memcpy((void *) VARDATA(new_t), /* destination */
|
|
(void *) VARDATA(t), /* source */
|
|
VARSIZE(t) - VARHDRSZ); /* how many bytes */
|
|
return new_t;
|
|
}
|
|
|
|
text *
|
|
concat_text(text *arg1, text *arg2)
|
|
{
|
|
int32 arg1_size = VARSIZE(arg1) - VARHDRSZ;
|
|
int32 arg2_size = VARSIZE(arg2) - VARHDRSZ;
|
|
int32 new_text_size = arg1_size + arg2_size + VARHDRSZ;
|
|
text *new_text = (text *) palloc(new_text_size);
|
|
|
|
SET_VARSIZE(new_text, new_text_size);
|
|
memcpy(VARDATA(new_text), VARDATA(arg1), arg1_size);
|
|
memcpy(VARDATA(new_text) + arg1_size, VARDATA(arg2), arg2_size);
|
|
return new_text;
|
|
}
|
|
|
|
/* Composite types */
|
|
|
|
bool
|
|
c_overpaid(HeapTupleHeader t, /* the current instance of EMP */
|
|
int32 limit)
|
|
{
|
|
bool isnull;
|
|
int32 salary;
|
|
|
|
salary = DatumGetInt32(GetAttributeByName(t, "salary", &isnull));
|
|
if (isnull)
|
|
return false;
|
|
return salary > limit;
|
|
}
|