postgresql/src/backend
Tom Lane 0ab1a2e39b Remove dead encoding-conversion functions.
The code for conversions SQL_ASCII <-> MULE_INTERNAL and
SQL_ASCII <-> UTF8 was unreachable, because we long ago changed
the wrapper functions pg_do_encoding_conversion() et al so that
they have hard-wired behaviors for conversions involving SQL_ASCII.
(At least some of those fast paths date back to 2002, though it
looks like we may not have been totally consistent about this until
later.)  Given the lack of complaints, nobody is dissatisfied with
this state of affairs.  Hence, let's just remove the unreachable code.

Also, change CREATE CONVERSION so that it rejects attempts to
define such conversions.  Since we consider that SQL_ASCII represents
lack of knowledge about the encoding in use, such a conversion would
be semantically dubious even if it were reachable.

Adjust a couple of regression test cases that had randomly decided
to rely on these conversion functions rather than any other ones.

Discussion: https://postgr.es/m/41163.1559156593@sss.pgh.pa.us
2019-07-05 14:17:27 -04:00
..
access Unwind some workarounds for lack of portable int64 format specifier 2019-07-04 17:01:43 +02:00
bootstrap In bootstrap mode, use default signal handling for SIGINT etc. 2019-05-14 10:22:28 -04:00
catalog Add missing serial commas 2019-07-01 13:07:14 +02:00
commands Remove dead encoding-conversion functions. 2019-07-05 14:17:27 -04:00
executor pgindent run prior to branching v12. 2019-07-01 12:37:52 -04:00
foreign Update copyright for 2019 2019-01-02 12:44:25 -05:00
jit Fix more typos and inconsistencies in the tree 2019-06-17 16:13:16 +09:00
lib Fix more typos and inconsistencies in the tree 2019-06-17 16:13:16 +09:00
libpq Introduce safer encoding and decoding routines for base64.c 2019-07-04 16:08:09 +09:00
main Replace @postgresql.org with @lists.postgresql.org for mailinglists 2019-01-19 19:06:35 +01:00
nodes Fix many typos and inconsistencies 2019-07-01 10:00:23 +09:00
optimizer Don't remove surplus columns from GROUP BY for inheritance parents 2019-07-03 23:44:54 +12:00
parser Fix many typos and inconsistencies 2019-07-01 10:00:23 +09:00
partitioning pgindent run prior to branching v12. 2019-07-01 12:37:52 -04:00
po Translation updates 2019-06-17 15:30:20 +02:00
port Update stale comments, and fix comment typos. 2019-06-08 10:12:26 -07:00
postmaster Fix many typos and inconsistencies 2019-07-01 10:00:23 +09:00
regex Phase 2 pgindent run for v12. 2019-05-22 13:04:48 -04:00
replication Unwind some workarounds for lack of portable int64 format specifier 2019-07-04 17:01:43 +02:00
rewrite Fix many typos and inconsistencies 2019-07-01 10:00:23 +09:00
snowball Sync our Snowball stemmer dictionaries with current upstream 2019-07-04 13:26:48 +02:00
statistics Remove unused variable in statext_mcv_serialize() 2019-07-05 18:51:56 +02:00
storage Fix many typos and inconsistencies 2019-07-01 10:00:23 +09:00
tcop Fix partitioned index creation with foreign partitions 2019-06-26 18:38:51 -04:00
tsearch Phase 2 pgindent run for v12. 2019-05-22 13:04:48 -04:00
utils Remove dead encoding-conversion functions. 2019-07-05 14:17:27 -04:00
.gitignore Add .gitignore entries for AIX-specific intermediate build artifacts. 2015-07-08 20:44:22 -04:00
common.mk Remove PARTIAL_LINKING build mode. 2018-03-30 17:33:04 -07:00
Makefile Get rid of jsonpath_gram.h and jsonpath_scanner.h 2019-03-20 11:13:34 +03:00
nls.mk Translation updates 2019-05-20 16:00:53 +02:00