postgresql/contrib/btree_gist
Tom Lane fedc97cdfd Remove ruleutils.c's special case for BIT [VARYING] literals.
Up to now, get_const_expr() insisted on prefixing BIT and VARBIT
literals with 'B'.  That's not really necessary, because we always
append explicit-cast syntax to identify the constant's type.
Moreover, it's subtly wrong for VARBIT, because the parser will
interpret B'...' as '...'::"bit"; see make_const() which explicitly
assigns type BITOID for a T_BitString literal.  So what had been
a simple VARBIT literal is reconstructed as ('...'::"bit")::varbit,
which is not the same thing, at least not before constant folding.
This results in odd differences after dump/restore, as complained
of by the patch submitter, and it could result in actual failures in
partitioning or inheritance DDL operations (see commit 542320c2b,
which repaired similar misbehaviors for some other data types).

Fixing it is pretty easy: just remove the special case and let the
default code path handle these types.  We could have kept the special
case for BIT only, but there seems little point in that.

Like the previous patch, I judge that back-patching this into stable
branches wouldn't be a good idea.  However, it seems not quite too
late for v11, so let's fix it there.

Paul Guo, reviewed by Davy Machado and John Naylor, minor adjustments
by me

Discussion: https://postgr.es/m/CABQrizdTra=2JEqA6+Ms1D1k1Kqw+aiBBhC9TreuZRX2JzxLAA@mail.gmail.com
2018-09-11 16:32:25 -04:00
..
data Add btree_gist support for enum types. 2017-03-21 10:43:27 -04:00
expected Remove ruleutils.c's special case for BIT [VARYING] literals. 2018-09-11 16:32:25 -04:00
sql Fix IOS planning when only some index columns can return an attribute. 2018-03-01 15:35:03 -05:00
.gitignore Support "make check" in contrib 2011-04-25 22:27:11 +03:00
btree_bit.c Change TRUE/FALSE to true/false 2017-11-08 11:37:28 -05:00
btree_bytea.c Change TRUE/FALSE to true/false 2017-11-08 11:37:28 -05:00
btree_cash.c Consistently use PG_INT(16|32|64)_(MIN|MAX). 2017-12-12 18:19:13 -08:00
btree_date.c Phase 3 of pgindent updates. 2017-06-21 15:35:54 -04:00
btree_enum.c Phase 3 of pgindent updates. 2017-06-21 15:35:54 -04:00
btree_float4.c Phase 3 of pgindent updates. 2017-06-21 15:35:54 -04:00
btree_float8.c Phase 3 of pgindent updates. 2017-06-21 15:35:54 -04:00
btree_gist--1.0--1.1.sql Add index-only scan support to btree_gist. 2015-03-27 23:35:16 +02:00
btree_gist--1.1--1.2.sql Handle contrib's GIN/GIST support function signature changes honestly. 2016-06-09 16:44:25 -04:00
btree_gist--1.2--1.3.sql Add uuid to the set of types supported by contrib/btree_gist. 2016-11-29 14:08:34 -05:00
btree_gist--1.2.sql Handle contrib's GIN/GIST support function signature changes honestly. 2016-06-09 16:44:25 -04:00
btree_gist--1.3--1.4.sql Add support for EUI-64 MAC addresses as macaddr8 2017-03-15 11:16:25 -04:00
btree_gist--1.4--1.5.sql Add btree_gist support for enum types. 2017-03-21 10:43:27 -04:00
btree_gist--unpackaged--1.0.sql Fix typos in some error messages thrown by extension scripts when fed to psql. 2014-08-25 18:30:37 +02:00
btree_gist.c Create function prototype as part of PG_FUNCTION_INFO_V1 macro 2014-04-18 00:03:19 -04:00
btree_gist.control Add btree_gist support for enum types. 2017-03-21 10:43:27 -04:00
btree_gist.h Add btree_gist support for enum types. 2017-03-21 10:43:27 -04:00
btree_inet.c Fix assorted issues in convert_to_scalar(). 2018-03-03 20:31:35 -05:00
btree_int2.c Consistently use PG_INT(16|32|64)_(MIN|MAX). 2017-12-12 18:19:13 -08:00
btree_int4.c Consistently use PG_INT(16|32|64)_(MIN|MAX). 2017-12-12 18:19:13 -08:00
btree_int8.c Consistently use PG_INT(16|32|64)_(MIN|MAX). 2017-12-12 18:19:13 -08:00
btree_interval.c Change TRUE/FALSE to true/false 2017-11-08 11:37:28 -05:00
btree_macaddr8.c Phase 3 of pgindent updates. 2017-06-21 15:35:54 -04:00
btree_macaddr.c Phase 3 of pgindent updates. 2017-06-21 15:35:54 -04:00
btree_numeric.c Change TRUE/FALSE to true/false 2017-11-08 11:37:28 -05:00
btree_oid.c Phase 3 of pgindent updates. 2017-06-21 15:35:54 -04:00
btree_text.c Change TRUE/FALSE to true/false 2017-11-08 11:37:28 -05:00
btree_time.c Change TRUE/FALSE to true/false 2017-11-08 11:37:28 -05:00
btree_ts.c Provide separate header file for built-in float types 2018-07-29 03:30:48 +02:00
btree_utils_num.c Change TRUE/FALSE to true/false 2017-11-08 11:37:28 -05:00
btree_utils_num.h Use new overflow aware integer operations. 2017-12-12 16:55:37 -08:00
btree_utils_var.c Change TRUE/FALSE to true/false 2017-11-08 11:37:28 -05:00
btree_utils_var.h Phase 2 of pgindent updates. 2017-06-21 15:19:25 -04:00
btree_uuid.c Change TRUE/FALSE to true/false 2017-11-08 11:37:28 -05:00
Makefile Add btree_gist support for enum types. 2017-03-21 10:43:27 -04:00